From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Cournoyer Subject: Re: Generated patches change over time Date: Thu, 29 Nov 2018 14:48:37 +0000 Message-ID: References: <20181124183051.23027.37347@vcs0.savannah.gnu.org> <20181124183052.9A76B209A2@vcs0.savannah.gnu.org> <87h8g5unug.fsf@gnu.org> <87pnuskfmg.fsf@netris.org> <87h8g15uqb.fsf_-_@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSNlt-0008GY-Rg for guix-devel@gnu.org; Thu, 29 Nov 2018 09:58:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSNfI-0007vf-74 for guix-devel@gnu.org; Thu, 29 Nov 2018 09:51:45 -0500 In-Reply-To: <87h8g15uqb.fsf_-_@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org, ludo@gnu.org, Mark H Weaver Hello! >> ludo@gnu=2Eorg (Ludovic Court=C3=A8s) writes: >Lesson learned: we should not rely at all on generated patches because >they are bound to change frequently (version string at the end, length >of commit hash prefixes, etc=2E) It=E2=80=99s probably worse than tarbal= ls >generated by Git hosting services=2E > >So we should probably work towards using local copies of patches, >unless >we find that the generated patches do not include any variable bits=2E > Maybe we could pass the patches through some sanitizer to strip any metada= ta? I guess the content itself shouldn't change? Maxim