From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: guix-devel@gnu.org, ludo@gnu.org, Mark H Weaver <mhw@netris.org>
Subject: Re: Generated patches change over time
Date: Thu, 29 Nov 2018 14:48:37 +0000 [thread overview]
Message-ID: <D151A49F-1A10-4C4F-B2C1-4DD27385D077@gmail.com> (raw)
In-Reply-To: <87h8g15uqb.fsf_-_@gnu.org>
Hello!
>> ludo@gnu.org (Ludovic Courtès) writes:
>Lesson learned: we should not rely at all on generated patches because
>they are bound to change frequently (version string at the end, length
>of commit hash prefixes, etc.) It’s probably worse than tarballs
>generated by Git hosting services.
>
>So we should probably work towards using local copies of patches,
>unless
>we find that the generated patches do not include any variable bits.
>
Maybe we could pass the patches through some sanitizer to strip any metadata? I guess the content itself shouldn't change?
Maxim
next prev parent reply other threads:[~2018-11-29 14:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181124183051.23027.37347@vcs0.savannah.gnu.org>
[not found] ` <20181124183052.9A76B209A2@vcs0.savannah.gnu.org>
2018-11-25 16:24 ` 01/02: gnu: rhythmbox: Update hash of patch Ludovic Courtès
2018-11-25 21:31 ` Mark H Weaver
2018-11-28 11:04 ` Generated patches change over time Ludovic Courtès
2018-11-28 17:59 ` Mark H Weaver
2018-12-02 0:24 ` Ludovic Courtès
2018-11-29 14:48 ` Maxim Cournoyer [this message]
2018-12-01 21:37 ` Ludovic Courtès
2018-12-01 22:29 ` Mark H Weaver
2018-12-02 10:38 ` Ludovic Courtès
2018-12-02 19:36 ` Maxim Cournoyer
2018-12-02 20:33 ` Mark H Weaver
2018-12-31 2:12 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D151A49F-1A10-4C4F-B2C1-4DD27385D077@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.