From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id +PqEANtRLGUdbAEAauVa8A:P1 (envelope-from ) for ; Sun, 15 Oct 2023 22:55:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id +PqEANtRLGUdbAEAauVa8A (envelope-from ) for ; Sun, 15 Oct 2023 22:55:55 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E07798C5C for ; Sun, 15 Oct 2023 22:55:53 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=twilken.net header.s=mythic-beasts-k1 header.b=KmnpP4DR; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697403354; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=k7A6NJKCay06GHLiIAj4NQOQ9gtN+8vXwR418wSJJf4=; b=PxTq5MbP+r54E3sV5vmyhBKQZE7qezbTNqY0uhdqcircKMtxCn+UexKKgsGjzsKHyF5oLt smGajy7SzYbeSZTROqRHVAKOsEhc4nZF85DNIz1xDuy7nGbqtmUH39yx2+9GNz7CXj2yO4 gAYwXW1EO8eokDB23FRnmWk2g8YIG8y6c+Q6wdBW5uHEYz0Gm4J8txXDvrpqaLLmyg/0qe eU+bRXfxnR5KDWPW1OPBTYEPkQa6HxEwep3KhhXwZqRlHsL3zDsu4rVX4ZxAfVx0w9d++1 vZyvbr+HmQkPMZNtWna0nyw5Iapz8sRNNdxQJHFbDtjLuMYqPOq5UlvYESrRcw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697403354; a=rsa-sha256; cv=none; b=FccTRZSLBGJ4IcNU+QAB1Nr/fq8iqnDAHemoBmT10hyaYeB3/GCUCaLErnLdGhq3wHBWov 1cA0FmOsE6Ys1A7fJNXUfCbP62MHBp7ZURunXH9AMl0gynaoZCewr5zrtGGPbjPaGW1naX 0A/QlFU8PdBYVRdp8uJZ6UAOhUgNiazen/faAz9nm/QvPIBwI0WD/e7niuWc4DxV33rrZI 43vi23I8j6rTbYCt0AolN0tgNEZeTY7onxgIFqJURZHRpgku7zunoI8UyC6g+T2YzYv98H 1yjux/sdstkHxrLuxMfb1mUKiLgX9HrEOzSyccjS274HQj0YFeWK4kudB2rb0w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=twilken.net header.s=mythic-beasts-k1 header.b=KmnpP4DR; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qs89E-0004as-Jk; Sun, 15 Oct 2023 16:55:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qs89C-0004aj-2w for guix-patches@gnu.org; Sun, 15 Oct 2023 16:55:38 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qs89B-00071x-RT for guix-patches@gnu.org; Sun, 15 Oct 2023 16:55:37 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qs89Z-0007KJ-Nu for guix-patches@gnu.org; Sun, 15 Oct 2023 16:56:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63877] [PATCH v2] gnu: services: web: Allow specifying extra php-fpm environment variables. Resent-From: "Timo Wilken" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Oct 2023 20:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63877 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: "Bruno Victal" , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 63877@debbugs.gnu.org Received: via spool by 63877-submit@debbugs.gnu.org id=B63877.169740330427859 (code B ref 63877); Sun, 15 Oct 2023 20:56:01 +0000 Received: (at 63877) by debbugs.gnu.org; 15 Oct 2023 20:55:04 +0000 Received: from localhost ([127.0.0.1]:54220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs88d-0007FH-Lv for submit@debbugs.gnu.org; Sun, 15 Oct 2023 16:55:03 -0400 Received: from mx1.mythic-beasts.com ([2a00:1098:0:86:1000:0:2:1]:44529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs88Z-0007Eh-Ic for 63877@debbugs.gnu.org; Sun, 15 Oct 2023 16:55:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=twilken.net ; s=mythic-beasts-k1; h=From:Subject:To:Date; bh=k7A6NJKCay06GHLiIAj4NQOQ9gtN+8vXwR418wSJJf4=; b=KmnpP4DRVT0ptSge2ydXelCoKl E36DqEkK4fjNhI75IDPj/e/yBoB7x/AjSHUBy9BDfyyQL8tj4LHKE4xwALi0XOO2sKko82HL2kl+c zFSEs6RRx3RFJqpQXzaMWXE8J9EL0aF4nlZqFQ/YXHomS32JX64VVi3mOFQEVW0B7fvgqVhHgp2xr pQVhKv64LS++3jLyh/1YT06M3g9LoafhmDHwSyEG+ODYf9NQZyj0FGjH+AQINe6pZwQc+2h5wovmw r801M+YGPdahvOzTg4B+lrz7oxwdCaemFx17DP0HZykG6LkQLSPT+jUI8iE+ZD8lJfrU0VIsNLkLu qdDnvipQ==; Received: by mailhub-cam-d.mythic-beasts.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qs880-00BFT4-Ej; Sun, 15 Oct 2023 21:54:24 +0100 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 15 Oct 2023 22:54:06 +0200 From: "Timo Wilken" Message-Id: X-Mailer: aerc 0.15.2 References: In-Reply-To: X-BlackCat-Spam-Score: 7 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -1.87 X-Migadu-Queue-Id: E07798C5C X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -1.87 X-TUID: KtVeHcP4CBHb Hi Bruno, (hi Ludo'), thank you for your detailed feedback and sorry for no= t responding earlier! On Mon Jun 5, 2023 at 5:44 AM CEST, Bruno Victal wrote: > Ungexp-ing lists can be rather tricky [...] > > You need to quote the list [...] I was thinking of something closer to the example I added to doc/guix.texi = in my patch. The gexp would not be a list directly, but instead be some code t= hat would produce a list when evaluated, e.g.: --8<---------------cut here---------------start------------->8--- #~(list (string-append "SSL_CERT_DIR=3D" #$nss-certs "/etc/ssl/certs")))) --8<---------------cut here---------------end--------------->8--- That would let you refer to store paths in variable values, instead of bein= g limited to literal strings. As far as I know, the following throws an error, and `file-append' instead = of `string-append' wouldn't work because of the `"SSL_CERT_DIR=3D"' prefix, ri= ght? --8<---------------cut here---------------start------------->8--- #~(#$(string-append "SSL_CERT_DIR=3D" nss-certs "/etc/ssl/certs")))) --8<---------------cut here---------------end--------------->8--- If you have any ideas on a better way to do this, let me know! > Bonus points if you can write a small system test for this. (see > gnu/tests/web.scm for inspiration) > For our purposes, a pair of HTTP servers where one of them uses a > self-signed certificate will suffice. Thanks for the pointer! I'll try to get something basic working along the lines of the php-fpm tests already there, and send a PATCH v3 soon. I was thinking of only verifying that an arbitrary sentinel variable is set, and = not bother to test SSL_*-related behaviour, but I can try to get the latter working if you think that would be better.