From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oJ9ZAm+O4mPgygAAbAwnHQ (envelope-from ) for ; Tue, 07 Feb 2023 18:46:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GCFcAW+O4mPY/QAAG6o9tA (envelope-from ) for ; Tue, 07 Feb 2023 18:46:23 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8AF6E9718 for ; Tue, 7 Feb 2023 18:46:22 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPS2j-0002mA-HA; Tue, 07 Feb 2023 12:46:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPS2d-0002jc-3H for guix-patches@gnu.org; Tue, 07 Feb 2023 12:46:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPS2c-00061A-N5 for guix-patches@gnu.org; Tue, 07 Feb 2023 12:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPS2c-00032A-Ix for guix-patches@gnu.org; Tue, 07 Feb 2023 12:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60904] [PATCH 05/25] gnu: Add go-github-com-google-safehtml. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Feb 2023 17:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60904 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: cox.katherine.e@gmail.com, 60904@debbugs.gnu.org X-Debbugs-Original-To: "Katherine Cox-Buday" , "( via Guix-patches via" X-Debbugs-Original-Cc: 60904@debbugs.gnu.org Received: via spool by 60904-submit@debbugs.gnu.org id=B60904.167579192111585 (code B ref 60904); Tue, 07 Feb 2023 17:46:02 +0000 Received: (at 60904) by debbugs.gnu.org; 7 Feb 2023 17:45:21 +0000 Received: from localhost ([127.0.0.1]:53942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPS1x-00030n-4o for submit@debbugs.gnu.org; Tue, 07 Feb 2023 12:45:21 -0500 Received: from knopi.disroot.org ([178.21.23.139]:38514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPS1v-00030f-Bd for 60904@debbugs.gnu.org; Tue, 07 Feb 2023 12:45:19 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 90FF440EA7; Tue, 7 Feb 2023 18:45:18 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7ocfm-v4vJ8B; Tue, 7 Feb 2023 18:45:17 +0100 (CET) Content-Type: multipart/signed; boundary=776382c2e1c0130c1fccd3705d66ebc875f4aa4d19da405c37b0435c64ed; micalg=pgp-sha512; protocol="application/pgp-signature" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1675791917; bh=+IV3TZIWk81NTDH6YbE+aOUHdlg0ElRb7hD1UB+ti0U=; h=Date:Cc:Subject:From:To:References:In-Reply-To; b=aOfWgFruDLftDjp6ExeRGzoBeK7LadpEJZ7Ymg51a/3UB6nfYrN/l1wn5O2USyR1J /uka8SWcGUnulLnOsYlr+LCrppdL8iy8RawPvgjeyV/UvnK66e4W/TJVs2/bw+2pob AC8+5zAvylKLh/pWRl4oP7y5GFITT7ZQL1vRd46CMGwosKIzTeOogA4BGrJgu4R5aP qgnTcrnJtUlAvAGC94QxSi1MR9DBSBWHr4dbGmC/ZMk/5MiH2+yTyks34ucsAH6mR7 GmVKiFgoy4UtkoH1t0HojmLySjBSUoP5M0YgPcBjz5C+kIET9CMnaI1CHkGZp2QSso v9yTtaxD7v/mQ== Date: Tue, 07 Feb 2023 17:45:15 +0000 Message-Id: References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <20230118014510.19320-6-cox.katherine.e@gmail.com> <87r0v1xwbf.fsf@gmail.com> In-Reply-To: <87r0v1xwbf.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=aOfWgFru; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675791982; a=rsa-sha256; cv=none; b=J5HOPlv05vXwFXBnu/oH5XjKxe8UFUSRtEHyeJ0vhAwngN0FNpdbn67dAYmktWoMTZtXe5 N937n8ur/frnneYZ6MohJ7zzNg/Jh/F56lTSb3JA1NKJ2p8D2ki3pyzf7mTN7jqiRaXIuk 8aFVvXlkwGAb233jbG5AeFUH66620z1o0OmVqJama2KP+muohb0VU/wpA2vVDnrPUMW9B0 v9xaOqF5wF9TsQwSAo9ob37bjFA/DetYjEamEuLQZrVew04/pvNmaY4TubSWZEvgWoPPeZ 6AkDL4y+ILvjQ2nDW+zFKf5rO9X7Zhiqe4N/FGhoSQE9S4nPmBwe07KvxS+uXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675791982; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:content-type:content-type:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4U7o18FH4DGNEYu+D+uaWSioKqTByV4pQ3GDoZ/Tftg=; b=NVHcEOptnD6n8O0Sr8jzKHhYEz95LbAwxktu8mKyxs0hJCHVwrZTrwy32CuTEJ7gdNAH2G BijPLdJHlnsoDKK7FHZ/fFyvYbaCaSoXnQRPXBYApOaiXGdIf7BwBfEbitZERGceAfFib9 qPoqhdo115mxnHwDUblgcR84ScqcydO+KhlJ+ffBSC5QsD98pNaCuM93WOovYClj22krIO l18KKFL2He+ig/C5F6B3E26C+dPjecW3U0uXehzx3T6YpuK/1HlvK+KYRJMgTWr0WShAu4 R3FBMMqOJGezF/cBi5FFKlOzJcb8NmES8O6LdOwAUtq37R0EZahSyLNV7k7zeQ== X-Migadu-Queue-Id: 8AF6E9718 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=aOfWgFru; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Spam-Score: -3.69 X-Spam-Score: -3.69 X-TUID: 4MHX8mAS4IM5 --776382c2e1c0130c1fccd3705d66ebc875f4aa4d19da405c37b0435c64ed Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Tue Feb 7, 2023 at 4:41 PM GMT, Katherine Cox-Buday wrote: > >> + (description > >> + "Package safehtml provides immutable string-like types which rep= resent values > >> +that are guaranteed to be safe, by construction or by escaping or san= itization, > >> +to use in various HTML contexts and with various DOM APIs.") > > > > (description > > "This package provides a Go library for storing HTML data as an immu= table string-like > > value.") > > I disagree with this suggestion: the extra context about construction or > escaping takes me from "why would I want to store HTML data in a > struct", to, "oh this is a way to preclude passing around invalid/unsafe > HTML around". That's true. There's no problem with incorporating it, but many upstream d= escriptions are a bit too focused on the internals for guix IMO. So I tried to constru= ct a description that got the point across without being too detailed; I probabl= y went too far. (Also, I know it's a Go convention, but I personally think we sho= uld remove the "package is ..." phrasing where possible.) How about this instead: (description "This package provides a Go library for storing HTML data as an immutabl= e string-like value that is guaranteed to be safe to use in various HTML- and DOM-relat= ed contexts.") -- ( --776382c2e1c0130c1fccd3705d66ebc875f4aa4d19da405c37b0435c64ed Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEE6Vh10NblKE5doNlW7ImHg/nqI20FAmPijiwACgkQ7ImHg/nq I230igwArlIweRk9pePamip+V3DNQgiSPL+9VIxurkHTeEOiq8NP34UZ9N6TMwmv 9qhSutMoeaJcZ9cMc71xiVuKS1mjaUG5YKVNuzMbojX3N9hcTW26D1v9NXI4MKGv JofrWYtZ9EmqQxwq5jPqEzOcYBpH+YCRtNomMOQHED3vqYdspyXOT5uGP/U0Sr1v tbGxcLzoNxUUueyoFtQGY/mfaT9N5CMWnDYyG9GeFs+Zy4weA7Ou2wSDR7h+G9L8 IN92KR0fLA3/1M5Seoa9Z9AMJMKXo/ewBYX6ml+zr4Po5a7nSUa0mvZV+DNKah4/ N2224+8s5mJwJM/rr8Td5wVGXsGwU6MldzQuDnezGtvoleuRDVw3OkUPj5+MtmZ4 ATTlkhtb3iemjA3znnLLxVsB9R+gEtjTqgKhUonUkSeY7R1k6whtzcn8upfC8AdO 23dPz9xRSnDcDYoFtT7Vu6LfLIk2dOS70d3AtCpVomsQGKpqEEt97yVQATdaDfU7 RtNasDES =bZJA -----END PGP SIGNATURE----- --776382c2e1c0130c1fccd3705d66ebc875f4aa4d19da405c37b0435c64ed--