[bug#59948] [PATCH 2/2] gnu: Add iio-sensor-proxy

["\( via Guix-patches" via <guix-patches@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1528 bytes --]

The (currently empty) commit message should have the removed line from the
previous patch.

On Sun Dec 11, 2022 at 4:16 PM GMT,  wrote:
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm

> @@ -810,6 +811,56 @@ (define-public elogind

> +(define-public iio-sensor-proxy
> + (package
> +    (name "iio-sensor-proxy")
    ^^^
Too much indentation ;) Two spaces are enough.

> +           #:phases
> +           #~(modify-phases %standard-phases
> +               (add-before 'configure 'fake-pkexec
> +                 (lambda _
> +                   (setenv "PKEXEC_UID" "-1")))

Could you add a comment explaining why this is necessary?

> +    (native-inputs
> +     (list dbus
> +           (list glib "bin")
> +           gobject-introspection
> +           python
> +           python-dbusmock
> +           python-psutil
> +           pkg-config
> +           umockdev))

Please sort these alphabetically by putting PKG-CONFIG before PYTHON.

> +    (inputs
> +     (list glib libgudev-next polkit))

INPUTS should typically come before NATIVE-INPUTS, imo.

> +    (description "With a GNOME 3.18 (or newer) based system, orientation changes
> + will automatically be applied when rotating the panel, ambient light will be
> + used to change the screen brightness, and GeoClue will be able to read the compass
> +data to show the direction in Maps.")

This isn't a full sentence.  Please write a description explaining exactly
what it does.

    -- (

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]