[bug#59569] [PATCH 0/2] nheko: Support video calls

[bug#59569] [PATCH 0/2] nheko: Support video calls

[Martin Schmidt]

Hi Guix,
2 patches for enabling video calls in nheko. Special thanks to "unmatched-paren" for the help and patience!

Martin Schmidt (2):
  gnu: Add gst-plugins-good-qt.
  gnu: nheko: Support video calls.

 gnu/packages/gstreamer.scm | 21 +++++++++++++++++++++
 gnu/packages/messaging.scm |  2 +-
 2 files changed, 22 insertions(+), 1 deletion(-)


base-commit: 8f3e10ae819aabbe8216bfee6cd3e7857bc27293
--
2.38.0

[bug#59569] [PATCH 1/2] gnu: Add gst-plugins-good-qt.

[Martin Schmidt]

* gnu/packages/gstreamer.scm (gst-plugins-good-qt): New variable.
---
 gnu/packages/gstreamer.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index a92588a9e2..323fdb6f28 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -734,6 +734,27 @@ (define libsoup
     (home-page "https://gstreamer.freedesktop.org/")
     (license license:lgpl2.0+)))

+(define-public gst-plugins-good-qt
+  (package (inherit gst-plugins-good)
+    (name "gst-plugins-good-qt")
+    (build-system meson-build-system)
+
+    (inputs
+     (modify-inputs (package-inputs gst-plugins-good)
+		    (prepend qtbase-5 qtdeclarative-5 qtx11extras qtwayland-5)))
+
+    (arguments
+     (substitute-keyword-arguments (package-arguments gst-plugins-good)
+				   ((#:configure-flags flags #~'())
+				    #~(list "-Dgst-plugins-good:qt5=enabled" ))
+
+
+))))
+
+
+
+
+
 (define-public gst-plugins-bad
   (package
     (name "gst-plugins-bad")
--
2.38.0

[bug#59569] [PATCH 2/2] gnu: nheko: Support video calls.

[Martin Schmidt]

* gnu/packages/messaging.scm (nheko)[inputs]: Replace
  GST-PLUGINS-GOOD with GST-PLUGINS-GOOD-QT to fix video
  calls.
---
 gnu/packages/messaging.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9927c7c323..d23118cce8 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2459,7 +2459,7 @@ (define-public nheko
            curl
            gst-plugins-base
            gst-plugins-bad              ; sdp & webrtc for voip
-           gst-plugins-good             ; rtpmanager for voip
+           gst-plugins-good-qt          ; rtpmanager for voip
            json-modern-cxx
            libevent
            libnice                      ; for voip
--
2.38.0

[bug#59569] [PATCH 1/2] gnu: Add gst-plugins-good-qt.

[( via Guix-patches via]

On Fri Nov 25, 2022 at 11:13 AM GMT, Martin Schmidt wrote:
> * gnu/packages/gstreamer.scm (gst-plugins-good-qt): New variable.

> --- a/gnu/packages/gstreamer.scm
> +++ b/gnu/packages/gstreamer.scm

> @@ -734,6 +734,27 @@ (define libsoup

> +(define-public gst-plugins-good-qt
> +  (package (inherit gst-plugins-good)
> +    (name "gst-plugins-good-qt")
> +    (build-system meson-build-system)
> +
> +    (inputs
> +     (modify-inputs (package-inputs gst-plugins-good)
> +		    (prepend qtbase-5 qtdeclarative-5 qtx11extras qtwayland-5)))
> +
> +    (arguments
> +     (substitute-keyword-arguments (package-arguments gst-plugins-good)
> +				   ((#:configure-flags flags #~'())
> +				    #~(list "-Dgst-plugins-good:qt5=enabled" ))

> +
> +
> +))))

Indentation is... a wee bit off :) Also, the build-system override is a no-op.

Try this instead:

  (define-public gst-plugins-good-qt
    (package
      (inherit gst-plugins-good)
      (arguments
       (substitute-keyword-arguments
           (package-arguments gst-plugins-good)
         ((#:configure-flags flags)
          #~(cons "-Dgst-plugins-good:qt5=enabled"
                  flags))))
      (inputs
       (modify-inputs (package-inputs gst-plugins-good)
         (prepend qtbase-5
                  qtdeclarative-5
                  qtwayland-5
                  qtx11extras)))))

    -- (

[bug#59569] [PATCH 2/2] gnu: nheko: Support video calls.

[( via Guix-patches via]

On Fri Nov 25, 2022 at 11:13 AM GMT, Martin Schmidt wrote:
> * gnu/packages/messaging.scm (nheko)[inputs]: Replace
>   GST-PLUGINS-GOOD with GST-PLUGINS-GOOD-QT to fix video
>   calls.

LGTM :)

    -- (

[bug#59569] [PATCH v2 1/2] gnu: Add gst-plugins-good-qt.

[Martin Schmidt]

* gnu/packages/gstreamer.scm (gst-plugins-good-qt): New variable.
---
 gnu/packages/gstreamer.scm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index a92588a9e2..37e74b706b 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -734,6 +734,17 @@ (define libsoup
     (home-page "https://gstreamer.freedesktop.org/")
     (license license:lgpl2.0+)))

+(define-public gst-plugins-good-qt
+  (package
+    (inherit gst-plugins-good)
+    (name "gst-plugins-good-qt")
+    (inputs
+     (modify-inputs (package-inputs gst-plugins-good)
+       (prepend qtbase-5
+                qtdeclarative-5
+                qtwayland-5
+                qtx11extras)))))
+
 (define-public gst-plugins-bad
   (package
     (name "gst-plugins-bad")

base-commit: 8f3e10ae819aabbe8216bfee6cd3e7857bc27293
--
2.38.1

[bug#59569] [PATCH v2 2/2] gnu: nheko: Support video calls.

[Martin Schmidt]

* gnu/packages/messaging.scm (nheko)[inputs]: Replace
  GST-PLUGINS-GOOD with GST-PLUGINS-GOOD-QT to fix video
  calls.
---
 gnu/packages/messaging.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9927c7c323..d23118cce8 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2459,7 +2459,7 @@ (define-public nheko
            curl
            gst-plugins-base
            gst-plugins-bad              ; sdp & webrtc for voip
-           gst-plugins-good             ; rtpmanager for voip
+           gst-plugins-good-qt          ; rtpmanager for voip
            json-modern-cxx
            libevent
            libnice                      ; for voip
--
2.38.1

bug#59569: [PATCH 0/2] nheko: Support video calls

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]


Martin Schmidt <martin.schmidt13@gmx.de> writes:

> Hi Guix,
> 2 patches for enabling video calls in nheko. Special thanks to "unmatched-paren" for the help and patience!
>
> Martin Schmidt (2):
>   gnu: Add gst-plugins-good-qt.
>   gnu: nheko: Support video calls.
>
>  gnu/packages/gstreamer.scm | 21 +++++++++++++++++++++
>  gnu/packages/messaging.scm |  2 +-
>  2 files changed, 22 insertions(+), 1 deletion(-)

Thanks both, I've pushed these to master as
34cf5e06a9acd021d1233587e140759bba452b35.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]