From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp11.migadu.com ([2001:41d0:8:6d80::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms5.migadu.com with LMTPS
	id SCqFEhjmgGNBTQAAbAwnHQ
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Fri, 25 Nov 2022 16:58:16 +0100
Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp11.migadu.com with LMTPS
	id AGx8EhjmgGP1fwAA9RJhRA
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Fri, 25 Nov 2022 16:58:16 +0100
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id C9C66201A3
	for <larch@yhetil.org>; Fri, 25 Nov 2022 16:58:15 +0100 (CET)
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces@gnu.org>)
	id 1oyb5Y-0006Zx-PD; Fri, 25 Nov 2022 10:58:04 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1oyb5X-0006Zm-5t
 for guix-patches@gnu.org; Fri, 25 Nov 2022 10:58:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1oyb5W-0004g9-9a
 for guix-patches@gnu.org; Fri, 25 Nov 2022 10:58:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1oyb5V-0005tx-Ve
 for guix-patches@gnu.org; Fri, 25 Nov 2022 10:58:01 -0500
X-Loop: help-debbugs@gnu.org
Subject: [bug#59569] [PATCH 1/2] gnu: Add gst-plugins-good-qt.
Resent-From: "(" <paren@disroot.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Fri, 25 Nov 2022 15:58:01 +0000
Resent-Message-ID: <handler.59569.B59569.166939183222629@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 59569
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: "Martin Schmidt" <martin.schmidt13@gmx.de>, <59569@debbugs.gnu.org>
Received: via spool by 59569-submit@debbugs.gnu.org id=B59569.166939183222629
 (code B ref 59569); Fri, 25 Nov 2022 15:58:01 +0000
Received: (at 59569) by debbugs.gnu.org; 25 Nov 2022 15:57:12 +0000
Received: from localhost ([127.0.0.1]:36969 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1oyb4i-0005su-7M
 for submit@debbugs.gnu.org; Fri, 25 Nov 2022 10:57:12 -0500
Received: from knopi.disroot.org ([178.21.23.139]:54214)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <paren@disroot.org>) id 1oyb4f-0005sk-Gp
 for 59569@debbugs.gnu.org; Fri, 25 Nov 2022 10:57:10 -0500
Received: from localhost (localhost [127.0.0.1])
 by disroot.org (Postfix) with ESMTP id D089740423;
 Fri, 25 Nov 2022 16:57:07 +0100 (CET)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
 by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id aJJTLP953OyQ; Fri, 25 Nov 2022 16:57:06 +0100 (CET)
Mime-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
 t=1669391826; bh=fFHq0qUEIZUsiPfbOsmicGLXkUhG8QT+PTKocrW3Abw=;
 h=Date:Subject:From:To:References:In-Reply-To:From;
 b=Ty57/z8mNXVqw05xwyUcTcWrkEi/FlZ2svkMimk6e6x2NxOmvzktSKyUDJuaETXMk
 kgDkiBHLFX5nIrQWwwRDpNAcy8xA9gU+1bjlc7o3Ooc/5YmC9uNDCLxngtGvaUK9Jc
 1d8U0OJEDLyUQabd+7gluryuTlHipLT7r25cEXLNTnIayyZF53fq/1y8vy/SmRFMVw
 FVYwti2z55Kc3u3uIOwO0U7rWlCLSFWojXC10LJ6BTFX5jFeOBribiJAnHQ8rPXCJ3
 NjijeOtVnsfbpDprC1JKguGOFPrNJ7mSFZOmTw7eJsg0hYcGmEUHv978yoZ7wN3N4d
 xTpmWmwBZ/Apw==
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 25 Nov 2022 15:57:04 +0000
Message-Id: <COLI0GWQ9A78.3VV5O457DL34W@guix-framework>
References: <20221125071126.2748-1-martin.schmidt13@gmx.de>
 <20221125111313.3128-1-martin.schmidt13@gmx.de>
In-Reply-To: <20221125111313.3128-1-martin.schmidt13@gmx.de>
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Reply-to:  "\(" <paren@disroot.org>
X-ACL-Warn: ,  "\( via Guix-patches" <guix-patches@gnu.org>
From:  "\( via Guix-patches" via <guix-patches@gnu.org>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: guix-patches-bounces+larch=yhetil.org@gnu.org
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: US
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1669391896;
	h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=f5k/S7t3UvAk9GxV9BQGU3EEKpFPa983U4DnQLZ9D08=;
	b=Spfe4cx7Pdu322ErVGQKsOMLRjvNexZfjTijuPJCGjRTTrmBzLUzmgoMDgXyL8flNz1LJz
	z+M/0aqsp6Y2Yz1vVHr53VqjUt97Yy863dQX2xxFjocN9ACIHAiIQ9lfGbWFXO1DZ8flyc
	TPBiOrzxQuT3x/+8BeHRguoYb9t5aCAHDHLzaLNOvTrSZtX2vyzRtG0tE0L0G39V+EuZky
	me/bgnXBSZFToJRz2/DVfu38OEgpXfhsCzmxnWPc2Q6JF2PaEcRtUJor8TrmX96fI3k3Z/
	Ke4qqeebON3bVc3PM8+iz+gwVJ3qCrf5GJLFSI2mboOEpIpWhMMUlWMO1j/oWQ==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669391896; a=rsa-sha256; cv=none;
	b=FZ/3HhJSuIl7OKXahWVIDl76g1DcE/YErh0TM5ztziIQlemH5ng9mVDsobtSEM1yRxVjKr
	buq+/JtowU6nN7yfSczpsT7ZV4ZwYbAsFoLFNyT+Oo8Op4lAev4fbt6tznXE3PaMEPExv2
	y9gpAVwNlMGW++nvwMIH7ID2GjIlWpLj5I6ixj5AwCKN7s/m+2Rg+mrqpcFXPTEU8ZheM/
	KOyMv2OmjPDNByihaYarU/q7NMVCgwdv+SsiGKp1hzzfxzREzh4u3cxIkWmZCj/8s8k2ta
	N47poVotCBJfU6FX6DsTOog9z+qibn99OKBEgo1GEEu4g+EClx/X1Z5mLnVKLg==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b="Ty57/z8m";
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Spam-Score: -2.47
Authentication-Results: aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b="Ty57/z8m";
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Queue-Id: C9C66201A3
X-Spam-Score: -2.47
X-Migadu-Scanner: scn1.migadu.com
X-TUID: o1UHhhpmuc0f

On Fri Nov 25, 2022 at 11:13 AM GMT, Martin Schmidt wrote:
> * gnu/packages/gstreamer.scm (gst-plugins-good-qt): New variable.

> --- a/gnu/packages/gstreamer.scm
> +++ b/gnu/packages/gstreamer.scm

> @@ -734,6 +734,27 @@ (define libsoup

> +(define-public gst-plugins-good-qt
> +  (package (inherit gst-plugins-good)
> +    (name "gst-plugins-good-qt")
> +    (build-system meson-build-system)
> +
> +    (inputs
> +     (modify-inputs (package-inputs gst-plugins-good)
> +		    (prepend qtbase-5 qtdeclarative-5 qtx11extras qtwayland-5)))
> +
> +    (arguments
> +     (substitute-keyword-arguments (package-arguments gst-plugins-good)
> +				   ((#:configure-flags flags #~'())
> +				    #~(list "-Dgst-plugins-good:qt5=3Denabled" ))

> +
> +
> +))))

Indentation is... a wee bit off :) Also, the build-system override is a no-=
op.

Try this instead:

  (define-public gst-plugins-good-qt
    (package
      (inherit gst-plugins-good)
      (arguments
       (substitute-keyword-arguments
           (package-arguments gst-plugins-good)
         ((#:configure-flags flags)
          #~(cons "-Dgst-plugins-good:qt5=3Denabled"
                  flags))))
      (inputs
       (modify-inputs (package-inputs gst-plugins-good)
         (prepend qtbase-5
                  qtdeclarative-5
                  qtwayland-5
                  qtx11extras)))))

    -- (