From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WBl7MYgxemPVhwAAbAwnHQ (envelope-from ) for ; Sun, 20 Nov 2022 14:54:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WElzMYgxemOjPgAA9RJhRA (envelope-from ) for ; Sun, 20 Nov 2022 14:54:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7A6F03E128 for ; Sun, 20 Nov 2022 14:54:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owklo-0008GL-U7; Sun, 20 Nov 2022 08:54:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owklm-0008Fy-Ss for guix-patches@gnu.org; Sun, 20 Nov 2022 08:54:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owklm-0002UT-L1 for guix-patches@gnu.org; Sun, 20 Nov 2022 08:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owklm-0005Aw-Fm for guix-patches@gnu.org; Sun, 20 Nov 2022 08:54:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59399] [PATCH 1/4] gnu: Add go-github-com-nathan-osman-go-sunrise. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Nov 2022 13:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59399 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Felix Lechner" , <59399@debbugs.gnu.org> Received: via spool by 59399-submit@debbugs.gnu.org id=B59399.166895241419860 (code B ref 59399); Sun, 20 Nov 2022 13:54:02 +0000 Received: (at 59399) by debbugs.gnu.org; 20 Nov 2022 13:53:34 +0000 Received: from localhost ([127.0.0.1]:42703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owklK-0005AG-5u for submit@debbugs.gnu.org; Sun, 20 Nov 2022 08:53:34 -0500 Received: from knopi.disroot.org ([178.21.23.139]:38024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owklH-0005A7-Kq for 59399@debbugs.gnu.org; Sun, 20 Nov 2022 08:53:32 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 1FD6E4115F; Sun, 20 Nov 2022 14:53:30 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RTqVlaTGuENx; Sun, 20 Nov 2022 14:53:29 +0100 (CET) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1668952409; bh=g2dxT1iswnlYRDPad2/xbB//Lt90gmBaJ6C9xDpyDSM=; h=Date:Subject:From:To:References:In-Reply-To:From; b=kU7KADmbN2hUwoWIDaqO/RyGTjO93DB/Ve+n8QVHROOlcgOtfpw8dEbRUnsAUMNFK ssGjFjb5fM/FjkjXXSS8e8HDE7IIKQEnP+uRXzJGivs1Uy8dVeHKWXGMBgtJ1Tf/lA 4EvYBmkniwhxmr4JgHMa7P0oYh9/YBweLin63DMB1i+Q8FUbpPSvj+ufHEfbiZ3NvV qTW0bbHre136kvu7Fb6plnRP0BD0oXKTHGC4Jz8yvYI901UGPOPdPlM9sClQU5japU +2CJIIM5EK6yxCF/Nac0v5zGoWcw7PsOTpKxXa3p8x+WtWG+q6SL/Jho6JKXegkwH9 2kje187eTzl7A== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 20 Nov 2022 13:53:28 +0000 Message-Id: References: <20221120134802.19051-1-felix.lechner@lease-up.com> In-Reply-To: <20221120134802.19051-1-felix.lechner@lease-up.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668952456; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=uJZfpgx0zH85ThhPXgsgOGUFWFGVZjZHTv3xADg+2w4=; b=Eu1asQFJX6KTHIMN/+48nXLMmCVq77N0dDm3JHyjk0p3ZC9Q3+WPuWZevqMhIXIeBTgoWE bF2VxDaplIdwxyqANrsb/QZopyl+Mh5PjG2OtbvEEN6fR5Kxz26dkDtpHMItOtHAQR7TNp 3MFj+QbxgbXJ+/QUDN5xznK9wV4gOHRZVsBqFyR9OaRFnvNlaFMHydYrd9AsV5U3dcmpVK M14PqaMTj3M1QC7gJdv52DDQHbJOzaFI4F1iN9kMLJIx82/VnYbS9dgFcJB7qDb7TsmzmK OQ+WQItZ7LvybZUfPHDSphd6wJXX5GMttfvzHUz2NAf54LrqDJHQ1paNOTuy6A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668952456; a=rsa-sha256; cv=none; b=Ihn2gwigIyxGHLg757UF41+nKs4pbL2y4D5DdkbOlXWKN/6pLjn1UQHy+vVsuhZyuladSj SJIRRxlotRYzmBlIx+K1xzU7fhQ3mlDEOFCnINb1Kcfl3A927swSnOrY49AaS8N+cxXTT8 vr7d3tjqxHAW4UWVhw6SzJruOcNsVczvmT/m4BCrXqHrQUzaUJ4jp/U34zycWY6f9lfPPq /7FVpha9XKmiq+7glFmkzTwQ0h1YctZsDAnzPNDOOyH4b5OHrrQEawOPTHdqXaNIt0cCgj bVN/iq43QvbPDEDy6vTpsY/TlFFh/wehZSxzIklc30ibvTs55joj5PPqQaZuBw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=kU7KADmb; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=kU7KADmb; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7A6F03E128 X-Spam-Score: -1.01 X-Migadu-Scanner: scn1.migadu.com X-TUID: RVoTSD7TWYnY Heya, Thanks for splitting them! A few remarks: On Sun Nov 20, 2022 at 1:47 PM GMT, Felix Lechner wrote: > * gnu/packages/golang.scm > (go-github-com-nathan-osman-go-sunrise): New variable. Indentation for this should look something like: * gnu/packages/golang.scm (go-github-com-nathan-osman-go-sunrise): New variable. > --- a/gnu/packages/golang.scm > +++ b/gnu/packages/golang.scm > @@ -2485,6 +2485,33 @@ (define-public go-gopkg-in-go-playground-validator= -v9 > + (arguments > + '(#:import-path "github.com/nathan-osman/go-sunrise")) Please use (list #:import-path ...) instead. > + (synopsis "Calculates the sunrise and sunset times for a given loc= ation") Maybe change this to: (synopsis "Calculate sunrise and sunset times in Go") > + (description > + "To calculate the sunrise and sunset times, you will need the dat= e of your > +observation and the geographical coordinates in latitude and longitude f= or the > +location.") How about this: (description "This package provides a Go library for calculating sunrise and sunset times from geographical coordinates and a date.") -- (