From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4OswEnCeeGN9lgAAbAwnHQ (envelope-from ) for ; Sat, 19 Nov 2022 10:14:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UIAxEnCeeGOYkAAA9RJhRA (envelope-from ) for ; Sat, 19 Nov 2022 10:14:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2014EDB3C for ; Sat, 19 Nov 2022 10:14:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owJvP-0004IS-4a; Sat, 19 Nov 2022 04:14:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owJvG-0004I1-4W for guix-patches@gnu.org; Sat, 19 Nov 2022 04:14:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owJvF-0007dk-Rl for guix-patches@gnu.org; Sat, 19 Nov 2022 04:14:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owJvF-00032W-NW for guix-patches@gnu.org; Sat, 19 Nov 2022 04:14:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59372] [PATCH] gnu: peek: Add missing input. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 19 Nov 2022 09:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59372 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "jgart" , <59372@debbugs.gnu.org> Received: via spool by 59372-submit@debbugs.gnu.org id=B59372.166884919311602 (code B ref 59372); Sat, 19 Nov 2022 09:14:01 +0000 Received: (at 59372) by debbugs.gnu.org; 19 Nov 2022 09:13:13 +0000 Received: from localhost ([127.0.0.1]:38989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owJuR-000312-1O for submit@debbugs.gnu.org; Sat, 19 Nov 2022 04:13:13 -0500 Received: from knopi.disroot.org ([178.21.23.139]:53654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owJuL-00030q-MM for 59372@debbugs.gnu.org; Sat, 19 Nov 2022 04:13:09 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id CF16340DC4; Sat, 19 Nov 2022 10:13:03 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yoTDxbrNi9R5; Sat, 19 Nov 2022 10:13:02 +0100 (CET) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1668849182; bh=Keea3wSUIjpiWgJQL+dw+2L8KQteYfCE7DokUxVwsTQ=; h=Date:Subject:From:To:References:In-Reply-To:From; b=dHsBpk0dvMD6ttMunvC525le11mXbnA0i0s1DIrxOmmBTWUJQoKwdomfgocAB6nBp t1DvhzUzuxADszMY5J0Itudn6nJa1WDsBcOuPAueYErQqMcPe1ZgS1fSt+pUJiVAsF uBXPEAbaHOwcVzz5Q3+1J2JF2V33m7hsA4p0QwCIoApLYdY+uoLsDRs0YkP2lcCAmU fICJYZznaeAFUQcAzG/iNmJW7fDPx2HbCUzgN2jcGt+rXJdBVEGwjUcLvjUPAkUXB5 sBeCQoX+8qM6rjzCo4sWXXxUiMmOlU/mgMDUrtq1BfrWw9542J8Qq7e2/aJYBbkxt6 xOcxAX4kvq9sQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 19 Nov 2022 09:13:02 +0000 Message-Id: References: <20221119012744.30470-1-jgart@dismail.de> In-Reply-To: <20221119012744.30470-1-jgart@dismail.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668849264; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qankoEB6mnz+55X9UjnUA//F9q9YSw33g05yiyQN+Js=; b=jtOHgdArRDTeeSpI+aBAQalrAnapKIP4YOj1CqOMll9PbyZ41rinihinflvgCJxlFQgirI kfhpugUbIr9ic++Maq1ICj9wU7D67YokNyofYOzPPdmb8g6299TpRzLbTPXTbBAXGPabH7 MQAvz4q/PlkqQiqHORnqqpzNWvqstjP+ltN7zUY7EIr3UHKqMLdy0uPbXSUxx94WIj8Nfe gNg+AInOrtd499eDcjcxA9EGoE9k+jBOrAo/YIK5I4/EhMvBoyXHBpF+pbN2qBaAdDg1YC V6icCby0hwqergXqM4Ja0XsxAdTF4lbiyPBrN7yXvMmnP05DiFyclGW/A/OKiA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668849264; a=rsa-sha256; cv=none; b=iA11BU/3GfkM3pBdGJv7knBo6m1+8Obo/ZncabKiV1oBeztqm45tZe02ynx+M/PKqZ9Z10 kqJ3iDQrcbRfstZkZyVloJUrLB6PfDfPmC+Dbb6ZwAQI/g6Gdsrf5lOrI/CGxU3oIGbxc5 lnsOd54Fi787b4alEmMMy7R/IVA3zlHrmxDem9x/7LeIWSOKHBM1WJkfUPKnIfNOvSfe6T SMIezGgeyvM8pcB89t5tsP9Q1TlKaZfc2WwJ65mL5DafFQcjiKSjhkY2qvVjibWeJTYiEb VEkMXLBndKhkGLj/wje6Pgbjh1sgbmZ2nGk4PF+wKtT0UAKxEU2Vj7vxA17kGw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=dHsBpk0d; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=dHsBpk0d; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2014EDB3C X-Spam-Score: -1.01 X-Migadu-Scanner: scn1.migadu.com X-TUID: BXA7BlKG8HCs Heya, On Sat Nov 19, 2022 at 1:27 AM GMT, jgart via Guix-patches via wrote: > * gnu/packages/video.scm (peek): Add missing input. > [inputs]: Add ffmpeg so that Peek will not fail to run on a foreign > distro. > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index c394c65442..4f38d4432c 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -5369,6 +5369,8 @@ (define-public peek > (arguments '(#:glib-or-gtk? #t)) > (inputs > `(("gtk+" ,gtk+) > + ;; Peek fails to run on a foreign distro without ffmpeg. > + ("ffmpeg" ,ffmpeg) > ("python" ,python-wrapper))) > (native-inputs > `(("desktop-file-utils" ,desktop-file-utils) ; for update-desktop-d= atabase I don't think this will be enough; does the program call the ``ffmpeg'' executable? If so, you'll need to patch the call to ``ffmpeg'' to point to /gnu/store/.../bin/ffmpeg directly. Could you also update the inputs/arguments style to gexp form? -- (