all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: "jgart" <jgart@dismail.de>, <59372@debbugs.gnu.org>
Subject: [bug#59372] [PATCH] gnu: peek: Add missing input.
Date: Sat, 19 Nov 2022 09:13:02 +0000	[thread overview]
Message-ID: <COG5NUH2AL8O.ZEQDQS240I2H@guix-framework> (raw)
In-Reply-To: <20221119012744.30470-1-jgart@dismail.de>

Heya,

On Sat Nov 19, 2022 at 1:27 AM GMT, jgart via Guix-patches via wrote:
> * gnu/packages/video.scm (peek): Add missing input.
> [inputs]: Add ffmpeg so that Peek will not fail to run on a foreign
> distro.

> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index c394c65442..4f38d4432c 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -5369,6 +5369,8 @@ (define-public peek
>      (arguments '(#:glib-or-gtk? #t))
>      (inputs
>       `(("gtk+" ,gtk+)
> +       ;; Peek fails to run on a foreign distro without ffmpeg.
> +       ("ffmpeg" ,ffmpeg)
>         ("python" ,python-wrapper)))
>      (native-inputs
>       `(("desktop-file-utils" ,desktop-file-utils) ; for update-desktop-database

I don't think this will be enough; does the program call the ``ffmpeg''
executable? If so, you'll need to patch the call to ``ffmpeg'' to point to
/gnu/store/.../bin/ffmpeg directly.

Could you also update the inputs/arguments style to gexp form?

    -- (




      parent reply	other threads:[~2022-11-19  9:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19  1:27 [bug#59372] [PATCH] gnu: peek: Add missing input jgart via Guix-patches via
2022-11-19  2:50 ` Tobias Geerinckx-Rice via Guix-patches via
2022-11-19  4:07   ` jgart via Guix-patches via
2022-11-19  9:38     ` Tobias Geerinckx-Rice via Guix-patches via
2022-11-21 14:27       ` jgart via Guix-patches via
2022-11-21 15:14         ` Tobias Geerinckx-Rice via Guix-patches via
2022-11-21 20:18         ` Tobias Geerinckx-Rice via Guix-patches via
2022-11-21 20:58           ` jgart via Guix-patches via
2023-01-29  6:02             ` bug#59372: " 宋文武 via Guix-patches via
2022-11-21 17:13   ` [bug#59372] " zimoun
2022-11-21 19:38     ` jgart via Guix-patches via
2022-11-22 14:39       ` zimoun
2022-11-22 18:29         ` jgart via Guix-patches via
2022-11-19  9:13 ` ( via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=COG5NUH2AL8O.ZEQDQS240I2H@guix-framework \
    --to=guix-patches@gnu.org \
    --cc=59372@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.