From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uJ05KifGSWMWWQEAbAwnHQ (envelope-from ) for ; Fri, 14 Oct 2022 22:27:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MPpQKifGSWOk7AAAauVa8A (envelope-from ) for ; Fri, 14 Oct 2022 22:27:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3F9F936D5C for ; Fri, 14 Oct 2022 22:27:19 +0200 (CEST) Received: from localhost ([::1]:57532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojRH3-0002T6-Vu for larch@yhetil.org; Fri, 14 Oct 2022 16:27:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojRGo-0002So-S7 for guix-patches@gnu.org; Fri, 14 Oct 2022 16:27:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojRGo-00079U-KG for guix-patches@gnu.org; Fri, 14 Oct 2022 16:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ojRGo-00072u-6h for guix-patches@gnu.org; Fri, 14 Oct 2022 16:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58528] [PATCH] gnu: Services: Add espeakup service. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Oct 2022 20:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58528 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: , <58528@debbugs.gnu.org> Received: via spool by 58528-submit@debbugs.gnu.org id=B58528.166577919027042 (code B ref 58528); Fri, 14 Oct 2022 20:27:02 +0000 Received: (at 58528) by debbugs.gnu.org; 14 Oct 2022 20:26:30 +0000 Received: from localhost ([127.0.0.1]:38734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojRGH-000726-Vp for submit@debbugs.gnu.org; Fri, 14 Oct 2022 16:26:30 -0400 Received: from knopi.disroot.org ([178.21.23.139]:41632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojRGF-00071v-Uw for 58528@debbugs.gnu.org; Fri, 14 Oct 2022 16:26:28 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 3E5B34DBF0; Fri, 14 Oct 2022 22:26:26 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TNLmgqfbOsCt; Fri, 14 Oct 2022 22:26:25 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1665779184; bh=ZjSLgk+SieLoercMEtpWaWfr/PRhv39TUonYj1f8tis=; h=Date:To:Subject:From:References:In-Reply-To; b=kGMgMdZkyZdJP3GZDxV5MtXMD67aj2rkhXGHFa+qaNXv+/nEftnqScFEYJcgnXh1J 4BfCsO7Jwd0NxOIJQajkJ2hq3+vYjrb4HJwhaZr45z92MPQj1FKJBIWRNsROp1wHEN YmUMl/6Ur3mSrTmI887s99iCBUgGFeMnhFirEww0pVjj5YEMpE7RbbRFfJhOYEGaiL r+YNuxZ5Y844d1Amj7E+ZTIF7wsOikBYDUHh4f1moXGrBciP5imVV0jJ/9aoFNODk8 L1PWK0dHYLY83kfggyEVKPlDURYNk6NX7zHcVjcCDWr+83nm5fbFBwLZm/eDUFOQF1 ZMljmv4zFVRbw== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 14 Oct 2022 21:26:24 +0100 Message-Id: References: In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665779239; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=iUDwD05wftugrA4jaP3UKw8+1LnIi9j3KEOGVqsdXyA=; b=n3gIQEMt5svT56vP8ZKTymOWwX1AM82crERh8GHGHy7ZL/Qp9Onhpy9+TvGIlWR0dU6xvb C8gUglgM5KLaA9+yc7k9HrYNKPHlMuhDcY2KRMJ/KiEwYxtLq634ZMmCfYGWlND72hfxbV UXBI2llwfH/CFnhlFUTrTzN1A1LHzMkGFTETINmJadFA8VmBRa9Eq9kZgjEgjGg3Mw19Tm Akk9+OjHHTwrZTx3qBshBT2ABxKMwkVYJwkqUS18/7aFyi04eqHzUgo5YZa2IsfbwtyNoP k678ZsNNp4DQ8jujeijbhQ68WZHlaGi4WT84Vo9IL3hKd6PPb17GOPBOmPgwWQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665779239; a=rsa-sha256; cv=none; b=iMZP6XsFgPtscOl5VA0GBxK7vBOpU7AIC5hyoRW1WLZ9MUiEJqQyM8tSwWD1MFvT9C3v0P K5Xwkr6qPnOo/ZrunJhh/CSsraW988Fv4s15OzXOYn6C6wU0BOT0KNRLxOTmBzOnRNUBqP /DHIiDyVY3iyPiA0velHVSIHpdxHaIJMV6nIH0z3EoreHsUQpAyrpSGzFYF2vgnEo8+AEZ ZeEULr7BGvMqoIbc03ZTrmJ1DncpulQA56ncEFjv5FRMqnMI/j/6NZbEaNPKlG9SoWjbRW QxdCW7A24GPNu9XZaRbGLaPx3e5GAjirwNc1SuixqBKVVZE/A0uO3qy/iGec+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=kGMgMdZk; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.79 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=kGMgMdZk; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3F9F936D5C X-Spam-Score: -1.79 X-Migadu-Scanner: scn0.migadu.com X-TUID: wuNVAsAuUOBk Heya, On Fri Oct 14, 2022 at 9:09 PM BST, wrote: > diff --git a/doc/guix.texi b/doc/guix.texi > index dbf4ca9be9..73dc647ca5 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -17572,6 +17572,7 @@ Services > > @menu > * Base Services:: Essential system services. > +* Accessibility Services:: For those with various impairments. > * Scheduled Job Execution:: The mcron service. > * Log Rotation:: The rottlog service. > * Networking Setup:: Setting up network interfaces. > @@ -18793,6 +18794,24 @@ Base Services > (local-file "sway-greetd.conf")))))))) > @end lisp > @end deftp > +@node Accessibility Services > +@subsection Accessibility Services > +%espeakup-configuration > +@c %start of fragment > + > +@deftp {Data Type} espeakup-configuration > +Available @code{espeakup-configuration} fields are: > + > +@table @asis > +@item @code{default-voice} (default: @code{"en-US"}) (type: string) > +Set the voice that espeak-ng should use by default. > + > +@end table > + > +@end deftp > + > + > +@c %end of fragment Remember to add your copyright notice to the manual's copyright section. > + (define-module (gnu services accessibility) Since this is a new file, you'll need to update ``gnu/local.mk'' accordingl= y. > + Remove this empty line after the ``;;; Copyright ...'' line. > + #:export (espeakup-configuration espeakup-service-type)) You should probably put each variable here on a new line. > + > +;; Espeakup service Instead of this, do this: ^L ;;; ;;; Espeakup. ;;; The ^L is a control character, not a literal ``^L''. Look at one of the oth= er files and copy their ^L in. Also, add another newline after this "section comment". > +(define-configuration/no-serialization espeakup-configuration > + (default-voice (string "en-US") > + "Set the voice that espeak-ng > should use by default.")) Funky indentation here, and there needs to be a field for customizing the ``espeakup'' package to use. Should be: (define-configuration/no-serialization espeakup-configuration (espeakup (file-like espeakup) "Set the package providing the @code{/bin/espeakup} command.") (default-voice (string "en-US") "Set the voice that espeak-ng should use by default.")) > +(define (espeakup-shepherd-service config) > + (list (shepherd-service (provision '(espeakup)) > + (documentation "The espeak-ng bridge to speaku= p.") > + (requirement '(user-processes)) > + (start #~(make-forkexec-constructor (list > (string-append #$espeakup > + > "/bin/espeakup" > + "-v= " > + > #$(espeakup-configuration-default-voice > + > config))))) > + (stop #~(make-kill-destructor))))) Again, indentation is off here, and there's a small issue with ``string-app= end'' being used where ``file-append'' should be. Try this instead: (define (espeakup-shepherd-service config) (list (shepherd-service (provision '(espeakup)) (requirement '(user-processes)) (documentation "Run espeakup, the espeak-ng bridge to speakup.") (start #~(make-forkexec-constructor (list #$(file-append (espeakup-configuration-espeakup config= ) "/bin/espeakup") "-v" #$(espeakup-configuration-default-voice config)))= ) (stop #~(make-kill-destructor))))) > +(define espeakup-service-type > + (service-type (name 'espeakup) > + (description > + "A lightweight connector between espeak and speakup.") > + (extensions (list (service-extension > + shepherd-root-service-type > + espeakup-shepherd-service) > + (service-extension > + kernel-module-loader-service-type > + (const (list "speakup_soft"))))) > + (default-value (espeakup-configuration)))) Here too; try this: (define espeakup-service-type (service-type (name 'espeakup) (extensions (list (service-extension shepherd-root-service-type espeakup-shepherd-services) (service-extension kernel-module-loader-service-type (const (list "speakup_soft"))))) (default-value (espeakup-configuration)) (description "Configure and run espeakup, a lightweight bridge between espeak-ng and speakup."))) -- (