all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: "Matthew James Kraai" <kraai@ftbfs.org>, <58408@debbugs.gnu.org>
Subject: [bug#58408] [PATCH] gnu: Add doctl.
Date: Wed, 12 Oct 2022 16:01:32 +0100	[thread overview]
Message-ID: <CNK19Z8FY4YC.OR66N9FBGHZG@guix-framework> (raw)
In-Reply-To: <Y0a8NgVM8kQhfIqV@carlo>

Hello,

On Wed Oct 12, 2022 at 2:08 PM BST, Matthew James Kraai wrote:
> Here's an updated patch that installs autocompletion scripts for Bash, fish, and Zsh.

Nice catch :)

> +                 (lambda _
> +                   (let ((install-completion
> +                          (lambda (shell file)
> +                            (let ((file (string-append #$output file)))
> +                              (mkdir-p (dirname file))
> +                              (with-output-to-file file
> +                                (lambda _
> +                                  (invoke (string-append #$output "/bin/doctl")
> +                                          "completion" shell)))))))
> +                     (install-completion "bash" "/etc/bash_completion.d/doctl")
> +                     (install-completion "fish"
> +                                         "/etc/fish/completions/doctl.fish")
> +                     (install-completion "zsh"
> +                                         "/etc/zsh/site-functions/_doctl")))))))

I think it might be better to use ``(define (...) ...)'' instead of
``(let ((... (lambda ...))) ...)'' here.

  -- (




  reply	other threads:[~2022-10-12 15:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  9:54 [bug#58408] [PATCH] gnu: Add doctl Matthew James Kraai
2022-10-10 11:01 ` ( via Guix-patches via
2022-10-10 13:20   ` Matthew James Kraai
2022-10-10 15:21     ` ( via Guix-patches via
2022-10-11 13:36       ` Matthew James Kraai
2022-10-11 13:41         ` ( via Guix-patches via
2022-10-12 13:08 ` Matthew James Kraai
2022-10-12 15:01   ` ( via Guix-patches via [this message]
2022-10-13  1:02     ` Matthew James Kraai
2022-10-13  6:11       ` ( via Guix-patches via
2022-10-21  3:38       ` Matthew James Kraai
2022-10-23 13:07         ` bug#58408: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CNK19Z8FY4YC.OR66N9FBGHZG@guix-framework \
    --to=guix-patches@gnu.org \
    --cc=58408@debbugs.gnu.org \
    --cc=kraai@ftbfs.org \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.