From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6AoXN8s8RWMBMwAAbAwnHQ (envelope-from ) for ; Tue, 11 Oct 2022 11:52:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kDwfN8s8RWNOOgEAauVa8A (envelope-from ) for ; Tue, 11 Oct 2022 11:52:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D1EC3A13D for ; Tue, 11 Oct 2022 11:52:11 +0200 (CEST) Received: from localhost ([::1]:36562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiBvm-0007pi-FC for larch@yhetil.org; Tue, 11 Oct 2022 05:52:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiBui-0007oR-Cr for guix-patches@gnu.org; Tue, 11 Oct 2022 05:51:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiBug-00046X-Fd for guix-patches@gnu.org; Tue, 11 Oct 2022 05:51:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oiBug-00037D-0h for guix-patches@gnu.org; Tue, 11 Oct 2022 05:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58432] [PATCH] gnu: Add hiredis Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 11 Oct 2022 09:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58432 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Thomas Albers" , <58432@debbugs.gnu.org> Received: via spool by 58432-submit@debbugs.gnu.org id=B58432.166548185111959 (code B ref 58432); Tue, 11 Oct 2022 09:51:01 +0000 Received: (at 58432) by debbugs.gnu.org; 11 Oct 2022 09:50:51 +0000 Received: from localhost ([127.0.0.1]:50925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiBuV-00036o-1r for submit@debbugs.gnu.org; Tue, 11 Oct 2022 05:50:51 -0400 Received: from knopi.disroot.org ([178.21.23.139]:46242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiBuP-00036b-W2 for 58432@debbugs.gnu.org; Tue, 11 Oct 2022 05:50:50 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 6A6364A4A8; Tue, 11 Oct 2022 11:50:44 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CKbel27lLAMW; Tue, 11 Oct 2022 11:50:43 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1665481840; bh=NTs/UKYFYUJtKBSzAjQu3lUM/PfYhfKW/DNagrFJdXI=; h=Date:Subject:From:To:References:In-Reply-To; b=llIc0IZIrvqP9Uwv2vOFii0iN+OOg/2cUb7mvx36eMQbCS+X/U2ZdC07XRFVNOoMc 9o3iemhaNevJ+JfSDcd2Dios0mINCUFL7meh9h7vsnU8V2eastdY/YV3B6/Tq1ju09 FoRqBIEeUFM4vaM5Kpt73IaiRzFMjTuIw+r/M7QWck/P5FHLo62EHlDpJgy1TBHVDw F0k9R5um9fXJCv1QYh8TQxvb/ACSul8tnHfCVJQoxUu5SEpho3d1wul4dmvPNf6iRh y8tYkVyYmonU7aECqM6gT6Fvq+VejlAMjVEDmOvNataw8vIPG4JbDCWls+3rEI7QcU nXwi91fuP0Tww== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 11 Oct 2022 10:50:39 +0100 Message-Id: References: <20221011091949.9962-1-thomas@thomaslabs.org> In-Reply-To: <20221011091949.9962-1-thomas@thomaslabs.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665481931; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kJreMAXxdcQNzvCcZZOlfpB2vcyqVhJZCEdlEyKyUkI=; b=hicI5dtGd0WmbL7h7ZLNKDtbtwlWOKZKCqG1M4xP6GLhPsrry6epFb+pkRSEX6Y4YHMYWV jBp9zJoB/djaItTMVk3fTHYqYKAD14+zinqYb75DDTYL4N0bo4OK525oA8yGY+dad6sqCI FoVCGLLX5GNQk9YM55/B8MvckTkdO6+s5EdgwOZ1bXd7YNPGrlxv2tudab8chBMp2frWmV fvmCaKXSo4DtFomCmQSABAs5smTNhIRPSqzqs5akHR7UHbj9wCo4AYfDaiIchueg5TbKgZ R6bwjRAMGSgzpEgrS6RMsuDktpMdb5hHYViyP0QIV+6arDZ74k9M5T/grcHe4A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665481931; a=rsa-sha256; cv=none; b=DW0ZszWW82xrSZrvzNEd2xhay4Z6Z+gXgGkdtbDlyFG5k642mHIWsVNfo3zJQ90zjOPOyU TzvyF3BlmRJSQOmrdiUN2vtjSpXBK1OzCZWuqs5KhpK06KUe27qjCMTVslAKCF123dUXcU Rg0cxsDKZe8TYpREXRVK5zcQmKnckZlaj5zjjYhuojg59mIlLglhZbYtJohDQhpLmSnYN0 SVRUu+DKaU/uPPba1vorHiiZH9QFpuY8odWMo8ND7DZ8DAYK/w6EZe4NECqqzc4ssVdLmq WICBzThEX9Mw2jVCx8tN52I1/1s0GnNAWrqsKH5Ug4kh+n5Xc5Ja2JK2T0XIAA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=llIc0IZI; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.20 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=llIc0IZI; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4D1EC3A13D X-Spam-Score: -1.20 X-Migadu-Scanner: scn0.migadu.com X-TUID: hTJmM+21S5wS Heya Thomas, Looks mostly good, just a few nitpicks: On Tue Oct 11, 2022 at 10:19 AM BST, Thomas Albers via Guix-patches via wro= te: > +(define-public hiredis > + (package > + (name "hiredis") ^ We usually have two spaces of indentation here. > + (source (origin > + (method git-fetch) ^ Here too. > + (sha256 > + (base32 "0a55zk3qrw9yl27i87h3brg2hskmmzbfda77dhq9a4if7y70xn= fb")))) Put the hash string on a new line. > + (description "Library for sending commands and receiving replies to a= nd > +from a Redis server. It comes with a synchronous API, asynchronous API = and > +reply parsing API. Only the binary-safe Redis protocol is supported.") "This package provides a library for ..." is probably better. -- (