From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp11.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms5.migadu.com with LMTPS
	id cOJuKm7bNWOySQAAbAwnHQ
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Thu, 29 Sep 2022 19:52:46 +0200
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp11.migadu.com with LMTPS
	id YIZiKm7bNWMRjgAA9RJhRA
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Thu, 29 Sep 2022 19:52:46 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 585A62EF6A
	for <larch@yhetil.org>; Thu, 29 Sep 2022 19:52:46 +0200 (CEST)
Received: from localhost ([::1]:44700 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	id 1odxiH-0003dm-Hc
	for larch@yhetil.org; Thu, 29 Sep 2022 13:52:45 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:42442)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1odxhb-0002wM-Em
 for guix-patches@gnu.org; Thu, 29 Sep 2022 13:52:05 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:40476)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1odxha-0000by-SZ
 for guix-patches@gnu.org; Thu, 29 Sep 2022 13:52:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1odxha-00042M-O9
 for guix-patches@gnu.org; Thu, 29 Sep 2022 13:52:02 -0400
X-Loop: help-debbugs@gnu.org
Subject: [bug#58162] [PATCH] gnu: Add qdmr
Resent-From: "(" <paren@disroot.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Thu, 29 Sep 2022 17:52:02 +0000
Resent-Message-ID: <handler.58162.B58162.166447386715415@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 58162
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: "Ryan Tolboom" <ryan@using.tech>, <58162@debbugs.gnu.org>
Received: via spool by 58162-submit@debbugs.gnu.org id=B58162.166447386715415
 (code B ref 58162); Thu, 29 Sep 2022 17:52:02 +0000
Received: (at 58162) by debbugs.gnu.org; 29 Sep 2022 17:51:07 +0000
Received: from localhost ([127.0.0.1]:39547 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1odxge-00040W-EW
 for submit@debbugs.gnu.org; Thu, 29 Sep 2022 13:51:06 -0400
Received: from knopi.disroot.org ([178.21.23.139]:46996)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <paren@disroot.org>) id 1odxga-000405-Of
 for 58162@debbugs.gnu.org; Thu, 29 Sep 2022 13:51:03 -0400
Received: from localhost (localhost [127.0.0.1])
 by disroot.org (Postfix) with ESMTP id 630BE4C38E;
 Thu, 29 Sep 2022 19:50:59 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
 by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id iHRrRcxfFOpO; Thu, 29 Sep 2022 19:50:58 +0200 (CEST)
Mime-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
 t=1664473858; bh=5IH+/riHgZGeByg6Lir2WLFTEWShLc7B2Bxf6kJzP+0=;
 h=Date:Subject:From:To:References:In-Reply-To;
 b=BvDBrMJM81zQGEASqdVZCmviPCOk6Moxv9UcQ1anDcV/uir/6cMgLdQ1sK0MH7VXp
 5nmpbEHTf3MvdgAX+uN3RwMIrNuCYhqUqeKpIPDtYG77aRY8Nk8UC6TtR6oBW9ooyz
 JLMmq6t9gzLE1EvXC9UkIf6Ziwrr76WsF4iFYwDk2ErBLp4MHgxpdZkh+wpIy3Q9wR
 9w/U+UbRvg1p8B9I6rQyPIAqwgX1N4L8h+KOWS2S8soHPeZ9bnhOuZ3eoZybdJnhPV
 xBP5BNw+Y7w+71OICQSOJhw+8WlPkLi3EHdnXUy3NXMvybftFNZh8MTVjg4SS+w2RE
 LPjjCCpJVlZMg==
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 29 Sep 2022 18:50:57 +0100
Message-Id: <CN92QM27AVYH.25YI0XY5IYDKH@guix-aspire>
References: <20220929015726.26821-1-ryan@using.tech>
In-Reply-To: <20220929015726.26821-1-ryan@using.tech>
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+larch=yhetil.org@gnu.org>
Reply-to:  "\(" <paren@disroot.org>
X-ACL-Warn: ,  "\( via Guix-patches" <guix-patches@gnu.org>
From:  "\( via Guix-patches" via <guix-patches@gnu.org>
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: US
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1664473966;
	h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=4ekF4Gronny4ADlUP2Ur8xA27kmufP3tl4+1XkwP8MU=;
	b=lNp0CMzUsjotuM9PXwzrKElPfHRe2+pX5QeJjOHjNfReEwXQhyFcSBvO0Ve+2AZTWAzifl
	gMf5WURYQ5bBSP9TqxLFOdjrQlKyQasTQDm/GY2HUbqptDmNCsyWWBhkUqPTHQlaTwUrTk
	4C2R995VYRDyQoLP+5gPC1GbIbC0V3hSKQtDDuNo4h2AjACkjudci55RwAbC1oVHa9Y0TT
	sT1MqXOBoUZXsiRBBeWQEwmXC7YfrSRM1HsBvGugf0UMCBAN/Fh0hAquegdpjTH3sDT0US
	9vQaTFYTlaJr3R8jOMa+EdPVK1mqGVkXfmpdJqP6LWb0/yPqLs+bVR+NlatWiA==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664473966; a=rsa-sha256; cv=none;
	b=KQX6LihtbNbqoRfuHZngtFZ1b9Evv8tkOM+smgVTHM08iwH4BRpoFdt1Sb4R8ag75yb3of
	ipzsubkZBF+adSy0Gq8gEsb1KxUGYyMaijvLzoadnk0eqUtdNJLJa9QvurQII9JsPhwZ77
	2vFP069i3tqVOfW/tbP28ms1HpEj3SqgmY4lIRqq3Zt29eJE96NQ2vBNDYs4JGvD9JK3lW
	hLwDcuRrd7ktoyZ3x8vIb1sZyVX/63CLF3t6gnKpXCOXC7sewfJ6ntXHIaIBNCbhs6S92F
	DjgEPkri5Bl8s+g+WQI09pex/KfjkaRPx3PGQdMJFAX1VzsOSJG31MbRfHiMoQ==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=BvDBrMJM;
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Spam-Score: -1.64
Authentication-Results: aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=BvDBrMJM;
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Queue-Id: 585A62EF6A
X-Spam-Score: -1.64
X-Migadu-Scanner: scn0.migadu.com
X-TUID: H6t3pGrR3JqI

Hey!

On Thu Sep 29, 2022 at 2:57 AM BST, Ryan Tolboom wrote:
> +    (native-inputs (list qttools-5))
> +    (inputs (list qtbase-5 qtserialport qtlocation yaml-cpp libusb))

Usually inputs and native-inputs come after arguments.

> +    (arguments
> +     `(#:tests? #f ;No tests
> +       #:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'fix-paths
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (substitute* "lib/CMakeLists.txt"
> +                        (("DESTINATION \"/etc/udev/")
> +                         (string-append "DESTINATION \""
> +                                        (assoc-ref outputs "out") "/lib/=
udev/"))))))))

Try using the new gexp style for arguments:

  (arguments
   (list #:tests? #f ;no tests
         #:phases
         #~(modify-phases %standard-phases
             (add-after 'unpack 'patch-paths
               (lambda _
                 (substitute* "lib/CMakeLists.txt"
                   (("(DESTINATION \")/etc/udev/" _ directive)
                    (string-append directive #$output "/lib/udev/"))))))))

> +    (description
> +     "qdmr is a graphical user interface (GUI) application that allows o=
ne to
> +program several types of DMR radios.  To this end, it aims at being a mo=
re
> +universal codeplug programming software (CPS) compared to the device and=
 even
> +revision specific CPSs provided by the manufacturers.  The goal of this =
project
> +is to provide a single, comfortable, well-documented and platform-indepe=
ndent
> +CPS for several types of (mainly Chinese) DMR radios.
> +
> +To install the qdmr udev rules, you must extend @code{udev-service-type}=
 with this
> +package.  E.g.: @code{(udev-rules-service 'qdmr qdmr)}")

IMO this is too long and markety :) Also, I don't think you should mention
services in a package description.

> +    (home-page "https://dm3mat.darc.de/qdmr/")

Home-page usually goes directly before synopsis.

    -- (