all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: "Garek Dyszel" <garekdyszel@disroot.org>, <57774@debbugs.gnu.org>
Subject: [bug#57774] [PATCH v2] Add qucs-s.
Date: Wed, 14 Sep 2022 07:26:51 +0100	[thread overview]
Message-ID: <CMVWSNPV9K43.1SVD70HZ46NY8@guix-aspire> (raw)
In-Reply-To: <87fsgvm12r.fsf@disroot.org>

Hey,

On Tue Sep 13, 2022 at 10:11 PM BST, Garek Dyszel wrote:
> +           #:phases #~(modify-phases %standard-phases

To conserve lots of horizontal space, consider moving the ``modify-phases''
to a new line:

> +           #:phases
> +           #~(modify-phases %standard-phases

> +                                (search-input-file inputs "/bin/ngspice")
> +                                [...]
> +                                (search-input-file inputs "/bin/octave")

You can just do ``(search-input-file inputs "bin/octave")'', no need for the
leading slash. Also, wouldn't you want to patch in the paths for Xyce,
SpiceOpus, and Qucsator, too?

> +    (synopsis "GUI for different circuit simulation kernels")

s/different/various/, perhaps?

> +
> +@itemize
> +@item Ngspice (recommended)
> +@item Xyce
> +@item SpiceOpus
> +@item Qucsator (non-spice)
> +@end itemize")
> +    (home-page "https://ra3xdh.github.io/")
> +    (license license:gpl2+)))
> +
>  (define-public freehdl
>    (package
>      (name "freehdl")
> -- 
> 2.37.2


    -- (




  reply	other threads:[~2022-09-14  6:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13 15:48 [bug#57774] [PATCH] Add qucs-s Garek Dyszel via Guix-patches via
2022-09-13 16:12 ` ( via Guix-patches via
2022-09-13 17:28 ` Artyom V. Poptsov
2022-09-13 21:11 ` [bug#57774] [PATCH v2] " Garek Dyszel via Guix-patches via
2022-09-14  6:26   ` ( via Guix-patches via [this message]
2022-09-16 18:27     ` Garek Dyszel via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CMVWSNPV9K43.1SVD70HZ46NY8@guix-aspire \
    --to=guix-patches@gnu.org \
    --cc=57774@debbugs.gnu.org \
    --cc=garekdyszel@disroot.org \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.