From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aD/pN0WuIGPyCAEAbAwnHQ (envelope-from ) for ; Tue, 13 Sep 2022 18:22:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eEEEOEWuIGN+NAEAauVa8A (envelope-from ) for ; Tue, 13 Sep 2022 18:22:29 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8D8813B0AB for ; Tue, 13 Sep 2022 18:22:29 +0200 (CEST) Received: from localhost ([::1]:32776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oY8g8-0000Is-OX for larch@yhetil.org; Tue, 13 Sep 2022 12:22:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oY8Zw-0004bQ-0K for guix-patches@gnu.org; Tue, 13 Sep 2022 12:16:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35828) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oY8Zv-0003gB-LO for guix-patches@gnu.org; Tue, 13 Sep 2022 12:16:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oY8Zv-0001TV-Cp for guix-patches@gnu.org; Tue, 13 Sep 2022 12:16:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57774] [PATCH] Add qucs-s. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Sep 2022 16:16:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57774 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Garek Dyszel" , <57774@debbugs.gnu.org> Received: via spool by 57774-submit@debbugs.gnu.org id=B57774.16630857272548 (code B ref 57774); Tue, 13 Sep 2022 16:16:03 +0000 Received: (at 57774) by debbugs.gnu.org; 13 Sep 2022 16:15:27 +0000 Received: from localhost ([127.0.0.1]:52751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY8ZK-0000dp-Vl for submit@debbugs.gnu.org; Tue, 13 Sep 2022 12:15:27 -0400 Received: from knopi.disroot.org ([178.21.23.139]:43358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY8ZI-0000QY-0o for 57774@debbugs.gnu.org; Tue, 13 Sep 2022 12:15:26 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 28DEF4A071; Tue, 13 Sep 2022 18:15:22 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id bhNV8DNqYIyw; Tue, 13 Sep 2022 18:15:21 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1663085557; bh=HtpuksVrrbuYA4D9z02rcT2Iov5TLE42MF2+VEOAmrY=; h=Date:Subject:From:To:References:In-Reply-To; b=mLrsFDql9C+gQErGbFoUdM3TCJIijgXTJf/QKHNx58HpPbs7RI1qY6iVcmzJ/0oAu lMwPVgQuSOwU+pKn2D4iPxghOZu70E26dYwJdZw+It4G2cMVerJQJfXLzcORo8rP3T Na5ADssg6Okvoh8PXvvImRHuX9F9ehlg4Q/wlMbf+fthzl3ybsXaOBIA9ccOBUeygR geHN0znykn21dwAt2hbp7avGGkAwF5OFkFieA8Icl96rtLyQEyrUHym9pIZn4+FZ8e dk3TROZVu+xt3z838FMIX9gw+Ozlz/uiaJWOp2JDs9nWTit0gju15ztCNbchIvrYcA 0anVyXpvpwVWg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 13 Sep 2022 17:12:36 +0100 Message-Id: References: <875yhrgtrb.fsf@disroot.org> In-Reply-To: <875yhrgtrb.fsf@disroot.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663086149; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JOievzN93q2HJfCFpXDf+/vdojz1skagJ5liI1AAOeM=; b=GnbJz4A5yXSh26LLtsxRTl3hwdTOahL60s96TW5bGf+L7h+fomZg6z92bGhsiLfEqSh5sN Fty1kM6yfcGDp8uJGUh0HJLF1/RHZ9T8SZtdXDqmlKfLEcdlZAyiv/p1gmYH0a7YUmpDh6 j6u34l1A6tVtEWL13bcKm3uWv24p87GHNUszec9MLxHf3NbOBegiyn80mo58+0co3pTDA7 zLZsiX3SgmPc7Gqkr5HcPVR+nbVPO4+1YQvFdge4VBi/eUcnZ39q0mTzQbYXxgRKa+RHGU Lmqns/C0uBqTwlf10xeo/LnA6w9hAlJLnWBFVnavdOX3miw8G3RT3zeY4BGbRQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663086149; a=rsa-sha256; cv=none; b=mQhdSytZ1jEzgQnADDaCktfZBu3whV1jTaimT2E/FZbxb9MpX78koO1yGZFoXWOhoFBn+A ytvsiySjmm4onn8AFuuyVLAViK8sZCgsPzYLziI9QR+A5C/QoU5F+QWROTUTjur8bR4mnx ySGqiV7Qf6vLVv5Lg/hZM4AU7hCLQnKq3Ep16yd6CpkpWSGHVSEs8mG91UmHGgWi6C2gLD x7xbcB5IRPKwPedA53UBC4eYeCsESdMetocRzJ2EFu1CgwKlBTqAqzUirCLYZyHJPagyMU 7wirnbG8UbnwKut36FHxqMyHf6XB70NFYaIDCwlEg1Iierspe+jMYqnqwiruSQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=mLrsFDql; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=mLrsFDql; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8D8813B0AB X-Spam-Score: -2.31 X-Migadu-Scanner: scn1.migadu.com X-TUID: sVytKS1StZWj Hey, On Tue Sep 13, 2022 at 4:48 PM BST, Garek Dyszel via Guix-patches via wrote= : > + (outputs '("out")) This line is redundant; ``out'' is implicit. > + (propagated-inputs (list ngspice)) Can you try to avoid propagating this somehow? Propagation is a last-resort measure, and usually we try to do something like patching invocations of external commands to refer to the full store path. (Although, looking at the ``modify-phases'' below, it seems like you already do that, so I guess you'll only need to move ``ngspice'' to ``inputs''.) > + (arguments > + `(;; There exists no "tests" target in the Makefile generated by Please use the new style ``(list ...)'' instead of ```(...)''. > + (modify-phases %standard-phases You'll need to gexp this under the new arguments style: ``#~(modify-phases = ...)''. > + (with-directory-excursion "etc/xdg/qucs_s" > + (invoke "touch" "qucs_s.conf") > + ;; Specify where the ngspice executable is located. > + (invoke "sed" "-i" > + (string-append "1iNgspiceExecutable=3D/gnu/store/= " > + (assoc-ref inputs "ngspice") > + "/bin/ngspice") "qucs_s.conf") > + ;; Set the spice4qucs working directory to > + ;; ~/.qucs/spice4qucs. > + ;; (The default is /spice4qucs, which is rather > + ;; dangerous.) > + (invoke "sed" "-i" "2iS4Q_workdir=3D~/.qucs/spice4qucs" > + "qucs_s.conf"))))))) This looks pretty redundant. Try using this instead: > + (call-with-output-file "etc/xdg/qucs_s/qucs_s.conf" > + (cute format <> > + "~ > +NgspiceExecutable=3D~a > +S4Q_workdir=3D~/.qucs/spice4qucs~%" > + (search-input-file inputs "bin/ngspice"))) And add this to ``arguments'': #:modules `((ice-9 format) (srfi srfi-26) ,@%gnu-build-system-modules) to import ``format'' and ``cute'', respectively. > + (description > + "Qucs-S is a spin-off of the Qucs cross-platform circuit > +simulator. The \"S\" letter indicates SPICE. The purpose of the Qucs-S > +subproject is to use free SPICE circuit simulation kernels with the > +Qucs GUI. It merges the power of SPICE and the simplicity of the Qucs > +GUI. Qucs intentionally uses its own SPICE incompatible simulation > +kernel Qucsator. It has advanced RF and AC domain simulation features, > +but most of the existing industrial SPICE models are incompatible with > +it. Qucs-S is not a simulator by itself, but it requires to use a > +simulation backend with it. The schematic document format of Qucs and > +Qucs-S are fully compatible. Qucs-S can be used with the following > +simulation kernels: > +@itemize > +@item Ngspice is recommended to use. Ngspice is powerful > +mixed-level/mixed-signal circuit simulator. The most of industrial > +SPICE models are compatible with Ngspice. It has an excellent > +performance for time-domain simulation of switching circuits and > +powerful postprocessor. > +@item XYCE is a new SPICE-compatible circuit simulator written by > +Sandia from the scratch. It supports basic SPICE simulation types and > +has an advanced RF simulation features such as harmonic balance > +simulation. > +@item SpiceOpus is developed by the Faculty of Electrical Engineering > +of the Ljubljana University. It is based on the SPICE-3f5 code. > +@item Backward compatible with Qucsator. > +@end itemize") I think this description would probably be better and far more succint as: > + (description > + "This package provides a fork of the Qucs cross-platform circuit > +simulator, which allows the use of SPICE circuit simulation kernels > +with the Qucs GUI.") -- (