all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: "Liliana Marie Prikler" <liliana.prikler@gmail.com>,
	<57671@debbugs.gnu.org>
Subject: [bug#57671] [PATCH] gnu: Add mpdevil.
Date: Sat, 10 Sep 2022 10:57:00 +0100	[thread overview]
Message-ID: <CMSMRDKOA2BP.1RBSFVOSIBRT2@guix-aspire> (raw)
In-Reply-To: <932cec629b2a3cdc01d2eb006eead634b3fd417f.camel@gmail.com>

Hey Liliana,

On Thu Sep 8, 2022 at 9:48 AM BST, Liliana Marie Prikler wrote:
> +    (arguments
> +     (list
> +      #:glib-or-gtk? #t

Maybe move these keywords like this:

  (list #:glib-or-gtk? #t
        #:phases
        #~(...))

This generally seems to be the standard.

> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (let ((prog (string-append (assoc-ref outputs "out")
> +                                         "/bin/mpdevil")))

`(assoc-ref outputs "out")' -> `#$output'
`(lambda* (#:key outputs #:allow-other-keys)' -> `(lambda _'

> +    (native-inputs (list `(,glib "bin")))

``(,glib "bin")' -> `(list glib "bin")'

> +    (description "mpdevil is a music browser for the Music Player Daemon (MPD),

This:

  (description
   "...")

seems to be the norm for descriptions.

    -- (




      parent reply	other threads:[~2022-09-10  9:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08  8:48 [bug#57671] [PATCH] gnu: Add mpdevil Liliana Marie Prikler
2022-09-10  9:50 ` Christopher Baines
2022-09-10 15:25   ` bug#57671: " Liliana Marie Prikler
2022-09-10  9:57 ` ( via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CMSMRDKOA2BP.1RBSFVOSIBRT2@guix-aspire \
    --to=guix-patches@gnu.org \
    --cc=57671@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.