From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iFmZKgEO7WIZJwEAbAwnHQ (envelope-from ) for ; Fri, 05 Aug 2022 14:33:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oEOcKgEO7WLDxgAA9RJhRA (envelope-from ) for ; Fri, 05 Aug 2022 14:33:05 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 65AD7E318 for ; Fri, 5 Aug 2022 14:33:05 +0200 (CEST) Received: from localhost ([::1]:49352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJwVk-00087m-Bo for larch@yhetil.org; Fri, 05 Aug 2022 08:33:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJwTm-0007Ae-Go for guix-patches@gnu.org; Fri, 05 Aug 2022 08:31:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38607) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJwTm-00081C-7W for guix-patches@gnu.org; Fri, 05 Aug 2022 08:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJwTm-0000Bb-3T for guix-patches@gnu.org; Fri, 05 Aug 2022 08:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56994] [PATCH] Add nmail Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 Aug 2022 12:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56994 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: , <56994@debbugs.gnu.org> Received: via spool by 56994-submit@debbugs.gnu.org id=B56994.1659702633654 (code B ref 56994); Fri, 05 Aug 2022 12:31:02 +0000 Received: (at 56994) by debbugs.gnu.org; 5 Aug 2022 12:30:33 +0000 Received: from localhost ([127.0.0.1]:56585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJwTH-0000AQ-Jz for submit@debbugs.gnu.org; Fri, 05 Aug 2022 08:30:33 -0400 Received: from knopi.disroot.org ([178.21.23.139]:33258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJwTC-0000A4-1X for 56994@debbugs.gnu.org; Fri, 05 Aug 2022 08:30:29 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 27AE140D83; Fri, 5 Aug 2022 14:30:24 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0xk6_TFc2Qzs; Fri, 5 Aug 2022 14:30:22 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659702620; bh=n0hpFDA9PPnC3fyl+AbmdrIBizLQtS8XuVvuTFtb3s4=; h=Date:From:To:Subject:References:In-Reply-To; b=FFmQRLZ9fYkpBrbw5C38NXmsZzR/Vwz63cLrZS+UBip7QgxccJ/iGG4yBWk7g4/DG vdio5KiPKPBoDVKuRpkxnVjxHbIPy83AsoK5mOGrwxSHj2AwP/P/w8ZS2Y73Hla5q5 0AR88Lo5TwJqrWvUd1bYwGIMXfTEMtwK7Rpflua+u4FRFqfHekb0ireBps+4NGMQuz 7xAwgbzf/icLbydee1cPHS2WXUbDfA1tKSku4XvghKAHWFzqrTnCPZPWm+B9O2b2eP 5j8hgdSQqKaMKega0w8iP+fubYua6T2bKH2HHuLWAXcL4LhXKpxNMgitdutPXyxXi6 2SHsQd3VnqoVw== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 05 Aug 2022 13:30:19 +0100 Message-Id: References: <24b34888cb54d3702eaeebf40267d910be9b54bb.1659666096.git.matf@disr.it> In-Reply-To: <24b34888cb54d3702eaeebf40267d910be9b54bb.1659666096.git.matf@disr.it> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659702785; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=A5N19PTVbsaf5xQDr2FjWI/nP1IZYcd27ANVGs23l0o=; b=kabFvA76lghFNh7swiNQPV1lzw5GRqC1O6Ij9j915YV7VGfaU18jxd/1C+xYK4LwVCUAx4 o5P3WupIGQW59ZAyogDbcpdamxqvxc2+LpYLaNTSeYtyOaRSac7aNIoAXWswtE6NfhrkGN HS4SleSG7wiCR0QqOuBxdtw5+oEt6BagXskF+pxVtN0bsLzhJShMuVJEb8/MKECeYFkQbV T9wYUuYsSARayRHyacYLnaTCtYge8dIH199MwL6Qn29BYHC/KSlMtLt1nl0zfNedv4rjm2 grMLUvv1LtFlEf2KUt2zV0DO+NPMkuarW380uWtYgy6Mz5TgM2cYqZhA4LUYzQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659702785; a=rsa-sha256; cv=none; b=OMMUL3LJjuksfY1h/0FUXdvIs4pLjzSGI4VKWqZDh5sgFOKfg8BT7zJ7PcKx7rYyliJn2Z 6NYxloMPFaj7iPLauD99XdiVlrXMevVo9ef7+9RXaYnFsqYUukzNvHtTUCZ8n5gH+wDPMQ +aOgNSiIAV+VPZD5/N9NWKynha9hc2Naa8Q+EtriWztM5xb9ze5FdzLv3t7eC803AmBDNG 67pF3OU0XGBCC3/KOiHdz4ENq3stnOYnwkSWV7riNamWSrWOkOYtRcGlRe9J+xNdTJPFfO /AKhMOxahhT2PdKYwp0QvVPIiuvRhRrxIiQFbfbbBmfcHnnVhKWrJmUdN2od7g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=FFmQRLZ9; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.20 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=FFmQRLZ9; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 65AD7E318 X-Spam-Score: -3.20 X-Migadu-Scanner: scn0.migadu.com X-TUID: qkj/YyyDwFjA Nice to see you got it working :) Some stylistic nits: On Fri Aug 5, 2022 at 3:21 AM BST, wrote: > From: M > > --- You need to write a commit message following the project's conventions. In this case, it'd be something like: > gnu: packages: Add nmail. > > * gnu/packages/mail.scm: Reorder module imports. Remove > duplicate imports. > (nmail): New variable. Refer to . (No, I don't like it much either :)) > + (arguments > + (list #:phases #~(modify-phases %standard-phases > + (replace 'check > + (lambda* > + (#:key tests? #:allow-other-keys) > + (when tests? (invoke "ctest" "--output-on-= failure"))))))) This part should be reformatted like this: > (arguments > (list #:phases > #~(modify-phases %standard-phases > (replace 'check > (lambda* (#:key tests? #:allow-other-keys) > (when tests? > (invoke "ctest" "--output-on-failure"))))))) > + (inputs (list libetpan > + xapian > + sqlite > + cyrus-sasl > + ncurses > + openssl > + file > + (list util-linux "lib"))) And this as: > (inputs > (list cyrus-sasl > file > ncurses > openssl > sqlite > (list util-linux "lib") > xapian)) > + (native-inputs (list pkg-config)) > + (home-page "https://github.com/d99kris/nmail") > + (synopsis "Terminal-based email client") > + (description > + "@command{nmail} is a terminal-based email client with a > +@code{ncurses} user interface similar to @code{alpine} and @code{pine}."= ) > + (license license:expat))) > + > (define-public nullmailer > (package > (name "nullmailer") > --=20 > 2.34.0 Other than that, LGTM! :) -- (