From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4KFTKiwM4GKr/QAAbAwnHQ (envelope-from ) for ; Tue, 26 Jul 2022 17:45:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iPJHKSwM4GLNJgAAG6o9tA (envelope-from ) for ; Tue, 26 Jul 2022 17:45:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 55CDB13402 for ; Tue, 26 Jul 2022 17:45:48 +0200 (CEST) Received: from localhost ([::1]:46836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGMkl-0000rF-F8 for larch@yhetil.org; Tue, 26 Jul 2022 11:45:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGMVX-0004Gu-Gx for guix-patches@gnu.org; Tue, 26 Jul 2022 11:30:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGMVX-0007Xn-7S for guix-patches@gnu.org; Tue, 26 Jul 2022 11:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oGMVX-0005QA-2Z for guix-patches@gnu.org; Tue, 26 Jul 2022 11:30:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56657] [PATCH] gnu: ranger: Add dependency file Resent-From: =?UTF-8?Q?Nguy=E1=BB=85n?= Gia Phong Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jul 2022 15:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56657 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Liliana Marie Prikler" , <56657@debbugs.gnu.org> Received: via spool by 56657-submit@debbugs.gnu.org id=B56657.165884938920737 (code B ref 56657); Tue, 26 Jul 2022 15:30:02 +0000 Received: (at 56657) by debbugs.gnu.org; 26 Jul 2022 15:29:49 +0000 Received: from localhost ([127.0.0.1]:54200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGMVI-0005OP-K9 for submit@debbugs.gnu.org; Tue, 26 Jul 2022 11:29:49 -0400 Received: from knopi.disroot.org ([178.21.23.139]:33090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGFDl-0007Ep-Qy for 56657@debbugs.gnu.org; Tue, 26 Jul 2022 03:43:16 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 34D0440DC3; Tue, 26 Jul 2022 09:43:12 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cbQJBPJK6Ja3; Tue, 26 Jul 2022 09:43:11 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1658821391; bh=9mxULXOIASMUe/x022CrbZ0+T2oFz4X3HofhGdjxMgk=; h=Date:To:From:Subject:References:In-Reply-To; b=iBjvlftg90+yHVbFzDl2lpRcWiXtWfGcmbKpZZLi7CD/5tbvfgQhiEAhUSehlQq1j 3dhZtSurRnR6E56pjwrAWEvVCFnaODd9ttdrm+RbdgCrH3ytzSYTxBP9CHqLgrhyDM 2DvNePT8TrjkEbt77jkI055E5vyKoPloKhlO+qyj6d2eyJJnexgQW5YhQoFqiSxNWL 6tRH+DPaVBlPGZCv8HfVjPuwjyinqzgzxm9NKLTBSBGdU6/YKCcEneRjtiOvTJsCsI auR1xR84P8w7YKy9WXwl5BtJVRwZguke5Yynl1DrKrEIX5Ej+qiKJThL+MozyHLJCb qhrTZe1WUW3bQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 26 Jul 2022 16:43:06 +0900 Message-Id: References: <20220720080143.18005-1-mcsinyx@disroot.org> <223585fd44f0b8e94d85aacd6885d01432b5e3e0.camel@ist.tugraz.at> In-Reply-To: <223585fd44f0b8e94d85aacd6885d01432b5e3e0.camel@ist.tugraz.at> X-Mailman-Approved-At: Tue, 26 Jul 2022 11:29:47 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: =?UTF-8?Q?Nguy=E1=BB=85n?= Gia Phong X-ACL-Warn: , =?utf-8?q?Nguy=E1=BB=85n_Gia_Phong_via_Guix-patches?= From: guix-patches--- via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658850348; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=P1/vmzIRrOZs+Pq/SQ0scD5LRz1JMVNVy8F/ok02JJc=; b=mhQ3WzUMSPhuxgFk+n/heBi47MiB78L7BXI0TByPbJ3CleYMqj+5Fj3MDctbqz034V9NsS HHg+YSHC6z521FaO7+6V4Pv+4O05YNWq50mJA42nMKiBulF7M8Mh3jxgKUkci3D+eVdfT3 I/QnZem8LPhQvo7O2sCh1itNWF+ljmPsljJFD6o089nZoWnwELTEqdkFmtsv3/gkQD4kak IX6X7CtVivgm0pUHrJZGyqLQGotGPz/eZPZSgnDk5JuMRRIzKmoMo/O0IED7EN4Xh4mPgs 0KDZhIZi0IRFJ7FhoeiHI9olBN2aPBn/iIExpJYL0xH8w7S1hjzQdG+ScIEjsw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658850348; a=rsa-sha256; cv=none; b=RA/73U6xjjz5RcbescCHIuZWX0y8VC6YcASx2GWoNE3xjyiV+qNCr5/c88DCskI9Y/0kkQ 6bVBjIzGWHqQm3i9RsAfN58+jI0LoEVC6ndrHfL4m2ntzAwv7SX90wVhbTRy10YZm6xxj0 pYJwo9w4hHILLQE+9hT7pD+wgtRBMo6q8tFgPCiekXuxO+4wjFAjCY3SkW/7pNDbVUWIHV AJwFCB8kUB/9Cf8xWQWkLK/FwlHecT/J3x5LNqXmLpNVfwqUpsHCePZY0Y2IXzZX8zkvN2 AdWMrAb7j5WTdHcVvu53is3fhuUUPpWPKrUYNEM8CNdjVlp8PfNuQM249PdOIw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=iBjvlftg; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=iBjvlftg; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 55CDB13402 X-Spam-Score: -1.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5yKSzf8G/+Jq On Thu Jul 21, 2022 at 8:50 AM +0200, Liliana Marie Prikler wrote: > Rather than patching PATH, you should use substitute* > to hardcode the reference. Coming from Nix, I don't get why is it preferred. Shouldn't users be able to override runtime dependencies at runtime, e.g. via a custom wrapper script? If that is the case, I suppose the correct wrapper would be (wrap-program ... '("PATH" suffix ,(list (string-append file "/bin")))) > Also, do write a ChangeLog style commit message. Thanks, I probably missed this reading the contrib guide.