all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: guix-patches--- via <guix-patches@gnu.org>
To: "Liliana Marie Prikler" <liliana.prikler@ist.tugraz.at>,
	<56657@debbugs.gnu.org>
Subject: [bug#56657] [PATCH] gnu: ranger: Add dependency file
Date: Tue, 26 Jul 2022 16:43:06 +0900	[thread overview]
Message-ID: <CLPF3SUOY06B.2ONLNWJ9RSI7V@nix> (raw)
In-Reply-To: <223585fd44f0b8e94d85aacd6885d01432b5e3e0.camel@ist.tugraz.at>

On Thu Jul 21, 2022 at 8:50 AM +0200, Liliana Marie Prikler wrote:
> Rather than patching PATH, you should use substitute*
> to hardcode the reference.

Coming from Nix, I don't get why is it preferred.
Shouldn't users be able to override runtime dependencies at runtime,
e.g. via a custom wrapper script?

If that is the case, I suppose the correct wrapper would be

(wrap-program ...
  '("PATH" suffix ,(list (string-append file "/bin"))))

> Also, do write a ChangeLog style commit message.

Thanks, I probably missed this reading the contrib guide.




  reply	other threads:[~2022-07-26 15:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20  8:01 [bug#56657] [PATCH] gnu: ranger: Add dependency file guix-patches--- via
2022-07-21  6:50 ` Liliana Marie Prikler
2022-07-26  7:43   ` guix-patches--- via [this message]
2022-07-26  7:48     ` Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CLPF3SUOY06B.2ONLNWJ9RSI7V@nix \
    --to=guix-patches@gnu.org \
    --cc=56657@debbugs.gnu.org \
    --cc=liliana.prikler@ist.tugraz.at \
    --cc=mcsinyx@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.