* [bug#56724] [PATCH] gnu: Fix pcsc-lite missing input: python
@ 2022-07-23 14:17 Maya via Guix-patches via
2022-07-23 14:20 ` ( via Guix-patches via
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Maya via Guix-patches via @ 2022-07-23 14:17 UTC (permalink / raw)
To: 56724
The pcsc-lite package had an dependency for pcsc-spy command. This command requires python3 to be executable. This was however not declared in inputs of this package.
---
gnu/packages/security-token.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 74ea57137f..586e9cbc8d 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -242,7 +242,8 @@ (define-public pcsc-lite
(list perl ; for pod2man
pkg-config))
(inputs
- `(("libudev" ,eudev)))
+ `(("python3" ,python)
+ ("libudev" ,eudev)))
(home-page "https://pcsclite.apdu.fr/")
(synopsis "Middleware to access a smart card using PC/SC")
(description
--
2.37.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [bug#56724] [PATCH] gnu: Fix pcsc-lite missing input: python
2022-07-23 14:17 [bug#56724] [PATCH] gnu: Fix pcsc-lite missing input: python Maya via Guix-patches via
@ 2022-07-23 14:20 ` ( via Guix-patches via
2022-07-23 14:22 ` Maxime Devos
2022-07-23 14:39 ` [bug#56724] (No Subject) Maya via Guix-patches via
2 siblings, 0 replies; 5+ messages in thread
From: ( via Guix-patches via @ 2022-07-23 14:20 UTC (permalink / raw)
To: Maya, 56724
LGTM
-- (
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#56724] [PATCH] gnu: Fix pcsc-lite missing input: python
2022-07-23 14:17 [bug#56724] [PATCH] gnu: Fix pcsc-lite missing input: python Maya via Guix-patches via
2022-07-23 14:20 ` ( via Guix-patches via
@ 2022-07-23 14:22 ` Maxime Devos
2022-07-23 14:39 ` [bug#56724] (No Subject) Maya via Guix-patches via
2 siblings, 0 replies; 5+ messages in thread
From: Maxime Devos @ 2022-07-23 14:22 UTC (permalink / raw)
To: Maya, 56724
[-- Attachment #1.1.1: Type: text/plain, Size: 224 bytes --]
On 23-07-2022 16:17, Maya via Guix-patches via wrote:
> - `(("libudev" ,eudev)))
> + `(("python3" ,python)
> + ("libudev" ,eudev)))
Can be simplified to (list python eudev).
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* [bug#56724] (No Subject)
2022-07-23 14:17 [bug#56724] [PATCH] gnu: Fix pcsc-lite missing input: python Maya via Guix-patches via
2022-07-23 14:20 ` ( via Guix-patches via
2022-07-23 14:22 ` Maxime Devos
@ 2022-07-23 14:39 ` Maya via Guix-patches via
2022-07-23 17:45 ` bug#56724: " Marius Bakke
2 siblings, 1 reply; 5+ messages in thread
From: Maya via Guix-patches via @ 2022-07-23 14:39 UTC (permalink / raw)
To: 56724@debbugs.gnu.org
>
> On 23-07-2022 16:17, Maya via Guix-patches via wrote:
>
> > - `(("libudev" ,eudev))) +` (("python3" ,python)
> > + ("libudev" ,eudev)))
>
>
>
> Can be simplified to (list python eudev).
>
> Greetings,
> Maxime.
Yes, sorry, I didn't test that before. Here is the new version.
---
gnu/packages/security-token.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 74ea57137f..e70ba2ea95 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -242,7 +242,7 @@ (define-public pcsc-lite
(list perl ; for pod2man
pkg-config))
(inputs
- `(("libudev" ,eudev)))
+ (list python eudev))
(home-page "https://pcsclite.apdu.fr/")
(synopsis "Middleware to access a smart card using PC/SC")
(description
--
2.37.0
Regards,
Maya
^ permalink raw reply related [flat|nested] 5+ messages in thread* bug#56724: (No Subject)
2022-07-23 14:39 ` [bug#56724] (No Subject) Maya via Guix-patches via
@ 2022-07-23 17:45 ` Marius Bakke
0 siblings, 0 replies; 5+ messages in thread
From: Marius Bakke @ 2022-07-23 17:45 UTC (permalink / raw)
To: Maya, 56724@debbugs.gnu.org
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
Maya via Guix-patches via <guix-patches@gnu.org> skriver:
> Yes, sorry, I didn't test that before. Here is the new version.
>
> ---
> gnu/packages/security-token.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
> index 74ea57137f..e70ba2ea95 100644
> --- a/gnu/packages/security-token.scm
> +++ b/gnu/packages/security-token.scm
> @@ -242,7 +242,7 @@ (define-public pcsc-lite
> (list perl ; for pod2man
> pkg-config))
> (inputs
> - `(("libudev" ,eudev)))
> + (list python eudev))
> (home-page "https://pcsclite.apdu.fr/")
> (synopsis "Middleware to access a smart card using PC/SC")
> (description
Pushed to the 'core-updates' branch with c4386d0603415, along with a
commit message that follows the project conventions.
Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-23 17:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-23 14:17 [bug#56724] [PATCH] gnu: Fix pcsc-lite missing input: python Maya via Guix-patches via
2022-07-23 14:20 ` ( via Guix-patches via
2022-07-23 14:22 ` Maxime Devos
2022-07-23 14:39 ` [bug#56724] (No Subject) Maya via Guix-patches via
2022-07-23 17:45 ` bug#56724: " Marius Bakke
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.