[bug#56724] [PATCH] gnu: Fix pcsc-lite missing input: python

[bug#56724] [PATCH] gnu: Fix pcsc-lite missing input: python

[Maya via Guix-patches via]

The pcsc-lite package had an dependency for pcsc-spy command. This command requires python3 to be executable. This was however not declared in inputs of this package.
---
 gnu/packages/security-token.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 74ea57137f..586e9cbc8d 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -242,7 +242,8 @@ (define-public pcsc-lite
      (list perl ; for pod2man
            pkg-config))
     (inputs
-     `(("libudev" ,eudev)))
+     `(("python3" ,python)
+       ("libudev" ,eudev)))
     (home-page "https://pcsclite.apdu.fr/")
     (synopsis "Middleware to access a smart card using PC/SC")
     (description
--
2.37.0

[bug#56724] [PATCH] gnu: Fix pcsc-lite missing input: python

[( via Guix-patches via]

LGTM

  -- (

[bug#56724] [PATCH] gnu: Fix pcsc-lite missing input: python

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 224 bytes --]


On 23-07-2022 16:17, Maya via Guix-patches via wrote:
> -     `(("libudev" ,eudev)))
> +     `(("python3" ,python)
> +       ("libudev" ,eudev)))


Can be simplified to (list python eudev).

Greetings,
Maxime.


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[bug#56724] (No Subject)

[Maya via Guix-patches via]

>
> On 23-07-2022 16:17, Maya via Guix-patches via wrote:
>
> > - `(("libudev" ,eudev))) +` (("python3" ,python)
> > + ("libudev" ,eudev)))
>
>
>
> Can be simplified to (list python eudev).
>
> Greetings,
> Maxime.

Yes, sorry, I didn't test that before. Here is the new version.

---
 gnu/packages/security-token.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 74ea57137f..e70ba2ea95 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -242,7 +242,7 @@ (define-public pcsc-lite
      (list perl ; for pod2man
            pkg-config))
     (inputs
-     `(("libudev" ,eudev)))
+     (list python eudev))
     (home-page "https://pcsclite.apdu.fr/")
     (synopsis "Middleware to access a smart card using PC/SC")
     (description
--
2.37.0

Regards,
Maya

bug#56724: (No Subject)

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

Maya via Guix-patches via <guix-patches@gnu.org> skriver:

> Yes, sorry, I didn't test that before. Here is the new version.
>
> ---
>  gnu/packages/security-token.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
> index 74ea57137f..e70ba2ea95 100644
> --- a/gnu/packages/security-token.scm
> +++ b/gnu/packages/security-token.scm
> @@ -242,7 +242,7 @@ (define-public pcsc-lite
>       (list perl ; for pod2man
>             pkg-config))
>      (inputs
> -     `(("libudev" ,eudev)))
> +     (list python eudev))
>      (home-page "https://pcsclite.apdu.fr/")
>      (synopsis "Middleware to access a smart card using PC/SC")
>      (description

Pushed to the 'core-updates' branch with c4386d0603415, along with a
commit message that follows the project conventions.

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]