From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oMsQBgx5HmJK9gAAgWs5BA (envelope-from ) for ; Tue, 01 Mar 2022 20:50:36 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GKGUAgx5HmJNJAAAauVa8A (envelope-from ) for ; Tue, 01 Mar 2022 20:50:36 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DC0C91170D for ; Tue, 1 Mar 2022 20:50:35 +0100 (CET) Received: from localhost ([::1]:42188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nP8W1-00031w-Nf for larch@yhetil.org; Tue, 01 Mar 2022 14:50:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nP80Y-0001Tw-15 for guix-patches@gnu.org; Tue, 01 Mar 2022 14:18:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44413) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nP80X-0002eE-ON for guix-patches@gnu.org; Tue, 01 Mar 2022 14:18:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nP80X-00062n-KD for guix-patches@gnu.org; Tue, 01 Mar 2022 14:18:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54215] [PATCH Shepherd] service: Add #:rlimits parameter to 'exec-command' & co. Resent-From: Attila Lendvai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 01 Mar 2022 19:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54215@debbugs.gnu.org Received: via spool by 54215-submit@debbugs.gnu.org id=B54215.164616225423193 (code B ref 54215); Tue, 01 Mar 2022 19:18:01 +0000 Received: (at 54215) by debbugs.gnu.org; 1 Mar 2022 19:17:34 +0000 Received: from localhost ([127.0.0.1]:38310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nP806-00061y-AX for submit@debbugs.gnu.org; Tue, 01 Mar 2022 14:17:34 -0500 Received: from mail-4018.proton.ch ([185.70.40.18]:28755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nP803-00061j-MR for 54215@debbugs.gnu.org; Tue, 01 Mar 2022 14:17:33 -0500 Date: Tue, 01 Mar 2022 19:17:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail3; t=1646162244; bh=bKGLUMO0snbcdKGzuqVrKGWRZ2dnqdBT/khFNflPwLw=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=obyKFeG/lUhVJUc0laBM67kDbzfa+I/rQlJP8hfpBLgTZLFMhkp/CjGpgBdd5GNQI nyAr7aVuDsPm7W1wRFksMIbBFTPyHHve1okHQCzoVkVtIdLUAS20UHz/3spz2UoV6p ISiFzQvKpNLj8tfWLCpYGu/keeE/rlnUwGsHRVuq+cjCtC8hC+mX3DVk9IoSf+ASFg O/FN17wzqBDo4H/k2VizfRwd6SLcOv54pmYZe3qzmXLaY2AlyBGMTy6Gq7WF/uWpW3 gzgLMX+9qqUGcrps1OuXo8tr/Gcdre9E6NyIlCvRTvEddz+2KfL6IseRRT5N46OJx+ s/W2WZMiUbmIA== From: Attila Lendvai Message-ID: In-Reply-To: <9dc56d38b66bcdecf7eb6143f873f07c6cf54582.camel@telenet.be> References: <20220301181242.18384-1-attila@lendvai.name> <48526d32a684a531940b59edcfb016ab81c7d3bb.camel@telenet.be> <9dc56d38b66bcdecf7eb6143f873f07c6cf54582.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646164235; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bKGLUMO0snbcdKGzuqVrKGWRZ2dnqdBT/khFNflPwLw=; b=aIAPJqJmKIs4oHrKGIuItomDf/+4LxPYqvGC24wr8ebM8TOE+k3FpuYMAWk3ENqjSaziZ1 9JIPntaguXk/uL9TW+a+B2A2M0LsbX1yPxfJOcYfnrL4Clh4Q3crIylOM4Fcen553vBmMR iqbyfCBevEQW2nigg0ECyRhhghC9AUCpx7bNO1QOv9XjgNzq1C8jLJIYNECiOQES7a2IkT Hw9d0ah5ntv2VOZ+1NOcCCgIOcHeoenbE2FLdo3h/XZYwruK5x7W7edYL79qCe5FKIs9pr 9Ox/A2R1F5jJYki6EHMuczRkfuhQ0dx/krF0wTDfsKuQvktY+zWE2yKszuAtcg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646164235; a=rsa-sha256; cv=none; b=UdSFgYoEwq78wPGmbdgb7pNYps8/rXLiSJA4BTLkA4K2j9hz/dw99ueycWXuDEz3GIxhmd dSjvlwWxDJPTVNKJqxbNQsUftyOuyOTCYupDVNy+RIDUqdd8dq04UehZ5DNALAGrTBguvy /MpjVu0ljEIwBLL/hwTlDATvXflhLxrsj/9pdp1YGnEhsLo1uX1/Vh1buWN/fwDFDfJ3dH 95APCpQDiol2FMS/WAA3RRVTGX1sJEysBasTxKM9qizvrYmgukVVsni3ctftdJURUaZD3n WuwspnCof30iWbsso5ySOT4ffWdkAid2JbjAtP0Hd2L1xZd3ihze8Ayc6/pUrw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail3 header.b="obyKFeG/"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.12 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail3 header.b="obyKFeG/"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DC0C91170D X-Spam-Score: 0.12 X-Migadu-Scanner: scn0.migadu.com X-TUID: lQ3vyX3/G4Y4 > > now that i have a reaconable edit-build-test cycle for shepherd, i'm pl= anning to > > clean up shepherd error reporting and logging, so that when an error oc= cur then > > there's a proper backtrace in the shepherd logs. > > i'd rather work on that instead. does that sound reasonable? > > Sure! Better error reporting and rlimit support are orthogonal > concerns. well, it's not orthogonal in the sense that i can only work on one of them = in the same unit of time, and this is already a side-project of a side-project= for me. let me know if sanity checking the rlimit arg is a precondition for applyin= g this patch, and then i'll look into it. otherwise APPLY and SETRLIMIT both signal any errors they encounter, and i = think better logging and backtraces will take us much farther than numerous sanit= y checks and error messages, let alone the not-so-apparent costs of the extra= LoC that they introduce into the code. -- =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CThe only way to have a friend is to be one.=E2=80=9D =09=E2=80=94 Ralph Waldo Emerson (1803=E2=80=931882)