From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jelle Licht Subject: Re: [PATCH 2/2] Add jq Date: Sun, 27 Mar 2016 00:34:26 +0100 Message-ID: References: <1459019619.979274.560403538.738A9771@webmail.messagingengine.com> <20160326224554.GA430@jasmine> <20160326232621.GA4950@jasmine> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a114013cece55e8052efc1e6a Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43202) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajxj3-0002Fj-1q for guix-devel@gnu.org; Sat, 26 Mar 2016 19:34:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajxiz-0005fD-Q7 for guix-devel@gnu.org; Sat, 26 Mar 2016 19:34:36 -0400 Received: from cavendish.fsfeurope.org ([2001:aa8:ffed::3:102]:37150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajxiz-0005ez-G7 for guix-devel@gnu.org; Sat, 26 Mar 2016 19:34:33 -0400 Received: from localhost (localhost [127.0.0.1]) by cavendish.fsfeurope.org (Postfix) with ESMTP id 3A3BA63B9E9 for ; Sun, 27 Mar 2016 00:34:32 +0100 (CET) Received: from cavendish.fsfeurope.org ([127.0.0.1]) by localhost (cavendish.fsfeurope.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kjKvFXWuPRBv for ; Sun, 27 Mar 2016 00:34:29 +0100 (CET) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: jlicht) by cavendish.fsfeurope.org (Postfix) with ESMTPSA id CF2ED63B9E5 for ; Sun, 27 Mar 2016 00:34:28 +0100 (CET) Received: by mail-lf0-f51.google.com with SMTP id f67so18870162lfb.0 for ; Sat, 26 Mar 2016 16:34:28 -0700 (PDT) In-Reply-To: <20160326232621.GA4950@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org --001a114013cece55e8052efc1e6a Content-Type: multipart/alternative; boundary=001a114013cece55e1052efc1e68 --001a114013cece55e1052efc1e68 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 2016-03-27 0:26 GMT+01:00 Leo Famulari : > On Sat, Mar 26, 2016 at 11:53:24PM +0100, Jelle Licht wrote: > > From jq's README: > > > > To get regexp support you'll also need to install Oniguruma (note that > jq's > > > tests require regexp support to pass). > > > > > > So it seems to be an optional dependency (which allows tests to pass an= d > > adds functionality). I could make it a build-time dependency, or not. > > What is the 'guix' way of handling these cases? > > In this case I think the description should be changed. > > > > > -- > > Jelle > > > > > > 2016-03-26 23:45 GMT+01:00 Leo Famulari : > > > > > On Sat, Mar 26, 2016 at 11:06:15PM +0100, Jelle Licht wrote: > > > > + (inputs > > > > + `(("oniguruma" ,oniguruma))) > > > > > > [...] > > > > > > > + (description "jq is like sed for JSON data =E2=80=93 you can u= se it to > > > slice and > > > > +filter and map and transform structured data with the same ease th= at > > > sed, awk, > > > > +grep and friends let you play with text. It is written in portabl= e > C, > > > and it > > > > +has zero runtime dependencies. jq can mangle the data format that > you > > > have > > > ^-----------------------^ > > > > > > Since oniguruma is listed as a run-time dependency, does this mean th= e > > > description is wrong? Or is oniguruma only needed to build? > > > > ^ changed --001a114013cece55e1052efc1e68 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2016-03-27 0:26 GMT+01:00 Leo Famulari <leo@famulari.name>:
On Sat, Mar 26, 2016= at 11:53:24PM +0100, Jelle Licht wrote:
> From jq's README:
>
> To get regexp support you'll also need to install Oniguruma (note = that jq's
> > tests require regexp support to pass).
>
>
> So it seems to be an optional dependency (which allows tests to pass a= nd
> adds functionality). I could make it a build-time dependency, or not.<= br> > What is the 'guix' way of handling these cases?

In this case I think the description should be changed.

>
> --
> Jelle
>
>
> 2016-03-26 23:45 GMT+01:00 Leo Famulari <leo@famulari.name>:
>
> > On Sat, Mar 26, 2016 at 11:06:15PM +0100, Jelle Licht wrote:
> > > +=C2=A0 =C2=A0 (inputs
> > > +=C2=A0 =C2=A0 =C2=A0`(("oniguruma" ,oniguruma)))<= br> > >
> > [...]
> >
> > > +=C2=A0 =C2=A0 (description "jq is like sed for JSON da= ta =E2=80=93 you can use it to
> > slice and
> > > +filter and map and transform structured data with the same = ease that
> > sed, awk,
> > > +grep and friends let you play with text.=C2=A0 It is writte= n in portable C,
> > and it
> > > +has zero runtime dependencies.=C2=A0 jq can mangle the data= format that you
> > have
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ^-----------------------^
> >
> > Since oniguruma is listed as a run-time dependency, does this mea= n the
> > description is wrong? Or is oniguruma only needed to build?
> >

^ chang= ed
--001a114013cece55e1052efc1e68-- --001a114013cece55e8052efc1e6a Content-Type: text/x-patch; charset=UTF-8; name="0002-gnu-Add-jq.patch" Content-Disposition: attachment; filename="0002-gnu-Add-jq.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_im9rw4ac0 RnJvbSA5YmM0M2U0ZWUzN2EzNWJhOGU3MjRlYWMxMDNjMzljNzJkODcwZjc1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWxsZSBMaWNodCA8amxpY2h0QGZzZmUub3JnPgpEYXRlOiBT YXQsIDI2IE1hciAyMDE2IDIyOjQ5OjQyICswMTAwClN1YmplY3Q6IFtQQVRDSCAyLzJdIGdudTog QWRkIGpxCgoqIGdudS9wYWNrYWdlcy93ZWIuc2NtOiAoanEpOiBOZXcgdmFyaWFibGUKLS0tCiBn bnUvcGFja2FnZXMvd2ViLnNjbSB8IDMzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KwogMSBmaWxlIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFj a2FnZXMvd2ViLnNjbSBiL2dudS9wYWNrYWdlcy93ZWIuc2NtCmluZGV4IDUxNmU2MjMuLjQ5ZmUx OWUgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy93ZWIuc2NtCisrKyBiL2dudS9wYWNrYWdlcy93 ZWIuc2NtCkBAIC03LDYgKzcsNyBAQAogOzs7IENvcHlyaWdodCDCqSAyMDE1IFRheWxhbiBVbHJp Y2ggQmF5xLFybMSxL0thbW1lciA8dGF5bGFuYmF5aXJsaUBnbWFpbC5jb20+CiA7OzsgQ29weXJp Z2h0IMKpIDIwMTUsIDIwMTYgRXJpYyBCYXZpZXIgPGJhdmllckBtZW1iZXIuZnNmLm9yZz4KIDs7 OyBDb3B5cmlnaHQgwqkgMjAxNSBFcmljIER2b3JzYWsgPGVyaWNAZHZvcnNhay5mcj4KKzs7OyBD b3B5cmlnaHQgwqkgMjAxNiBKZWxsZSBMaWNodCA8amxpY2h0QGZzZmUub3JnPgogOzs7CiA7Ozsg VGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTUyLDEwICs1MywxMiBAQAog ICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBweXRob24pCiAgICM6dXNlLW1vZHVsZSAoZ251 IHBhY2thZ2VzIHBjcmUpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHBrZy1jb25maWcp CisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHZhbGdyaW5kKQogICAjOnVzZS1tb2R1bGUg KGdudSBwYWNrYWdlcyB4bWwpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGN1cmwpCiAg ICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHBlcmwpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBh Y2thZ2VzIHRleGluZm8pCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHRleHR1dGlscykK ICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgdGxzKQogICAjOnVzZS1tb2R1bGUgKGdudSBw YWNrYWdlcyBzdGF0aXN0aWNzKSkKIApAQCAtMzEwOSwzICszMTEyLDMzIEBAIGNhbGxiYWNrIG9y IGNvbm5lY3Rpb24gaW50ZXJmYWNlcy4iKQogICAgICAiR3VtYm8gaXMgYW4gaW1wbGVtZW50YXRp b24gb2YgdGhlIEhUTUw1IHBhcnNpbmcgYWxnb3JpdGhtIGltcGxlbWVudGVkIGFzCiBhIHB1cmUg Qzk5IGxpYnJhcnkuIikKICAgICAobGljZW5zZSBsOmFzbDIuMCkpKQorCisoZGVmaW5lLXB1Ymxp YyBqcQorICAocGFja2FnZQorICAgIChuYW1lICJqcSIpCisgICAgKHZlcnNpb24gIjEuNSIpCisg ICAgKHNvdXJjZSAob3JpZ2luCisgICAgICAgICAgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAg ICAgICAgICAgICAodXJpIChzdHJpbmctYXBwZW5kICJodHRwczovL2dpdGh1Yi5jb20vc3RlZG9s YW4vIiBuYW1lCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIi9yZWxlYXNlcy9k b3dubG9hZC8iIG5hbWUgIi0iIHZlcnNpb24KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAiLyIgbmFtZSAiLSIgdmVyc2lvbiAiLnRhci5neiIpKQorICAgICAgICAgICAgICAoc2hh MjU2CisgICAgICAgICAgICAgICAoYmFzZTMyCisgICAgICAgICAgICAgICAgIjBnMjlreXo0eWth c2RjcmIwem1icnAyanFzOWt2MXd6OXN3eDg0OWkyZDFuY2tuYnpsbjQiKSkpKQorICAgIChpbnB1 dHMKKyAgICAgYCgoIm9uaWd1cnVtYSIgLG9uaWd1cnVtYSkpKQorICAgIChuYXRpdmUtaW5wdXRz CisgICAgIGAoOzsgVE9ETyBmaXggZ2VtcyB0byBnZW5lcmF0ZSBkb2N1bWVudGF0aW9uCisgICAg ICAgOzsoInJ1YnkiICxydWJ5KQorICAgICAgIDs7KCJidW5kbGVyIiAsYnVuZGxlcikKKyAgICAg ICAoInZhbGdyaW5kIiAsdmFsZ3JpbmQpKSkKKyAgICAoYnVpbGQtc3lzdGVtIGdudS1idWlsZC1z eXN0ZW0pCisgICAgKGhvbWUtcGFnZSAiaHR0cDovL3N0ZWRvbGFuLmdpdGh1Yi5pby9qcS8iKQor ICAgIChzeW5vcHNpcyAiQ29tbWFuZC1saW5lIEpTT04gcHJvY2Vzc29yIikKKyAgICAoZGVzY3Jp cHRpb24gImpxIGlzIGxpa2Ugc2VkIGZvciBKU09OIGRhdGEg4oCTIHlvdSBjYW4gdXNlIGl0IHRv IHNsaWNlIGFuZAorZmlsdGVyIGFuZCBtYXAgYW5kIHRyYW5zZm9ybSBzdHJ1Y3R1cmVkIGRhdGEg d2l0aCB0aGUgc2FtZSBlYXNlIHRoYXQgc2VkLCBhd2ssCitncmVwIGFuZCBmcmllbmRzIGxldCB5 b3UgcGxheSB3aXRoIHRleHQuICBJdCBpcyB3cml0dGVuIGluIHBvcnRhYmxlIEMuICBqcSBhbmQK K2NhbiBtYW5nbGUgdGhlIGRhdGEgZm9ybWF0IHRoYXQgeW91IGhhdmUgaW50byB0aGUgb25lIHRo YXQgeW91IHdhbnQgd2l0aCB2ZXJ5CitsaXR0bGUgZWZmb3J0LCBhbmQgdGhlIHByb2dyYW0gdG8g ZG8gc28gaXMgb2Z0ZW4gc2hvcnRlciBhbmQgc2ltcGxlciB0aGFuCit5b3XigJlkIGV4cGVjdC4i KQorICAgIChsaWNlbnNlIChsaXN0IGw6ZXhwYXQgbDpjYy1ieTMuMCkpKSkKLS0gCjIuNy4zCgo= --001a114013cece55e8052efc1e6a--