From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jelle Licht Subject: bug#27257: python-apsw bundles a version of SQLite Date: Mon, 11 Sep 2017 01:50:28 +0200 Message-ID: References: <20170605192724.51a810de@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a1144f6789707fe0558de79ec" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drC0I-0006if-7D for bug-guix@gnu.org; Sun, 10 Sep 2017 19:51:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drC0E-0008Qf-8u for bug-guix@gnu.org; Sun, 10 Sep 2017 19:51:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51301) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drC0E-0008QX-50 for bug-guix@gnu.org; Sun, 10 Sep 2017 19:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1drC0D-0005Op-RT for bug-guix@gnu.org; Sun, 10 Sep 2017 19:51:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20170605192724.51a810de@scratchpost.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Danny Milosavljevic Cc: 27257@debbugs.gnu.org --001a1144f6789707fe0558de79ec Content-Type: text/plain; charset="UTF-8" 2017-06-05 19:27 GMT+02:00 Danny Milosavljevic : > Hi Jelle, > > On Mon, 5 Jun 2017 18:32:10 +0200 > Jelle Licht wrote: > > > Some possible directions on resolving this issue: > > - Debug the multiple thousand lines of test code to see exactly where/how > > the test fails when using the system SQLite library > > - Package the right version of the SQLite amalgation [1] that is now > > bundled, although the amalgation should be functionally equivalent to the > > normal SQLite version. > > I see that apsw bundles SQLite 3.9.2. Does it work when you replace it > with the external version 3.9.2 - amalgation or not ? > Getting version 3.9.2 to build turned out to be a bit of a hassle; some nonsense about a fossil(?) generated manifest missing or what not. > > I don't necessarily mean permanently - just to find out whether the tests > work normally then. > > Also, Perhaps diff the bundled SQLite 3.9.2 and the released SQLite 3.9.2 > amalgation of the same version ? > A diff between bundled SQLite 3.9.2 and release 3.9.2. amalgation reveals no (functional) differences, so at least there will be no extra set of patches to maintain. > [...] > It seems that the actual upstream for apsw at [1] has continued development since we packaged it. Incidentally, our sqlite package is a bit outdated. If I update sqlite to the latest version (3.20.1), as well as change the python-apsw upstream to [1], the package seems to build and pass the `check' phase with no issues. [1] : https://github.com/rogerbinns/apsw --001a1144f6789707fe0558de79ec Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


2017-06-05 19:27 GMT+02:00 Danny Milosavljevic <dannym@scratchpos= t.org>:
= Hi Jelle,

On Mon, 5 Jun 2017 18:32:10 +0200
Jelle Licht <jlicht= @fsfe.org> wrote:

> Some possible directions on resolving this issue:
> - Debug the multiple thousand lines of test code to see exactly where/= how
> the test fails when using the system SQLite library
> - Package the right version of the SQLite amalgation [1] that is now > bundled, although the amalgation should be functionally equivalent to = the
> normal SQLite version.

I see that apsw bundles SQLite 3.9.2.=C2=A0 Does it work when you re= place it with the external version 3.9.2 - amalgation or not ?
Getting version 3.9.2 to build turned out to be a bit of a hassle;= some nonsense about a fossil(?) generated manifest missing or what not.

I don't necessarily mean permanently - just to find out whether the tes= ts work normally then.

Also, Perhaps diff the bundled SQLite 3.9.2 and the released SQLite 3.9.2 a= malgation of the same version ?
A diff between bundled= SQLite 3.9.2 and release 3.9.2. amalgation reveals no (functional) differe= nces, so at least there will be no extra set of patches to maintain.
[...]

It seems that the actual upstream for = apsw at [1] has continued development since we packaged it.
Incidentally, our sqlite package is a bit outdated. If I u= pdate sqlite to the latest version (3.20.1), as well as change the python-a= psw upstream to [1], the package seems to build and pass the `check' ph= ase with no issues.

[1] : https://= github.com/rogerbinns/apsw
--001a1144f6789707fe0558de79ec--