all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jelle Licht <jlicht@fsfe.org>
To: 27852@debbugs.gnu.org
Subject: [bug#27852] [PATCH] gnu: node: Update to 8.2.1.
Date: Thu, 27 Jul 2017 17:33:05 +0200	[thread overview]
Message-ID: <CAPsKtfJGB058Gz6vYwVnS_kW11bE36=rL_rGhwfdmGK-wq2kfg@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 395 bytes --]

It seems the node devs do not expect packagers to run `make check':
https://github.com/nodejs/node/issues/14513

Anyway, attached you will find a patch which updates node to its latest
released version while still allowing use to run most of the included test
suite.

At some point in time someone could look into getting node to build
reproducibly. Who knows, it might even be me ;-).

- Jelle

[-- Attachment #1.2: Type: text/html, Size: 548 bytes --]

[-- Attachment #2: 0001-gnu-node-Update-to-8.2.1.patch --]
[-- Type: text/x-patch, Size: 1770 bytes --]

From f88297638a82858dff61176f646cdc4ddca748cf Mon Sep 17 00:00:00 2001
From: Jelle Licht <jlicht@fsfe.org>
Date: Thu, 27 Jul 2017 17:11:08 +0200
Subject: [PATCH] gnu: node: Update to 8.2.1.

* gnu/packages/node.scm (node): Update to 8.2.1.
(node)[arguments]: Removed broken linter test.
---
 gnu/packages/node.scm | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 2cebabbca..4892bc9f0 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -40,14 +40,14 @@
 (define-public node
   (package
     (name "node")
-    (version "8.1.2")
+    (version "8.2.1")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://nodejs.org/dist/v" version
                                   "/node-v" version ".tar.gz"))
               (sha256
                (base32
-                "0l92gar1pivzaiwffiiiz2f2m5k39sl5fphlfnvy0ml9hrjb65yp"))
+                "0gwp65mls420x64jk3bkx7xdq75zjnv5mi5mqqb9mbvxpiwi7zk6"))
               ;; https://github.com/nodejs/node/pull/9077
               (patches (search-patches "node-9077.patch"))))
     (build-system gnu-build-system)
@@ -78,10 +78,9 @@
                (("'/usr/bin/env'")
                 (string-append "'" (which "env") "'")))
 
-             ;; Having the build fail because of linter errors is insane!
+             ;; Linting is no longer supported in the release tarball
              (substitute* '("Makefile")
-               (("	\\$\\(MAKE\\) jslint") "")
-               (("	\\$\\(MAKE\\) cpplint\n") ""))
+               (("	\\$\\(MAKE\\) lint") ""))
 
              ;; FIXME: This test seems to depends on files that are not
              ;; available in the bundled v8. See
-- 
2.13.3


             reply	other threads:[~2017-07-27 15:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27 15:33 Jelle Licht [this message]
2017-07-28 19:40 ` [bug#27852] [PATCH] gnu: node: Update to 8.2.1 Ludovic Courtès
2017-09-01 22:20   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPsKtfJGB058Gz6vYwVnS_kW11bE36=rL_rGhwfdmGK-wq2kfg@mail.gmail.com' \
    --to=jlicht@fsfe.org \
    --cc=27852@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.