From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDDZQ-0007hD-5J for guix-patches@gnu.org; Tue, 23 May 2017 13:26:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDDZK-0007HS-HD for guix-patches@gnu.org; Tue, 23 May 2017 13:26:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:60563) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dDDZK-0007HK-Di for guix-patches@gnu.org; Tue, 23 May 2017 13:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dDDZK-0007QG-4Z for guix-patches@gnu.org; Tue, 23 May 2017 13:26:02 -0400 Subject: bug#27021: [PATCH 2/2] gnu: node: Use unbundled dependencies. Resent-Message-ID: MIME-Version: 1.0 In-Reply-To: <87a863y1px.fsf@fastmail.com> References: <20170522180321.20388-1-jlicht@fsfe.org> <20170522180321.20388-2-jlicht@fsfe.org> <87a863y1px.fsf@fastmail.com> From: Jelle Licht Date: Tue, 23 May 2017 19:25:46 +0200 Message-ID: Content-Type: multipart/alternative; boundary="001a11464426384aa305503447a1" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 27021-done@debbugs.gnu.org --001a11464426384aa305503447a1 Content-Type: text/plain; charset="UTF-8" No problem, I use this stuff quite often. I noticed the problem with the bundled copies in the source as well, but ran into the same issues you mention here. Maybe I will look into it when the next node version is released. 2017-05-23 18:31 GMT+02:00 Marius Bakke : > Jelle Licht writes: > > > * gnu/packages/node.scm (node): Update to 7.10.0. > > (node)[arguments]: Disabled more tests. > > * gnu/packages/patches/node-9077.patch: Delete incompatible patch file. > > Recreate patch file from node pull request 9077. > > [...] > > > * gnu/packages/node.scm (node)[inputs]: Add c-ares and http-parser. > > [arguments]: Add configure flags for using system libraries. > > Thanks for these patches! I updated the TODO comment about http-parser > to say "TODO: Purge the bundled copies from the source". I tried to do > that with a source 'snippet', but the Makefile expects to build these > targets, so it will take some work. Would you mind looking into it? :-) > > Regardless, I've applied these patches for now. Thanks for maintaining > this package! :-) > --001a11464426384aa305503447a1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
No problem, I use this stuff quite often.
I noticed the problem with the bundled copies in the source as well, but= ran into the same issues you mention here.
Maybe I will look into= it when the next node version is released.

2017-05-23 18:31 GMT= +02:00 Marius Bakke <mbakke@fastmail.com>:
Jelle Licht <jlich= t@fsfe.org> writes:

> * gnu/packages/node.scm (node): Update to 7.10.0.
> (node)[arguments]: Disabled more tests.
> * gnu/packages/patches/node-9077.patch: Delete incompatible patch= file.
> Recreate patch file from node pull request 9077.

[...]

> * gnu/packages/node.scm (node)[inputs]: Add c-ares and http-parser. > [arguments]: Add configure flags for using system libraries.

Thanks for these patches! I updated the TODO comment about http-parser
to say "TODO: Purge the bundled copies from the source". I tried = to do
that with a source 'snippet', but the Makefile expects to build the= se
targets, so it will take some work. Would you mind looking into it? :-)

Regardless, I've applied these patches for now. Thanks for maintaining<= br> this package! :-)

--001a11464426384aa305503447a1--