On Sat, 20 Oct 2018, 18:35 Ricardo Wurmus, <ricardo.wurmus@mdc-berlin.de>
wrote:

>
> Hi Laura,
>
> > I will apply all the changes and send the new version.
> > Shall I send the modified patch to the debbugs mail that is in the CC of
> > this mail?
>
> Yes, please.
>
> >> > > > > +    (synopsis "Analysis of Symmetry of Parasitic Infections")
> >> > > >
> >> > > > Please use lowercase for all words except for the first.  CRAN
> >> synopses
> >> > > > are usually in titlecase and the importer can’t automatically
> figure
> >> out
> >> > > > which words should be converted, so this needs to be done
> manually.
> >>
> > Sorry for this, I just copied the comments in cran's website, I'll change
> > that.
>
> Did you not use the CRAN importer to generate this package definition?
> If you did not then you’re in for a treat as “guix import cran -r” can
> *recursively* generate package definitions for packages on CRAN, even if
> there are dozens of dependencies.
>
I guess this was my mistake. I did not understand that before. I just used
guix import  cran  <rpackage> for the templates and appended my package
with guix edit :/. I will send that fixed.

>
> >> > > > > +    (license license:gpl3)))
> >> > > >
> >> > > > I checked the source files and noticed that it’s actually GPL 3 or
> >> > > > later.  Here’s an except from the header of aspi.R:
> >>
> > I guess this mistake was because in one of the several times of running
> > ./pre-inst-env guix build r-aspi I was getting an error about the gpl
> > licence. I will change this too.
>
> If you used the importer this is not your fault.  On CRAN the license is
> listed as “GPL-3” which the importer turns into “gpl3”.  Often people
> declare the license as just a single version even though their own
> license headers permit later versions.
>
> PS: please try to reduce the amount of text you quote in replies.  It’s
> best to only leave the relevant parts that you’re replying to :)
>
> --
> Ricardo
>