From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEirq-0006MC-0G for guix-patches@gnu.org; Mon, 22 Oct 2018 18:40:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gEij0-0003Na-Lx for guix-patches@gnu.org; Mon, 22 Oct 2018 18:31:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:60486) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gEij0-0003NO-Go for guix-patches@gnu.org; Mon, 22 Oct 2018 18:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gEij0-0005hJ-8Y for guix-patches@gnu.org; Mon, 22 Oct 2018 18:31:02 -0400 Subject: [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file Resent-Message-ID: MIME-Version: 1.0 References: <8736t12frf.fsf@mdc-berlin.de> <87zhv81etw.fsf@mdc-berlin.de> In-Reply-To: From: Laura Lazzati Date: Mon, 22 Oct 2018 19:29:41 -0300 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?G=C3=A1bor?= Boskovits Cc: Ricardo Wurmus , 33099@debbugs.gnu.org On Mon, Oct 22, 2018 at 10:39 AM G=C3=A1bor Boskovits = wrote: > > Hi Laura, > > Laura Lazzati ezt =C3=ADrta (id=C5=91pont: 2= 018. > okt. 22., H, 14:59): > > > > On Mon, 22 Oct 2018, 05:47 G=C3=A1bor Boskovits, = wrote: > > > > > > Hello Laura, > > > > > > Almost there! > > > > Yes, after trying lots of things I figured out why it took me so long > > to package it. The short story is that I did not understand that guix > > import cran -r aspi was creating the template for me, I thought it > > worked only for packages that were already packeged.I applied it to > > another r package already available in guix, and modified it with > > information about aspi from its website. The good side is that I > > learned tons of guix commands. > > > > > > > > > Laura Lazzati ezt =C3=ADrta (id=C5=91pon= t: 2018. > > > okt. 21., V, 23:54): > > > > > > > > From 3628e4d7d4814777bb748c3f0ebba133814b2b94 Mon Sep 17 00:00:00 2= 001 > > > > From: laura > > > > Date: Sun, 21 Oct 2018 18:38:58 -0300 > > > > Subject: [PATCH] gnu: Add r-aspi > > > > > > > > * gnu/packages/cran.scm (r-aspi): New variable > > > > --- > > > > gnu/packages/cran.scm | 21 +++++++++++++++++++++ > > > > 1 file changed, 21 insertions(+) > > > > > > > > > > Just a bit knitpicking, could you add the periods to the commit messa= ge, like: > > > > > > gnu: Add r-aspi. > > > > > > * gnu/packages/patches/cran.scm (r-aspi): New variable. > > > > > > > > > > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm > > > > index efcc2dccb..c219065e8 100644 > > > > --- a/gnu/packages/cran.scm > > > > +++ b/gnu/packages/cran.scm > > > > @@ -6256,3 +6256,24 @@ a header row or not. The dataset should > > > > contain only one independent variable > > > > (x) and one dependent variable (y) and can contain a weight for ea= ch > > > > observation.") > > > > (license license:gpl2))) > > > > + > > > > +(define-public r-aspi > > > > + (package > > > > + (name "r-aspi") > > > > + (version "0.2.0") > > > > + (source > > > > + (origin > > > > + (method url-fetch) > > > > + (uri (cran-uri "aspi" version)) > > > > + (sha256 > > > > + (base32 > > > > + "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"= )))) > > > > + (build-system r-build-system) > > > > + (home-page > > > > + "http://cran.r-project.org/web/packages/aspi") > > > > + (synopsis > > > > + "Analysis of symmetry of parasitic infections") > > > > + (description > > > > + "This package provides tools for the analysis and visualizat= ion > > > > of bilateral > > > > + asymmetry in parasitic infections.") > > > > + (license license:gpl3+))) > > > > -- > > > > 2.17.1 > > > > > > > > > > This is fine now. > > > > > > I still see these strange line breaks in the patch, how does that loo= k on > > > you side? > > > > I guess the problem was that I was adding a line break because in the > > previous patch when building I had a complain that that line was too > > long. I have just told emacs to truncate long lines and buld the > > package without problems. My fault. It was one of the two changes that > > I made from the original definiton. Adding that break line and adding > > licence: before gpl3+ because otherwhise I got the error: Unbound > > variable: gpl3+. > > > > > > > > > Can you apply you own patches using git am? > > In my local repo? > > > > > > You can send an updated patch with the corrected commit message, > > > or I can apply these minor changes and push it. > > > WDYT? I have already changed the commit messages. I have generated several times the new patch, went back and so forth. I can't figure out what is wrong. I tried applying the different patches I went on generating with git am .patch I tend to get this error: error: patch failed: gnu/packages/cran.scm:6256 And when I take a look at cran.scm, that line belongs to the previous package (the one before appending mines) I read in the coding style that lines must not exceed 80 columns, but when I open cran.scm there are several packages that do so. And if I don't add an eol in the description (is it there where you see the line break?), after running lint command I get: /home/laura/guix/gnu/packages/cran.scm:6261:2: r-aspi@0.2.0: line 6276 is way too long (119 characters) Any ideas of how to help me fix this? > > If it is not a problem for you, let me try :) > > Do you mean by changing the subject of this chain of messages? > > Yes, that would do half the job. > > There is also a missing period in this line: > * gnu/packages/cran.scm (r-aspi): New variable > > You can either fix these up manually, or using > git commit --amend, and fix these in the commit message. > That way git format-patch will fix these up. > > > Is that > > OK for sending the patch with the corrections, but keeping the > > debugs.gnu.org mail with the number as it is in the To field? > > Yes that is fine. > > > > > > > Best regards, > > > g_bor > > > > Regards :) > > Laura > > Best regards, > g_bor Regards! Laura