From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDxsu-0005ka-48 for guix-patches@gnu.org; Sat, 20 Oct 2018 16:30:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDxsp-000208-Cg for guix-patches@gnu.org; Sat, 20 Oct 2018 16:30:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57469) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gDxsp-000202-6L for guix-patches@gnu.org; Sat, 20 Oct 2018 16:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gDxso-00057Y-SR for guix-patches@gnu.org; Sat, 20 Oct 2018 16:30:02 -0400 Subject: [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file Resent-Message-ID: MIME-Version: 1.0 References: <8736t12frf.fsf@mdc-berlin.de> In-Reply-To: From: Laura Lazzati Date: Sat, 20 Oct 2018 17:28:59 -0300 Message-ID: Content-Type: multipart/alternative; boundary="000000000000ea742f0578aee0b2" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?G=C3=A1bor?= Boskovits Cc: Ricardo Wurmus , 33099@debbugs.gnu.org --000000000000ea742f0578aee0b2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you all for the feedback :) I will apply all the changes and send the new version. Shall I send the modified patch to the debbugs mail that is in the CC of this mail? On Sat, Oct 20, 2018 at 8:48 AM G=C3=A1bor Boskovits = wrote: > Hello guix, > > G=C3=A1bor Boskovits ezt =C3=ADrta (id=C5=91pont: 2= 018. okt. > 20., Szo, 13:05): > > > > Hello Laura, > > > > G=C3=A1bor Boskovits ezt =C3=ADrta (id=C5=91pont:= 2018. okt. > > 20., Szo, 10:43): > > > > > > Hello Laura, > > > > > > Ricardo Wurmus ezt =C3=ADrta (id=C5=91= pont: 2018. > > > okt. 20., Szo, 10:17): > > > > > > > > > > > > Hi Laura, > > > > > > > > congratulations on your first patch to Guix! > > > > > > > > What follows are a few comments on minor changes that I would like = to > > > > see before applying the patch to Guix. > > > > > > > > > From 132c8bf1e57f30485e3701ce01ea9d1ac7207e7c Mon Sep 17 00:00:00 > 2001 > > > > > From: laura > > > > > Date: Fri, 19 Oct 2018 19:15:37 -0300 > > > > > Subject: [PATCH] I add r-aspi package appended to cran.scm file > > > > > > > > > > --- > > > > > gnu/packages/cran.scm | 19 +++++++++++++++++++ > > > > > 1 file changed, 19 insertions(+) > > > > > > > > For commits to Guix, we use a somewhat strict commit message format= . > > > > You can take a look at the commit log to get a feel for it. In the > case > > > > of adding r-aspi to cran.scm this would be the expected commit > message: > > > > > > > > --8<---------------cut here---------------start------------->8--- > > > > gnu: Add r-aspi. > > > > > > > > * gnu/packages/cran.scm (r-aspi): New variable. > > > > --8<---------------cut here---------------end--------------->8--- > > > > > > > > The first line is always a concise summary. This is followed by a > > > > change log listing modified files and how they were modified. > > > > > > > > > > You can also see git log for examples. > > > > > > > > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm > > > > > index efcc2dccb..0d8ee6a97 100644 > > > > > --- a/gnu/packages/cran.scm > > > > > +++ b/gnu/packages/cran.scm > > > > > @@ -6256,3 +6256,22 @@ a header row or not. The dataset should > contain > > > > > only one independent variable > > > > > (x) and one dependent variable (y) and can contain a weight for > each > > > > > observation.") > > > > > (license license:gpl2))) > > > > > + > > > > > +(define-public r-aspi > > > > > + (package > > > > > + (name "r-aspi") > > > > > + (version "0.2.0") > > > > > + (source > > > > > + (origin > > > > > + (method url-fetch) > > > > > + (uri (cran-uri "aspi" version)) > > > > > + (sha256 > > > > > + (base32 > > > > > + > "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87")))) > > > > > + (build-system r-build-system) > > > > > + (home-page "https://cran.r-project.org/web/packages/aspi/") > > > > > + (synopsis "Analysis of Symmetry of Parasitic Infections") > > > > > > > > Please use lowercase for all words except for the first. CRAN > synopses > > > > are usually in titlecase and the importer can=E2=80=99t automatical= ly figure > out > > > > which words should be converted, so this needs to be done manually. > Sorry for this, I just copied the comments in cran's website, I'll change that. > > > > > > > > > + (description > > > > > + "Tools for the analysis and visualization of bilateral > asymmetry in > > > > > + parasitic infections.") > > > > > > > > Please use a complete sentence for the description. The easiest wa= y > is > > > > probably to just prepend =E2=80=9CThis package provides=E2=80=9D. > > > > > > > > > + (license license:gpl3))) > > > > > > > > I checked the source files and noticed that it=E2=80=99s actually G= PL 3 or > > > > later. Here=E2=80=99s an except from the header of aspi.R: > I guess this mistake was because in one of the several times of running ./pre-inst-env guix build r-aspi I was getting an error about the gpl licence. I will change this too. > > > > > > > > --8<---------------cut here---------------start------------->8--- > > > > # Analysis of Symmetry of Parasitic Infections is free software: > you can # > > > > # redistribute it and/or modify it under the terms of the GNU > General Public # > > > > # License as published by the Free Software Foundation, either > version 3 of # > > > > # the License, or (at your option) any later version. > # > > > > --8<---------------cut here---------------end--------------->8--- > > > > > > > > So this really should be =E2=80=9Clicense:gpl3+=E2=80=9D. > > > > > > > > (I haven=E2=80=99t tried building the package yet.) > > > > > > > > > > I will try this and report back. > > > > > > > It builds for me fine, so with the suggestions Ricardo mentioned I thin= k > > it is good to go. > > > > > > I think it=E2=80=99s fine to apply the patch with these minor chang= es. > > > > > > > > -- > > > > Ricardo > > > > I had problem with applying this directly with git am, it > > kept telling me the patch is corrupt on line 10. > > Can someone have a look? > > > > My bad, but it seems that at least partially debbugs is responsible for > this, > It broke the long line in the patch, and it simply wrapped it around. I > downloaded the message from there using mbox. As there was no space > before the start of the line, the patch became corrupted. > Do you think this is bug? > I believe debbugs should not alter line endings. > > > > > > > Thanks Ricardo for the fast review! > > > > > > Best regards, > > > g_bor > > > > Best regards, > > g_bor > Best regards, > g_bor > Regards! Laura --000000000000ea742f0578aee0b2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you all for the feedback :)
I will apply all the changes and send the new version.
Shall I send the modified patch to the debbugs mail that is in the CC= of this mail?

On = Sat, Oct 20, 2018 at 8:48 AM G=C3=A1bor Boskovits <boskovits@gmail.com> wrote:
<= /div>
Hello guix,

G=C3=A1bor Boskovits <boskovits@gmail.com> ezt =C3=ADrta (id=C5=91pont: 2018. okt.<= br> 20., Szo, 13:05):
>
> Hello Laura,
>
> G=C3=A1bor Boskovits <boskovits@gmail.com> ezt =C3=ADrta (id=C5=91pont: 2018. = okt.
> 20., Szo, 10:43):
> >
> > Hello Laura,
> >
> > Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> ezt =C3=ADrta (id= =C5=91pont: 2018.
> > okt. 20., Szo, 10:17):
> > >
> > >
> > > Hi Laura,
> > >
> > > congratulations on your first patch to Guix!
> > >
> > > What follows are a few comments on minor changes that I woul= d like to
> > > see before applying the patch to Guix.
> > >
> > > > From 132c8bf1e57f30485e3701ce01ea9d1ac7207e7c Mon Sep 1= 7 00:00:00 2001
> > > > From: laura <laura.lazzati.15@gmail.com>
> > > > Date: Fri, 19 Oct 2018 19:15:37 -0300
> > > > Subject: [PATCH] I add r-aspi package appended to cran.= scm file
> > > >
> > > > ---
> > > >=C2=A0 gnu/packages/cran.scm | 19 +++++++++++++++++++ > > > >=C2=A0 1 file changed, 19 insertions(+)
> > >
> > > For commits to Guix, we use a somewhat strict commit message= format.
> > > You can take a look at the commit log to get a feel for it.= =C2=A0 In the case
> > > of adding r-aspi to cran.scm this would be the expected comm= it message:
> > >
> > > --8<---------------cut here---------------start----------= --->8---
> > > gnu: Add r-aspi.
> > >
> > > * gnu/packages/cran.scm (r-aspi): New variable.
> > > --8<---------------cut here---------------end------------= --->8---
> > >
> > > The first line is always a concise summary.=C2=A0 This is fo= llowed by a
> > > change log listing modified files and how they were modified= .
> > >
> >
> > You can also see git log for examples.
> >
> > > > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.= scm
> > > > index efcc2dccb..0d8ee6a97 100644
> > > > --- a/gnu/packages/cran.scm
> > > > +++ b/gnu/packages/cran.scm
> > > > @@ -6256,3 +6256,22 @@ a header row or not.=C2=A0 The d= ataset should contain
> > > > only one independent variable
> > > >=C2=A0 (x) and one dependent variable (y) and can contai= n a weight for each
> > > >=C2=A0 observation.")
> > > >=C2=A0 =C2=A0 =C2=A0 (license license:gpl2)))
> > > > +
> > > > +(define-public r-aspi
> > > > +=C2=A0 (package
> > > > +=C2=A0 =C2=A0 (name "r-aspi")
> > > > +=C2=A0 =C2=A0 (version "0.2.0")
> > > > +=C2=A0 =C2=A0 (source
> > > > +=C2=A0 =C2=A0 =C2=A0(origin
> > > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0(method url-fetch)
> > > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (cran-uri "aspi&q= uot; version))
> > > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
> > > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32
> > > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"0rhvxw243vvdv3= hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
> > > > +=C2=A0 =C2=A0 (build-system r-build-system)
> > > > +=C2=A0 =C2=A0 (home-page "htt= ps://cran.r-project.org/web/packages/aspi/")
> > > > +=C2=A0 =C2=A0 (synopsis "Analysis of Symmetry of = Parasitic Infections")
> > >
> > > Please use lowercase for all words except for the first.=C2= =A0 CRAN synopses
> > > are usually in titlecase and the importer can=E2=80=99t auto= matically figure out
> > > which words should be converted, so this needs to be done ma= nually.
Sorry for this, I just copied the comments in = cran's website, I'll change that.=C2=A0
> > >
> > > > +=C2=A0 =C2=A0 (description
> > > > +=C2=A0 =C2=A0 =C2=A0"Tools for the analysis and v= isualization of bilateral asymmetry in
> > > > + parasitic infections.")
> > >
> > > Please use a complete sentence for the description.=C2=A0 Th= e easiest way is
> > > probably to just prepend =E2=80=9CThis package provides=E2= =80=9D.
> > >
> > > > +=C2=A0 =C2=A0 (license license:gpl3)))
> > >
> > > I checked the source files and noticed that it=E2=80=99s act= ually GPL 3 or
> > > later.=C2=A0 Here=E2=80=99s an except from the header of asp= i.R:
I guess this mistake was because in one of the se= veral times of running ./pre-inst-env guix build r-aspi I was getting an er= ror about the gpl licence. I will change this too.
> > >
> > > --8<---------------cut here---------------start----------= --->8---
> > > #=C2=A0 Analysis of Symmetry of Parasitic Infections is free= software: you can=C2=A0 =C2=A0 =C2=A0 =C2=A0 #
> > > #=C2=A0 redistribute it and/or modify it under the terms of = the GNU General Public=C2=A0 =C2=A0 #
> > > #=C2=A0 License as published by the Free Software Foundation= , either version 3 of=C2=A0 =C2=A0 =C2=A0#
> > > #=C2=A0 the License, or (at your option) any later version.= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0#
> > > --8<---------------cut here---------------end------------= --->8---
> > >
> > > So this really should be =E2=80=9Clicense:gpl3+=E2=80=9D. > > >
> > > (I haven=E2=80=99t tried building the package yet.)
> > >
> >
> > I will try this and report back.
> >
>
> It builds for me fine, so with the suggestions Ricardo mentioned I thi= nk
> it is good to go.
>
> > > I think it=E2=80=99s fine to apply the patch with these mino= r changes.
> > >
> > > --
> > > Ricardo
>
> I had problem with applying this directly with git am, it
> kept telling me the patch is corrupt on line 10.
> Can someone have a look?
>

My bad, but it seems that at least partially debbugs is responsible for thi= s,
It broke the long line in the patch, and it simply wrapped it around. I
downloaded the message from there using mbox. As there was no space
before the start of the line, the patch became corrupted.
Do you think this is bug?
I believe debbugs should not alter line endings.

> >
> > Thanks Ricardo for the fast review!
> >
> > Best regards,
> > g_bor
>
> Best regards,
> g_bor
Best regards,
g_bor
Regards!
Laura
=C2=A0
--000000000000ea742f0578aee0b2--