hi leo, thanks for your review, i sent the series patch in a tar archive(see attached file) to avoid duplicate . the only patch i change other than update version is : atril 0018-gnu-atril-Update-to-1.20.3.patch review this one i don't know if do thing well. Le ven. 15 mars 2019 à 18:12, Leo Famulari a écrit : > On Mon, Mar 04, 2019 at 12:18:47PM +0100, guy fleury iteriteka wrote: > > --- > > gnu/packages/mate.scm | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm > > index ef94491..57a3ced 100644 > > --- a/gnu/packages/mate.scm > > +++ b/gnu/packages/mate.scm > > @@ -73,7 +73,7 @@ > > (define-public mate-common > > (package > > (name "mate-common") > > - (version "1.18.0") > > + (version "1.20.0") > > Thank you for these patches! > > I noticed that the commit messages are not complete, however. They are > missing the section that describes the changes made in each file. > > For a patch like this, that simply updates the package with no other > changes, you'd write the commit message like this: > > ------ > gnu: mate-common: Update to 1.20.0. > > * gnu/packages/mate.scm (mate-common): Update to 1.20.0. > ------ > > If there are other changes, they should be described as well. > > I recommend looking at our Git history for examples, or asking here on > or IRC if you need help. Can you send an updated patch series? > > Normally, I would fix this sort of issue myself before pushing the > patch, but there are too many patches in this case for me to do it. > > By the way, this style of commit logs is called the 'GNU Change Log' > style and is documented here: > > https://www.gnu.org/prep/standards/html_node/Change-Logs.html > -----BEGIN PGP SIGNATURE----- > > iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlyL3OUACgkQJkb6MLrK > fwj1pBAAhyLxi0EFxJS4OSPmhr8mhaoP/R9q3gj2w4GDAvGaHplmK9mrs9k31p2p > 0tFjzqzsnq5T8QdGgDCwpQAx37l/IUU7U7EqFaVOkGtNA1sStF6Tot5mSXqFye3C > zcAc1CAPD7GB69FFK9Tdwd1FuPglmhu3+Cf+SpMqnaG58V8Tdz1xKYn0Xa6sA7SX > mSEFHzmUZYCvQURxvDHUkABEx1LqHHTFgnANvrFQP81nI8jR1zg5G7w5MNIEL6H7 > zGSgnktTCd3W+LPHUL1adHItMfrNfGpvFXONnukiSatYygp5KIm4iQkAtDBaTei+ > u3nbfIyFCgX4g3zEuPMjm0UDKb0Q1yU4FX0ahYF1oQ58CT5wxobifgqnnWYY/b7s > 6bBkzFjqUWjL8zwAlIICgmVW+sSzv63r7Izy96pw0VIrA803gwS4gurcImErxPaJ > R9ImaYCveQjWPFrkY8gKSmXCvhThaVoiBlwEnPjHjRTHtUk4wDK/AfD6M+vTt067 > JxahlnJ8z2mwf5EUBYI4yZNCZ+YcKHf83AU28/+4LDhcOihkB1qzqRxZjtJZlezD > gtWml2ElNubeTNkcT4q8UBilTmQUTgGKz/UEzVAAooR54wvOfzYniWTGxYfnYy4u > iCa/3zH9R6jJZJ+4nAS3TI1tZfOu4NhALNznocv8A0YmgN+Toag= > =CeZG > -----END PGP SIGNATURE----- >