From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YDwiFNVrfGFWwAAAgWs5BA (envelope-from ) for ; Fri, 29 Oct 2021 23:47:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UKPPD9VrfGFVMwAA1q6Kng (envelope-from ) for ; Fri, 29 Oct 2021 21:47:01 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E8DCF360EF for ; Fri, 29 Oct 2021 23:47:00 +0200 (CEST) Received: from localhost ([::1]:41604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgZiG-0008EP-1W for larch@yhetil.org; Fri, 29 Oct 2021 17:47:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgZYc-0004OG-Ix for guix-patches@gnu.org; Fri, 29 Oct 2021 17:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgZYc-0004Rj-7M for guix-patches@gnu.org; Fri, 29 Oct 2021 17:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mgZYc-0006GR-4t for guix-patches@gnu.org; Fri, 29 Oct 2021 17:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48046] [PATCH]: Gnu add astropy Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 Oct 2021 21:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48046 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48046@debbugs.gnu.org Cc: Vinicius Monego Received: via spool by 48046-submit@debbugs.gnu.org id=B48046.163554337424012 (code B ref 48046); Fri, 29 Oct 2021 21:37:02 +0000 Received: (at 48046) by debbugs.gnu.org; 29 Oct 2021 21:36:14 +0000 Received: from localhost ([127.0.0.1]:56161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgZXq-0006FE-4v for submit@debbugs.gnu.org; Fri, 29 Oct 2021 17:36:14 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:33423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgZXj-0006EM-VP for 48046@debbugs.gnu.org; Fri, 29 Oct 2021 17:36:09 -0400 Received: by mail-wr1-f42.google.com with SMTP id m22so18803990wrb.0 for <48046@debbugs.gnu.org>; Fri, 29 Oct 2021 14:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9YqvCZa2+AzyVly8fNmC+zqdDZdsMwzvg8ojc+7/wno=; b=l73d+8K88ltrXqGfpu//pYmCqta5yZ+XakODD6oyE0HmyJuLhWXTYxEc/hPWkaZNFy CIiuUChP/DPZKZUJd4bpw9PTa8O4kIcwCFNEf9tlR3oQxv6UY51CczNT78GoEGIDubb1 HbdVoU57XPjXNwMyEiU5BJGNMhhzH8uZa5izngxEcCCMR34PbdUrSgzdnjSeuEamhOTP NE4boYEF0mI5VCmcaiFWlLYnGY8zBp2sC3tBKs/jkMW7OLgQLJ0+eg+0HSqxYTraUU5S xMvqWwM9Hkq/XsXpbMB/VnJv9hV4EcysxTUuzswUZoHof5aatLciG4GZlm3YDAP62QnF 5VkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9YqvCZa2+AzyVly8fNmC+zqdDZdsMwzvg8ojc+7/wno=; b=Ma30/JlmMJDP3oi23VERmxiK2hNb4Hq3Yz7+8TlWXWhz1vMVApYBFUV3WmDQtyxmVB KO+H6NGbSOAC2J6yQZW2o5zZTPYhmJOqRVAlCBPGq9tvmvseeXTaHpImQIQNyvq+JGug Ucgqz14HYL2fpuZHzDgrDaAPJdDTf2R7tU1KyzmlwldDtyLz0y3paJ4cGSXh+XMfNZJq 0K9lwsOPiKcHfxWR5vVlHol8BlEhd1D0+ApAxo6E9ssvGNMq2YC4Gwmt8pNpMlVgLV1N kpM6fcoB0OUiIzvQnQba00pzm9F6iTlLlFnq/5W+ibZ2RFwOErmMkqPS2ytjlld56bqH ORkg== X-Gm-Message-State: AOAM533XW+agjFxba+Gv83RfPJ8gt8uvlmroSBJry7fvxpZv57Xy0Hwk 4os5F9H6gZfTNoroFsVBbj2y4YmU3L15Tk/I/CaioJ0u X-Google-Smtp-Source: ABdhPJwACDxtIBnzOFbg+gpOsltnl74kiU0+HOmV074Uv2Bt6Zb5+2Ucyz0WuBcV6XtpLNWcooqvITjxNHYECXJ1nto= X-Received: by 2002:a05:6000:184c:: with SMTP id c12mr17314479wri.127.1635543361892; Fri, 29 Oct 2021 14:36:01 -0700 (PDT) MIME-Version: 1.0 References: <7055d87cdde449415e62f0b0c15d96deb378af67.camel@posteo.net> In-Reply-To: From: Sharlatan Hellseher Date: Fri, 29 Oct 2021 22:35:51 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635544021; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9YqvCZa2+AzyVly8fNmC+zqdDZdsMwzvg8ojc+7/wno=; b=XiFt86g3lAqdI37rPmJ5IVZIVRcn6e63x7dr/0DUEuiP8+5JgsXTLiVE1QOg2dQKT+buOv NpuEjhiIHy8VPcjcOULK//7cfPKNPEAtOaTYDSHIltLf9W6AA/+ZLty5FD1dnHCgJtSlXW 4SQ1GNoAPTNKedwEVuYWfC1Lj14w1oVLhJO2DwizG6ecxFkC/35O86NpyCZ6rPk7F9qPgw CUj9SxoBuBqXJmX3zd6mrt383PHHSRma2WtD/WepLKTqECWXZIZjAZjgi7EI+5xnk/Ae+R cBt8sRbKOHTC4ADrpTdbyfgEaERZm2snYLkc4XotAMhWURw2OnKlAE5w5Orm0g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635544021; a=rsa-sha256; cv=none; b=sGbAuD4/ULkNOOmkk6HpnzPXYSONi/4Vb2cy7R9EJCtzMobL4XPaD7/A84wL+u0e6PbtUZ WdXyQsu8lFUTeUsKFxtZgjgzm9wp7xD4/MVEiM6qLUPfemYwAGqheU/E6eNwgT9igSn8Q5 1LL9T7X/Ds7Mi/a5WuU/iZIvwB/NiPfnnFtQRTBDXGCGxLrVzl2M15USxqRAbbaZcaf5Hn rZNec+IDZnf9FTcQGKeMT7KgwcHqBpnNKS28mOMx5c8cyjUnEG1Ngfa4n782C209ouFrFj q/yy/ZVs+yhvoMq3g+3YTrkEmzGplgTwENcgnXJyDlcsawspW8Cjw3Ph44r6UQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=l73d+8K8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=l73d+8K8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E8DCF360EF X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: aRcUv8kkVEj4 Hi Guix team! Is this set of patches still in review or just dromaint :)? Regards On Sun, 23 May 2021 at 21:01, Sharlatan Hellseher w= rote: > > Hi Vinicius, > > It' fantastic! Thanks for your feedback and modification, I'm > absolutely ok with them. > > When astropy is accepted it will open a way for other astronomical > packages which are depend on it, > and I've noticed some other packages in master require astropy for > tests so it would beneficial to have it merged :)! > > On Sun, 23 May 2021 at 17:54, Vinicius Monego wrote: > > > > Hi Sharlatan, > > > > Thanks for continuing the work on the astropy package, I managed to > > finish it this time. I am resending your patch with the following > > modifications: > > > > - Moved the package definition from the bottom to the middle of the > > file (to avoid merge conflicts) > > - Removed all optional inputs and propagated the remaining. I left only > > those listed in install_requires, setup_requires, test_requires and > > test[extras] in setup.cfg > > - Changed synopsis and description > > - Changed package labels to match the package name > > - Made the compiler file writable instead of deleting it > > - Deleted the makdir-astropy phase (it wasn't needed) > > - Added license for the jquery bundle that is not replaced > > > > and then I made my own improvements on that patch: enabling tests and > > unbundling some external libraries. > > > > I removed the optional packages because astropy is a core package, > > which will be a dependency for its many extensions. It's important that > > it builds with a high probability of success or the chain will break. > > Some of its optional dependencies, e.g. Pandas, have a broken build in > > aarch64 at the moment. The "full" astropy package could be installed > > easily from a manifest file and the tests can run again with > > astropy.test(). > > > > > the project heavily depends on TOX which requires pip to install > > > missing dependencies for itself. > > > > I don't think that a project can heavily depend on tox, all it does is > > manage a virtual environment with dependencies to run the tests. Guix > > does the same so tox is redundant here. Tests will still run with the > > testing framework. > > > > Two more suggestions for future Python patches: > > > > > + (replace 'check > > > + (lambda* (#:key inputs outputs #:allow-other-keys) > > > + (add-installed-pythonpath inputs outputs) > > > + (invoke "pytest" "-vv"))) > > > > When a project contains tests as part of the application code, as in > > Astropy, tests should run with "pytest --pyargs module". See Pytest > > Integration Pratices: > > https://docs.pytest.org/en/documentation-restructure/background/goodpra= ctices.html > > > > It's also good practice in Guix to use (when tests?) when overriding > > the check phase to allow --without-tests=3Dpkg. > > > > > ImportError: You appear to be trying to import astropy from within a > > > source checkout or from an editable installation without building the > > > extension modules first. Either run: > > > > I fixed this error by running the second command before the tests. > > > > If you don't mind the modifications I did, I will call this patchset > > complete and wait for a committer to review. > > > > Vinicius > > > > -- > > =E2=80=A6 =D0=BD=D0=B0=D1=88 =D1=80=D0=B0=D0=B7=D1=83=D0=BC - =D0=BF=D1= =80=D0=B5=D0=B2=D0=BE=D1=81=D1=85=D0=BE=D0=B4=D0=BD=D0=B0=D1=8F =D0=BE=D0= =B1=D1=8A=D1=8F=D1=81=D0=BD=D0=B8=D1=82=D0=B5=D0=BB=D1=8C=D0=BD=D0=B0=D1=8F= =D0=BC=D0=B0=D1=88=D0=B8=D0=BD=D0=B0 =D0=BA=D0=BE=D1=82=D0=BE=D1=80=D0=B0= =D1=8F =D1=81=D0=BF=D0=BE=D1=81=D0=BE=D0=B1=D0=BD=D0=B0 > =D0=BD=D0=B0=D0=B9=D1=82=D0=B8 =D1=81=D0=BC=D1=8B=D1=81=D0=BB =D0=BF=D0= =BE=D1=87=D1=82=D0=B8 =D0=B2 =D1=87=D0=B5=D0=BC =D1=83=D0=B3=D0=BE=D0=B4=D0= =BD=D0=BE, =D0=B8=D1=81=D1=82=D0=BE=D0=BB=D0=BA=D0=BE=D0=B2=D0=B0=D1=82=D1= =8C =D0=BB=D1=8E=D0=B1=D0=BE=D0=B9 =D1=84=D0=B5=D0=BD=D0=BE=D0=BC=D0=B5=D0= =BD, =D0=BD=D0=BE > =D1=81=D0=BE=D0=B2=D0=B5=D1=80=D1=88=D0=B5=D0=BD=D0=BD=D0=BE =D0=BD=D0=B5= =D0=B2 =D1=81=D0=BE=D1=81=D1=82=D0=BE=D1=8F=D0=BD=D0=B8=D0=B8 =D0=BF=D1=80= =D0=B8=D0=BD=D1=8F=D1=82=D1=8C =D0=BC=D1=8B=D1=81=D0=BB=D1=8C =D0=BE =D0=BD= =D0=B5=D0=BF=D1=80=D0=B5=D0=B4=D1=81=D0=BA=D0=B0=D0=B7=D1=83=D0=B5=D0=BC=D0= =BE=D1=81=D1=82=D0=B8. --=20 =E2=80=A6 =D0=BD=D0=B0=D1=88 =D1=80=D0=B0=D0=B7=D1=83=D0=BC - =D0=BF=D1=80= =D0=B5=D0=B2=D0=BE=D1=81=D1=85=D0=BE=D0=B4=D0=BD=D0=B0=D1=8F =D0=BE=D0=B1= =D1=8A=D1=8F=D1=81=D0=BD=D0=B8=D1=82=D0=B5=D0=BB=D1=8C=D0=BD=D0=B0=D1=8F = =D0=BC=D0=B0=D1=88=D0=B8=D0=BD=D0=B0 =D0=BA=D0=BE=D1=82=D0=BE=D1=80=D0=B0= =D1=8F =D1=81=D0=BF=D0=BE=D1=81=D0=BE=D0=B1=D0=BD=D0=B0 =D0=BD=D0=B0=D0=B9=D1=82=D0=B8 =D1=81=D0=BC=D1=8B=D1=81=D0=BB =D0=BF=D0=BE= =D1=87=D1=82=D0=B8 =D0=B2 =D1=87=D0=B5=D0=BC =D1=83=D0=B3=D0=BE=D0=B4=D0=BD= =D0=BE, =D0=B8=D1=81=D1=82=D0=BE=D0=BB=D0=BA=D0=BE=D0=B2=D0=B0=D1=82=D1=8C = =D0=BB=D1=8E=D0=B1=D0=BE=D0=B9 =D1=84=D0=B5=D0=BD=D0=BE=D0=BC=D0=B5=D0=BD, = =D0=BD=D0=BE =D1=81=D0=BE=D0=B2=D0=B5=D1=80=D1=88=D0=B5=D0=BD=D0=BD=D0=BE =D0=BD=D0=B5 = =D0=B2 =D1=81=D0=BE=D1=81=D1=82=D0=BE=D1=8F=D0=BD=D0=B8=D0=B8 =D0=BF=D1=80= =D0=B8=D0=BD=D1=8F=D1=82=D1=8C =D0=BC=D1=8B=D1=81=D0=BB=D1=8C =D0=BE =D0=BD= =D0=B5=D0=BF=D1=80=D0=B5=D0=B4=D1=81=D0=BA=D0=B0=D0=B7=D1=83=D0=B5=D0=BC=D0= =BE=D1=81=D1=82=D0=B8.