all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#66967] [PATCH] Update radicale to 3.1.8.
@ 2023-11-06 11:23 Wicki Gabriel (wicg)
  2023-11-08 12:48 ` [bug#66967] Sharlatan Hellseher
  2023-11-23 15:12 ` [bug#66967] [PATCH] Update radicale to 3.1.8 Christopher Baines
  0 siblings, 2 replies; 3+ messages in thread
From: Wicki Gabriel (wicg) @ 2023-11-06 11:23 UTC (permalink / raw)
  To: 66967


[-- Attachment #1.1: Type: text/plain, Size: 174 bytes --]

The issue with the tests has been fixed in the new upstream version, so this patch bumps the version and re-enables the tests.

Thanks for a quick review/merge,

gabber

[-- Attachment #1.2: Type: text/html, Size: 1292 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-radicale-Update-to-3.1.8.patch --]
[-- Type: text/x-patch; name="0001-gnu-radicale-Update-to-3.1.8.patch", Size: 1627 bytes --]

From 9f77749cff1d6f7eca8ce4f0e61db678d78e0f33 Mon Sep 17 00:00:00 2001
Message-ID: <9f77749cff1d6f7eca8ce4f0e61db678d78e0f33.1699269718.git.wicg@zhaw.ch>
From: Gabriel Wicki <gabriel@erlikon.ch>
Date: Mon, 6 Nov 2023 12:18:45 +0100
Subject: [PATCH] gnu: radicale: Update to 3.1.8.

* gnu/packages/dav.scm(radicale): Update to 3.1.8.  [arguments] Enable tests.

Change-Id: I8ed435587ab2ca4aafb387d4973f864fa4a94b2d
---
 gnu/packages/dav.scm | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/dav.scm b/gnu/packages/dav.scm
index e0306b8a97..42d95f71c4 100644
--- a/gnu/packages/dav.scm
+++ b/gnu/packages/dav.scm
@@ -43,23 +43,20 @@ (define-module (gnu packages dav)
 (define-public radicale
   (package
     (name "radicale")
-    (version "3.1.7")
+    (version "3.1.8")
     (source
      (origin
-       ;; There are no tests in the PyPI tarball.
        (method git-fetch)
        (uri (git-reference
              (url "https://github.com/Kozea/Radicale")
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1mv1w9qazbis9ir5shr1ybsfn4cxd3rmxa3ns6kbk23yramlzwhg"))))
+        (base32 "1qy2azn02bw772yhzgqvyf1pyl0ijj9ccvl1078w9icl261yljap"))))
     (build-system python-build-system)
     (arguments
       (list
-       ;; TODO: enable again when https://github.com/Kozea/Radicale/issues/1184
-       ;; is fixed
-       #:tests? #f))
+       #:tests? #t))
     (native-inputs
      (list python-pytest
            python-pytest-cov

base-commit: d52ee267ee8245a6edfcd137c73d20b036ec08d1
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#66967]
  2023-11-06 11:23 [bug#66967] [PATCH] Update radicale to 3.1.8 Wicki Gabriel (wicg)
@ 2023-11-08 12:48 ` Sharlatan Hellseher
  2023-11-23 15:12 ` [bug#66967] [PATCH] Update radicale to 3.1.8 Christopher Baines
  1 sibling, 0 replies; 3+ messages in thread
From: Sharlatan Hellseher @ 2023-11-08 12:48 UTC (permalink / raw)
  To: 66967

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

Hi,

Patch looks good.

One thing to mention - you may drop arguments completely as you don't need
explicitly set #:tests? to #t.

May you send v2 with modification please?

Thanks,
Oleg

[-- Attachment #2: Type: text/html, Size: 419 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#66967] [PATCH] Update radicale to 3.1.8.
  2023-11-06 11:23 [bug#66967] [PATCH] Update radicale to 3.1.8 Wicki Gabriel (wicg)
  2023-11-08 12:48 ` [bug#66967] Sharlatan Hellseher
@ 2023-11-23 15:12 ` Christopher Baines
  1 sibling, 0 replies; 3+ messages in thread
From: Christopher Baines @ 2023-11-23 15:12 UTC (permalink / raw)
  To: Wicki Gabriel (wicg); +Cc: 66967-done, 66967

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]


"Wicki Gabriel (wicg)" <wicg@zhaw.ch> writes:

> The issue with the tests has been fixed in the new upstream version,
> so this patch bumps the version and re-enables the tests.

Thanks both, I've removed the #:tests? #t and pushed this to master as
4162838ef8090863906c5cefa488815fcf6c742f.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-11-23 15:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-06 11:23 [bug#66967] [PATCH] Update radicale to 3.1.8 Wicki Gabriel (wicg)
2023-11-08 12:48 ` [bug#66967] Sharlatan Hellseher
2023-11-23 15:12 ` [bug#66967] [PATCH] Update radicale to 3.1.8 Christopher Baines

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.