From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id KIT+Dh0Z0mURTwAAqHPOHw:P1 (envelope-from ) for ; Sun, 18 Feb 2024 15:50:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id KIT+Dh0Z0mURTwAAqHPOHw (envelope-from ) for ; Sun, 18 Feb 2024 15:50:05 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Q16yqtzI; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708267805; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bo0YDQrZ00UgaGlMUPVm3euFC+zIm2zI15wX8/s8fqw=; b=LE3CXCFalGpNuU9shWKeiuKAEP8bg6qNYJY1HWU5pJZfXxAFEndR9eHgEFt4qMd0w5buWV bGYlREDDivc5zPCgkxUC0/jU0EHPKb3ciZoEVfTRVw+zMYh8x0Wa6tjVdTkuwwGlws4OPO qQLkWL7thpvrQvr1QK7GCQAVIp4jNdY/Hc6X4Q0w8b2VQzuKa48fxxn/mmez8Z9igPsHNE XByqtE6NY7KWLURjpWAo7Q61quJSDNw33AxucCexWfubOTfhqT3nLuZba29FcNIL7tX+GH t9VhCg+P9a5ucUcV2TcAesGnmrdChSIeDIwOGS9ZiC4Y1RLFn2a4RbJcx/xUMg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Q16yqtzI; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708267805; a=rsa-sha256; cv=none; b=p3LvlaAsv2HQpF5oIRl1zLJQ0JRjNKc5ve7NrqZKvdWHmDa21JjCpgW3jtFhen0qO8g7AF yKTYIzDeXdo9Ehzrrly1pa3Z1MWgYmJRJNZ5dgklR3Hfs2xj2g2K3OvjrmPZUoT5o1iELA 2SS0BB4dDMrS2abnTdiFWQlHd30xzkUGlNopq3TQXWXes7s/ug3ffklrpebGncT6mHi29n fhz1YT2uGajf2fKnxMc8aIkb6k4hkHUCL2ozYVHQnDbs7UTKGKUwNqXjJ4TW3BuxxUWF35 ctwdFgy6XIutVF0oQfxB9OExagaYgLZQHdMLN13/UaNvIUdJ5W+1gUsRb2/lug== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D0A3945F9F for ; Sun, 18 Feb 2024 15:50:04 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rbiUC-00049B-8B; Sun, 18 Feb 2024 09:49:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbiU9-00048W-EN for guix-patches@gnu.org; Sun, 18 Feb 2024 09:49:41 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rbiU9-0000vn-5Y for guix-patches@gnu.org; Sun, 18 Feb 2024 09:49:41 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rbiUT-0000n4-L6 for guix-patches@gnu.org; Sun, 18 Feb 2024 09:50:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#66180] [PATCH 00/19] Sort packages in node-xyz.scm Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 18 Feb 2024 14:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66180 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Graves Cc: 66180-done@debbugs.gnu.org Received: via spool by 66180-done@debbugs.gnu.org id=D66180.17082677963022 (code D ref 66180); Sun, 18 Feb 2024 14:50:01 +0000 Received: (at 66180-done) by debbugs.gnu.org; 18 Feb 2024 14:49:56 +0000 Received: from localhost ([127.0.0.1]:34312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbiUN-0000me-PY for submit@debbugs.gnu.org; Sun, 18 Feb 2024 09:49:56 -0500 Received: from mail-lf1-f53.google.com ([209.85.167.53]:43080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbiUJ-0000mL-Fd for 66180-done@debbugs.gnu.org; Sun, 18 Feb 2024 09:49:53 -0500 Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5112bd13a4fso4825908e87.0 for <66180-done@debbugs.gnu.org>; Sun, 18 Feb 2024 06:49:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708267705; x=1708872505; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bo0YDQrZ00UgaGlMUPVm3euFC+zIm2zI15wX8/s8fqw=; b=Q16yqtzI1kFbvlLtcMXIumeDCYgw998nFhciJSKMDlQegXHYR/LEqdqGrSFhMXihT3 thE9CyGM12CKk0oTBmEUxRxOtQsahMqyRk1pimtTo/j+ZJDYeFDM8pQ6geIkiYKOohY8 iuvIBfM8L8vRGZ8+OoapOesWc8aaqzNUcGmErgdr2YQDv4W91rWDPvbi68A3lCgfOQwW +Fbv/sek21/g90AeuJ3EBvFduBgqy3BseqR6F6JtyWElvLjujvkEzP3zVyCG13aooZVh MzT7K7Pud+ewQy5rU2hpx4hqyVqHIYlOfGcqhaslguvVXVmBN1qJRVJUwgQWcvPqKZcH FZ0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708267705; x=1708872505; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bo0YDQrZ00UgaGlMUPVm3euFC+zIm2zI15wX8/s8fqw=; b=Avf4P4RW1nrp2VsF+qjteY/8LUfKrFPhJ2zeu8U/1Zn9nVGnpG63ijfLvcKqapBx/R N8J7RJISNFQrSBHsvmTc5YkQzD/oDLqhHadA9nTiES6/76itJbOZl/kjFHD3ohXK99zA Fe+pC+2u1/9RnvBBE0GvCEJyZrNZRyI5yORwW9ylVXao+c0ZT73v0jNq2MCrgblVsl8j wbuy7t3lrwfKPQAb3PC2DfVEEPA7rAmhMJr/3Tj4jgFulnCacvMsj9Z739HFPA1m6xX2 wVSd4okh/Ft0K4ks7F6kXABOZMXV8W5XhVVDrUtUsL9Egb3ZgjPUeetrpkEaJpRjhOrg gaQA== X-Gm-Message-State: AOJu0Yw5ceHnFHiv0m8Sr3cfdzmN8HMgy7j+ZNJt5/CdEJnxgUjNDQT9 kBx2h0frKImDdOP4o6QiyYBittnFhgvkQtUd5gNT2rE2UYM158jpgkBcRM5HArJgTstoAq08BgJ olTNMxz7Ac6lsxMpArh+6VWMrFDM= X-Google-Smtp-Source: AGHT+IFOJre9dz73747zaEYh+ut82vUKFG3ZVoejlbF+17j8fNvGSgRZtmQxQRr6EEpv409NSozBebTczSKmkxxAJLI= X-Received: by 2002:a05:6512:4026:b0:512:a84f:697 with SMTP id br38-20020a056512402600b00512a84f0697mr1058697lfb.2.1708267704649; Sun, 18 Feb 2024 06:48:24 -0800 (PST) MIME-Version: 1.0 References: <87ttm5ly63.fsf@gmail.com> <87h6i5lul7.fsf@ngraves.fr> <87edd9lubm.fsf@ngraves.fr> In-Reply-To: <87edd9lubm.fsf@ngraves.fr> From: Sharlatan Hellseher Date: Sun, 18 Feb 2024 14:48:13 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.38 X-Spam-Score: -5.38 X-Migadu-Queue-Id: D0A3945F9F X-Migadu-Scanner: mx11.migadu.com X-TUID: 1LD+y21SGSTI Hi Nicolas, >From recent split job for golang I may say that the order and placement of = the inherited package is very important. There are two simple rules I've followed: - inherited package needs to be in the same Guile module - inherited package needs to follow the one which it's inherited from Take a look at golang-xyz.scm, it's freshly created, alphabetically sorted = and all inherited packages following 2 mentioned rules. -- Oleg On Sun, 18 Feb 2024 at 14:29, Nicolas Graves wrote: > > On 2024-02-18 15:23, Nicolas Graves wrote: > > > On 2024-02-18 13:06, Sharlatan Hellseher wrote: > > > >> Hi Nicolas, > >> > >> I've checked packages order once again and found that some of them sti= ll > >> need to be re-allocated but due to inheritance it can't be done easily= . > >> > >> e.g. package node-serialport needs to be the one from the rest are inh= eritated. > >> > >> - node-serialport-binding-abstract > >> - node-serialport-bindings > >> - node-serialport-parser-byte-length > >> - node-serialport-parser-cctalk > >> - node-serialport-parser-delimiter > >> - node-serialport-parser-inter-byte-timeout > >> - node-serialport-parser-readline > >> - node-serialport-parser-ready > >> - node-serialport-parser-regex > >> - node-serialport-stream > >> > >> May you check it please in the next round? > > > > Will do. > > I'm not sure how to do that though with these inheritance issues. Do you > have an example in Guix source where this kind of things is done? > > > >> > >> I've used Emacs' occur, search for define-public, copied to an empty > >> buffer A and in buffer B sorted lines, then run buffer-diff on A and B= . > >> --8<---------------cut here---------------start------------->8--- > >> diff -u --label \#\\> --label \#\\> /tmp/buffer-content-SbBuJ0 /tmp/buffer-content-bu3SO4 > >> --- #> > >> +++ #> > >> @@ -30,17 +30,17 @@ > >> define-public node-safe-stable-stringify > >> define-public node-segfault-handler > >> define-public node-semver > >> +define-public node-serialport > >> define-public node-serialport-binding-abstract > >> +define-public node-serialport-bindings > >> +define-public node-serialport-parser-byte-length > >> +define-public node-serialport-parser-cctalk > >> define-public node-serialport-parser-delimiter > >> +define-public node-serialport-parser-inter-byte-timeout > >> define-public node-serialport-parser-readline > >> -define-public node-serialport-bindings > >> -define-public node-serialport-parser-regex > >> define-public node-serialport-parser-ready > >> -define-public node-serialport-parser-inter-byte-timeout > >> -define-public node-serialport-parser-cctalk > >> -define-public node-serialport-parser-byte-length > >> +define-public node-serialport-parser-regex > >> define-public node-serialport-stream > >> -define-public node-serialport > >> define-public node-sqlite3 > >> define-public node-stack-trace > >> define-public node-statsd-parser > >> --8<---------------cut here---------------end--------------->8--- > >> > >> Your servcie is pushed as aede3fa122..345a54ff4c to master. > >> > >> -- > >> Oleg > > -- > Best regards, > Nicolas Graves --=20 VCS: https://github.incerto.xyz/; https://git.sr.ht/~hellseher/ GPG: 9847 81DE 689C 21C2 6418 0867 76D7 27BF F62C D2B5 =E2=80=A6 =D0=BD=D0=B0=D1=88 =D1=80=D0=B0=D0=B7=D1=83=D0=BC - =D0=BF=D1=80= =D0=B5=D0=B2=D0=BE=D1=81=D1=85=D0=BE=D0=B4=D0=BD=D0=B0=D1=8F =D0=BE=D0=B1= =D1=8A=D1=8F=D1=81=D0=BD=D0=B8=D1=82=D0=B5=D0=BB=D1=8C=D0=BD=D0=B0=D1=8F = =D0=BC=D0=B0=D1=88=D0=B8=D0=BD=D0=B0 =D0=BA=D0=BE=D1=82=D0=BE=D1=80=D0=B0= =D1=8F =D1=81=D0=BF=D0=BE=D1=81=D0=BE=D0=B1=D0=BD=D0=B0 =D0=BD=D0=B0=D0=B9=D1=82=D0=B8 =D1=81=D0=BC=D1=8B=D1=81=D0=BB =D0=BF=D0=BE= =D1=87=D1=82=D0=B8 =D0=B2 =D1=87=D0=B5=D0=BC =D1=83=D0=B3=D0=BE=D0=B4=D0=BD= =D0=BE, =D0=B8=D1=81=D1=82=D0=BE=D0=BB=D0=BA=D0=BE=D0=B2=D0=B0=D1=82=D1=8C = =D0=BB=D1=8E=D0=B1=D0=BE=D0=B9 =D1=84=D0=B5=D0=BD=D0=BE=D0=BC=D0=B5=D0=BD, = =D0=BD=D0=BE =D1=81=D0=BE=D0=B2=D0=B5=D1=80=D1=88=D0=B5=D0=BD=D0=BD=D0=BE =D0=BD=D0=B5 = =D0=B2 =D1=81=D0=BE=D1=81=D1=82=D0=BE=D1=8F=D0=BD=D0=B8=D0=B8 =D0=BF=D1=80= =D0=B8=D0=BD=D1=8F=D1=82=D1=8C =D0=BC=D1=8B=D1=81=D0=BB=D1=8C =D0=BE =D0=BD= =D0=B5=D0=BF=D1=80=D0=B5=D0=B4=D1=81=D0=BA=D0=B0=D0=B7=D1=83=D0=B5=D0=BC=D0= =BE=D1=81=D1=82=D0=B8.