From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uMvwJqAnA2Qe8wAAbAwnHQ (envelope-from ) for ; Sat, 04 Mar 2023 12:12:32 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8BiyJqAnA2SQEQEAauVa8A (envelope-from ) for ; Sat, 04 Mar 2023 12:12:32 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 24B9230CB9 for ; Sat, 4 Mar 2023 12:12:32 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=EeWjVn2P; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677928352; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=epd+MIQl9P4Wa8J5TghkRdwlwW8+0DyzztW+WAf+abE=; b=AmrB7bEODbe8+qtR9UaHaxVSkIpkoQOGnT40wOBHXKFhdGCB5m0P4M56KR2yOd4sP0Pkeb HrM92kDgeJ7fOk3lBTGw8osT3mw0GFNhtxa43s8inqu/iuNyn38YQeHxOt2vJ0fm0d/a38 5P6VMqNexljcUz91avdcLZoqDSDmj3oCePAhB0ZVJy9z+/VKQT5XqAbIs3khbyUosf1fYj nQ9et9OCei0w+LvQKrbiqn/3U1qvCTuVacbD+XEwUHvQ6e5FgfF19Y5GJYFs904vlLdIi0 EHGhkuqDVoUp9bCBXw0De1gIPbU8NqrIW0HXWjhDaiV09FIA1Xk8KlJEebQLEg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=EeWjVn2P; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677928352; a=rsa-sha256; cv=none; b=oBDhjzSQHI7yWq5NCWq/mSclPY+GIn7Qym9slO8QAV+ALmZeMETfajuNtyQz/8kTf3I6Wp BBhN9TizD0yPa0w8STca8jIR5Y6YFHVFXGvISqkaz0Srp9ixW3fB+DHfRprfsncvaFV9c9 1GqG77E2AWuai9mcrD/64dcRA0fYkYtsJ7VlYPu58OIZIZbvkFqXmiAQGj/5RqNQAdqwP2 WXRiVHEqyZ6Emj12PU3c6vFMsMqc7dvebMiUgrJMrolGNA+k4Af0CRuT/I9chcEIzoB3GZ Tw+BmhRCIR2p0R1Yo1zYaAS2GKt7wNHCnOJa5yki5VOuFBrGlufMQcXTP4aywQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYPo4-0007O6-KB; Sat, 04 Mar 2023 06:12:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYPo2-0007Nb-NU for guix-patches@gnu.org; Sat, 04 Mar 2023 06:12:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYPo2-0001MP-EV for guix-patches@gnu.org; Sat, 04 Mar 2023 06:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYPo2-0008Jo-4M for guix-patches@gnu.org; Sat, 04 Mar 2023 06:12:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61674] [PATCH 0/4] gnu: stellarium: Enable ShowMySky. Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 04 Mar 2023 11:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61674 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 61674@debbugs.gnu.org, Simon Tournier Received: via spool by 61674-submit@debbugs.gnu.org id=B61674.167792830431950 (code B ref 61674); Sat, 04 Mar 2023 11:12:02 +0000 Received: (at 61674) by debbugs.gnu.org; 4 Mar 2023 11:11:44 +0000 Received: from localhost ([127.0.0.1]:35295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYPnj-0008JG-IK for submit@debbugs.gnu.org; Sat, 04 Mar 2023 06:11:43 -0500 Received: from mail-qk1-f169.google.com ([209.85.222.169]:36803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYPnh-0008J2-Kn for 61674@debbugs.gnu.org; Sat, 04 Mar 2023 06:11:42 -0500 Received: by mail-qk1-f169.google.com with SMTP id q2so1633158qki.3 for <61674@debbugs.gnu.org>; Sat, 04 Mar 2023 03:11:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=epd+MIQl9P4Wa8J5TghkRdwlwW8+0DyzztW+WAf+abE=; b=EeWjVn2PIoDVkdXqVWjlC/ogAklCsuznF6PAOc7lSzi8fCZllLh2PkvolQJWtxWg1O m6nxGVj+t0a8hkRZf/eZb/cRE1jL+ZHnivdiVaq9Js9LK+c+XfWgbaZxy4q0j7XXb9gu 70Z4MEr2yPN8CjmSOT8L2cJmgsAFmoe7NG8LA6twYlBUwhc5Uo7jGvfIrRtfQqK+Feiu 51FnpSD5W4wbVivwKmZW3wJNS6DDAYLvJ7zDWkwWpVukm1YNG61tR1YxXhSMcV4cMN+g U/8nDSQWQgrIDv2oFv7DJJNVV5vFVGYNGqk4jjuAmPeu7qVx9kBf69zjLtsgC36ibwnc q5rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=epd+MIQl9P4Wa8J5TghkRdwlwW8+0DyzztW+WAf+abE=; b=ccbsUDN9XbhznGkFScJQd5ZDR0UCF07T/uCh0FZdEu2FFkczCUfLzJrA9D1t2zX2ty YOf55OXoYTj+vtMduRcpvq0if7DEe5UIO6kGkdxxDAiAzNFvAj0MMEr6gwGHtZYveNWM qUUbcqiOJKaoN7ule+IzezMXP2VujqQqOS8pinCXE0EjIGMTXpEky3OsxdoTvr1rTn6H Hq0bnYIUYOmYrn3snPH2uvbklBdKtKTKm0arCVzsigsRs7JACDgT9v6lhYT4bA0oxmw6 8lP+znB6JMCJAgylV1j7NuPeL9D3Ly8DUW/jas2bK9G6f6XaYhBkjRgreZP/aDPTZGmr zbmg== X-Gm-Message-State: AO0yUKUzUOXtimvko4LACsGadWhiMaycUOgCMne7dQpAfo+pjSLIRKzh 2FMBYtJCo519KI7tKXiO70n9SX5vAmLbs6a94FE= X-Google-Smtp-Source: AK7set/q0s7M7jWeOnQpVCaI0iDZq4YAx2Zn9qo58fQTdbBRfypRKChC4snFrWB6wceo3SSSrGn+8L59mOwAC0QSOqw= X-Received: by 2002:a05:620a:118a:b0:71f:b8ba:ff4c with SMTP id b10-20020a05620a118a00b0071fb8baff4cmr1300322qkk.10.1677928295926; Sat, 04 Mar 2023 03:11:35 -0800 (PST) MIME-Version: 1.0 References: <20230221130600.18932-1-sharlatanus@gmail.com> <20230226004406.6215-1-sharlatanus@gmail.com> <87ilfmhkuh.fsf_-_@gnu.org> <87lekijcwi.fsf@gmail.com> <87v8jixg6u.fsf@gnu.org> <87o7p94yqk.fsf@gmail.com> <871qm542e7.fsf@gmail.com> In-Reply-To: <871qm542e7.fsf@gmail.com> From: Sharlatan Hellseher Date: Sat, 4 Mar 2023 11:11:26 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000098e4405f611201a" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Spam-Score: -1.20 X-Spam-Score: -1.20 X-Migadu-Scanner: scn0.migadu.com X-Migadu-Queue-Id: 24B9230CB9 List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: O1pXDOmwTpRw --000000000000098e4405f611201a Content-Type: text/plain; charset="UTF-8" Hi all, It was very insightful patch series I ever sent :-) I hope I covered all recommendations in v3. Thanks, Oleg On Sat, 4 Mar 2023, 03:32 Maxim Cournoyer, wrote: > Hi Simon, > > Simon Tournier writes: > > > Hi Maxim, > > > > On Fri, 3 Mar 2023 at 16:54, Maxim Cournoyer > wrote: > > > >> If the inheritance is for *same-source/same-version* variants of a > >> package, they should use package/inherit, as any security issues found > >> in the parent package should also be applied to that package (since they > >> use the same source). Otherwise, plain 'inherit' should be used > >> (e.g. for newer version variants). > > > > Aahh, that makes sense. :-) Thank you. > > > > For instance, does it mean that > > > > (define-public gst-plugins-good-qt > > (package > > (inherit gst-plugins-good) > > (name "gst-plugins-good-qt") > > (inputs > > (modify-inputs (package-inputs gst-plugins-good) > > (prepend qtbase-5 > > qtdeclarative-5 > > qtwayland-5 > > qtx11extras))))) > > > > would be incorrect? It should be 'package/inherit', right? > > It should be package/inherit yes, since they share the same source, thus > the same defects, thus should receive the same replacements/grafts (if > my preceding reasoning is correct :-)). > > -- > Thanks, > Maxim > --000000000000098e4405f611201a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi all,

It w= as very insightful patch series I ever sent :-)
I ho= pe I covered all recommendations in v3.

Thanks,
Oleg

On Sat, 4 Mar 2023= , 03:32 Maxim Cournoyer, <m= axim.cournoyer@gmail.com> wrote:
Hi Simon,

Simon Tournier <zimon.toutoune@gmail.com> writes:

> Hi Maxim,
>
> On Fri, 3 Mar 2023 at 16:54, Maxim Cournoyer <maxim.cournoye= r@gmail.com> wrote:
>
>> If the inheritance is for *same-source/same-version* variants of a=
>> package, they should use package/inherit, as any security issues f= ound
>> in the parent package should also be applied to that package (sinc= e they
>> use the same source).=C2=A0 Otherwise, plain 'inherit' sho= uld be used
>> (e.g. for newer version variants).
>
> Aahh, that makes sense. :-)=C2=A0 Thank you.
>
> For instance, does it mean that
>
> (define-public gst-plugins-good-qt
>=C2=A0 =C2=A0(package
>=C2=A0 =C2=A0 =C2=A0(inherit gst-plugins-good)
>=C2=A0 =C2=A0 =C2=A0(name "gst-plugins-good-qt")
>=C2=A0 =C2=A0 =C2=A0(inputs
>=C2=A0 =C2=A0 =C2=A0 (modify-inputs (package-inputs gst-plugins-good) >=C2=A0 =C2=A0 =C2=A0 =C2=A0 (prepend qtbase-5
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0qtdeclara= tive-5
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0qtwayland= -5
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0qtx11extr= as)))))
>
> would be incorrect?=C2=A0 It should be 'package/inherit', righ= t?

It should be package/inherit yes, since they share the same source, thus the same defects, thus should receive the same replacements/grafts (if
my preceding reasoning is correct :-)).

--
Thanks,
Maxim
--000000000000098e4405f611201a--