Hi Simon,
Simon Tournier <zimon.toutoune@gmail.com> writes:
> Hi Maxim,
>
> On Fri, 3 Mar 2023 at 16:54, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>> If the inheritance is for *same-source/same-version* variants of a
>> package, they should use package/inherit, as any security issues found
>> in the parent package should also be applied to that package (since they
>> use the same source). Otherwise, plain 'inherit' should be used
>> (e.g. for newer version variants).
>
> Aahh, that makes sense. :-) Thank you.
>
> For instance, does it mean that
>
> (define-public gst-plugins-good-qt
> (package
> (inherit gst-plugins-good)
> (name "gst-plugins-good-qt")
> (inputs
> (modify-inputs (package-inputs gst-plugins-good)
> (prepend qtbase-5
> qtdeclarative-5
> qtwayland-5
> qtx11extras)))))
>
> would be incorrect? It should be 'package/inherit', right?
It should be package/inherit yes, since they share the same source, thus
the same defects, thus should receive the same replacements/grafts (if
my preceding reasoning is correct :-)).
--
Thanks,
Maxim