about -lcurses

about -lcurses

[guy fleury]

hi all,

i try to package a editor "nice editor":
i got this error: 
     
    ld: cannot find -lcurses

on debian it works because -lcurses is a symlink to -lncurses(if i am
not wrong) 

is there a solution without make a patch to the makifile?
here is my package definition:
-------------------------------------------------------
(define-module (gnu packages ne)
  #:use-module (guix licenses)
  #:use-module (gnu packages ncurses)
  #:use-module (guix packages)
  #:use-module (guix download)
  #:use-module (guix build-system gnu))
(define-public ne
(package
  (name "ne")
  (version "3.1.2")
  (source (origin
            (method url-fetch)
            (uri (string-append "http://ne.di.unimi.it/ne-" version
                                ".tar.gz"))
            (sha256
             (base32
              "06qk3cqxyn098i1yn686bigpgh8vrrnj0qpkrgs6zwnq42s1y0d2")))
)
           
            
  (build-system gnu-build-system)
  (arguments
       `(#:tests? #f
          #:make-flags (list (string-append "prefix=" (assoc-ref
%outputs "out"))
                   "CC=gcc")
         #:parallel-build? #f
         #:phases (modify-phases %standard-phases (delete
'configure))))
  (inputs
     `(("ncurses" ,ncurses)))
  (synopsis "TODO")
  (description "TODO")
  (home-page " http://ne.di.unimi.it/ne")
  (license gpl3+)))


   

Re: about -lcurses

[Mathieu Othacehe]

Hi Guy,

Your package is almost working, the important thing was to specified
"ncurses" as an input like you did.

> on debian it works because -lcurses is a symlink to -lncurses(if i am
> not wrong) 

Yes, I guess they are doing some kind of symlinking. To make it work,
you can replace -lcurses by -lncurses, this way:

--8<---------------cut here---------------start------------->8---
#:phases
      (modify-phases %standard-phases
        (delete 'configure)
        (add-before 'build 'curses
           (lambda _
             (substitute* "src/makefile"
               (("lcurses") "lncurses"))
             #t)))
--8<---------------cut here---------------end--------------->8---

You also have a small mistake here

>           #:make-flags (list (string-append "prefix=" (assoc-ref
                                                 ^
prefix should be upper case.

Then, you should be able to build your package ;)

Mathieu

Re: about -lcurses

[Maxim Cournoyer]

Hello,

guy fleury <hoonandon@gmail.com> writes:

> hi all,
>
> i try to package a editor "nice editor":
> i got this error: 
>      
>     ld: cannot find -lcurses
>
> on debian it works because -lcurses is a symlink to -lncurses(if i am
> not wrong) 
>
> is there a solution without make a patch to the makifile?

If -lncurses would be enough, then I believe the simplest solution would
be to add a build phase and use a substitute* call to patch the
Makefile. You'll find plenty of examples of similar things in the
packages sources.

HTH!

Maxim

Re: about -lcurses

[guy fleury]

thank you very much,

this is what i did
--------------------------------
            (snippet
               ;; use lncurses instead of lcurses
               '(begin
                  (substitute* "src/makefile"
                    (("-lcurses")
                     "-lncurses"))
                  #t))))
---------------------------------
Now it works.
i got to polish it and try to send a patch.

Guy  

Re: about -lcurses

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]


> You also have a small mistake here
> 
> :           #:make-flags (list (string-append "prefix=" (assoc-ref
>                                                  ^
> prefix should be upper case.

This might not be correct, depending on which Make and the Makefile.
Lowercase "prefix" is actually the right directory variable for GNU Make.
See the "(make) Directory Variables" info page.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: about -lcurses

[Mathieu Othacehe]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

Hi Pierre,

This might not be correct, depending on which Make and the Makefile.
> Lowercase "prefix" is actually the right directory variable for GNU Make.
> See the "(make) Directory Variables" info page.
>

In that precise case, without an upper case PREFIX, it won't build (check
the root makefile).

Mathieu

[-- Attachment #2: Type: text/html, Size: 602 bytes --]

Re: about -lcurses

[Hy Od]

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

Hi,
for me PREFIX and prefix seems to be the same!

I have sent a patch of ne package to guix-patch maillist!
Le 10 nov. 2018 11:46, "Pierre Neidhardt" <mail@ambrevar.xyz> a écrit :

>
> > You also have a small mistake here
> >
> > :           #:make-flags (list (string-append "prefix=" (assoc-ref
> >                                                  ^
> > prefix should be upper case.
>
> This might not be correct, depending on which Make and the Makefile.
> Lowercase "prefix" is actually the right directory variable for GNU Make.
> See the "(make) Directory Variables" info page.
>
> --
> Pierre Neidhardt
> https://ambrevar.xyz/
>

[-- Attachment #2: Type: text/html, Size: 1095 bytes --]

Re: about -lcurses

[Hy Od]

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

I'm Guy!
Le 10 nov. 2018 12:59, "Hy Od" <hoonandon@gmail.com> a écrit :

> Hi,
> for me PREFIX and prefix seems to be the same!
>
> I have sent a patch of ne package to guix-patch maillist!
> Le 10 nov. 2018 11:46, "Pierre Neidhardt" <mail@ambrevar.xyz> a écrit :
>
>>
>> > You also have a small mistake here
>> >
>> > :           #:make-flags (list (string-append "prefix=" (assoc-ref
>> >                                                  ^
>> > prefix should be upper case.
>>
>> This might not be correct, depending on which Make and the Makefile.
>> Lowercase "prefix" is actually the right directory variable for GNU Make.
>> See the "(make) Directory Variables" info page.
>>
>> --
>> Pierre Neidhardt
>> https://ambrevar.xyz/
>>
>

[-- Attachment #2: Type: text/html, Size: 1434 bytes --]