From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47498)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gB1gS-0004jC-7o
	for guix-patches@gnu.org; Fri, 12 Oct 2018 13:57:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gB1gM-0006sj-Hq
	for guix-patches@gnu.org; Fri, 12 Oct 2018 13:57:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:43191)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gB1gM-0006s9-5W
	for guix-patches@gnu.org; Fri, 12 Oct 2018 13:57:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gB1gL-00011u-Ub
	for guix-patches@gnu.org; Fri, 12 Oct 2018 13:57:01 -0400
Subject: [bug#32933] [PATCH] guix: add license prefix hackage imports
Resent-Message-ID: <handler.32933.B32933.15393669793904@debbugs.gnu.org>
MIME-Version: 1.0
References: <CANJQ5C6Q_izmdftZ2xWb2SbiDiCnf3-ZdTTH_UzS=hFvbtPx9Q@mail.gmail.com>
	<87h8hri9sj.fsf@gnu.org>
In-Reply-To: <87h8hri9sj.fsf@gnu.org>
From: Joe Hillenbrand <joehillen@gmail.com>
Date: Fri, 12 Oct 2018 10:55:30 -0700
Message-ID: <CANJQ5C5PfMfM4dduVEiqnT36x_9ZpCQKN7DZtWGr2UHYA3EWDA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: rekado@elephly.net, 32933@debbugs.gnu.org

Sorry, I meant to add justification in the commit message, but apparently I
forgot.

The motivation was to be consistent with the `gnu/packages/haskell.scm` whi=
ch
uses the `license:` prefix. I noticed this when I imported a bunch of packa=
ges
and all of them were missing the prefix, which then had to be manually adde=
d.

On Fri, Oct 12, 2018 at 6:17 AM Ludovic Court=C3=A8s <ludo@gnu.org> wrote:
>
> No strong opinion, but apparently none of the importers currently adds
> the =E2=80=98license:=E2=80=99 prefix and I=E2=80=99d rather keep that co=
nsistent, one way or
> another.

That's not entirely true. crate calls `spdx-string->license` which adds the
prefix, but it doesn't appear to actually work because it looks for the lic=
ense
in the wrong part of the json output from crates.io.

I'd be happy to add it to the other importers as it looks like almost all o=
f
`gnu/packages/*.scm` has the `license:` prefix. If so, should I do them all
in a new patch?

Thanks,
Joe