From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: rennes <rennes@openmailbox.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 3/3] gnu: Add filezilla.
Date: Wed, 15 Feb 2017 13:13:40 -0800 [thread overview]
Message-ID: <CAN-vT6RHnH=z-dLQOUgxccg=MdBe=CV--yOkw=rQDED-xxxWug@mail.gmail.com> (raw)
In-Reply-To: <ab0c87cfad277b35a661ad475dd1e9fc@openmailbox.org>
[-- Attachment #1: Type: text/plain, Size: 569 bytes --]
Hi,
While I haven't tried it, the patch looks good to me!
Maxim
On Tue, Feb 14, 2017 at 9:44 PM, <rennes@openmailbox.org> wrote:
>
> Minor thing, and I'm not sure if we have a convention for this, but it'd
>> be neat to keep the use-module statements ordered alphabetically.
>>
>>
> Ordered alphabetically!
>
>
>> Again, I'm under the impression that this should rather be gpl2+. I'd be
>> happy to be proven wrong otherwise!
>>
>> + (properties '((upstream-name . "FileZilla")))))
>>>
>>
>> Otherwise LGTM (haven't tested though).
>>
>
> Updated patch. Thanks
[-- Attachment #2: Type: text/html, Size: 1383 bytes --]
next prev parent reply other threads:[~2017-02-15 21:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 16:36 [PATCH] gnu: Add filezilla rennes
2017-02-09 16:36 ` [PATCH 1/3] gnu: wxwidgets: Fix for Filezilla client rennes
2017-02-16 16:28 ` Leo Famulari
2017-02-18 0:39 ` rennes
2017-02-18 1:22 ` rennes
2017-02-09 16:36 ` [PATCH 2/3] gnu: Add libfilezilla rennes
2017-02-13 2:26 ` Maxim Cournoyer
2017-02-13 2:41 ` rennes
2017-02-13 6:32 ` Maxim Cournoyer
2017-02-15 5:41 ` rennes
2017-02-15 21:22 ` Maxim Cournoyer
2017-02-16 16:24 ` Leo Famulari
2017-02-09 16:36 ` [PATCH 3/3] gnu: Add filezilla rennes
2017-02-13 2:36 ` Maxim Cournoyer
2017-02-15 5:44 ` rennes
2017-02-15 21:13 ` Maxim Cournoyer [this message]
2017-02-16 16:24 ` Leo Famulari
2017-03-05 4:15 ` [PATCH] " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN-vT6RHnH=z-dLQOUgxccg=MdBe=CV--yOkw=rQDED-xxxWug@mail.gmail.com' \
--to=maxim.cournoyer@gmail.com \
--cc=guix-devel@gnu.org \
--cc=rennes@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.