* [PATCH] gnu: Add urwid @ 2015-02-01 22:56 Omar Radwan 2015-02-01 23:23 ` Omar Radwan 0 siblings, 1 reply; 14+ messages in thread From: Omar Radwan @ 2015-02-01 22:56 UTC (permalink / raw) To: guix-devel [-- Attachment #1: Type: text/plain, Size: 130 bytes --] Here is a patch to add urwid, which is required for wicd, which I will be working on tomorrow, and hopefully finish by next week. [-- Attachment #2: Type: text/html, Size: 154 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] gnu: Add urwid 2015-02-01 22:56 [PATCH] gnu: Add urwid Omar Radwan @ 2015-02-01 23:23 ` Omar Radwan 2015-02-02 0:14 ` Omar Radwan 0 siblings, 1 reply; 14+ messages in thread From: Omar Radwan @ 2015-02-01 23:23 UTC (permalink / raw) To: guix-devel [-- Attachment #1: Type: text/plain, Size: 267 bytes --] Wow. I was in such a hurry I forgot to add the patch file On Feb 1, 2015 2:56 PM, "Omar Radwan" <toxemicsquire4@gmail.com> wrote: > Here is a patch to add urwid, which is required for wicd, which I will be > working on tomorrow, and hopefully finish by next week. > [-- Attachment #2: Type: text/html, Size: 534 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] gnu: Add urwid 2015-02-01 23:23 ` Omar Radwan @ 2015-02-02 0:14 ` Omar Radwan 2015-02-02 2:32 ` Mark H Weaver 0 siblings, 1 reply; 14+ messages in thread From: Omar Radwan @ 2015-02-02 0:14 UTC (permalink / raw) To: guix-devel [-- Attachment #1.1: Type: text/plain, Size: 369 bytes --] Here it is. On Sun, Feb 1, 2015 at 3:23 PM, Omar Radwan <toxemicsquire4@gmail.com> wrote: > Wow. I was in such a hurry I forgot to add the patch file > On Feb 1, 2015 2:56 PM, "Omar Radwan" <toxemicsquire4@gmail.com> wrote: > >> Here is a patch to add urwid, which is required for wicd, which I will be >> working on tomorrow, and hopefully finish by next week. >> > [-- Attachment #1.2: Type: text/html, Size: 991 bytes --] [-- Attachment #2: 0001-gnu-Add-urwid.patch --] [-- Type: text/x-patch, Size: 1887 bytes --] From 7d65731aaec1b3dbca9364bc2b0f18c9fc9992e5 Mon Sep 17 00:00:00 2001 From: Omar Radwan <toxemicsquire4@gmail.com> Date: Sun, 1 Feb 2015 14:43:59 -0800 Subject: [PATCH] gnu: Add urwid * gnu/packages/python.scm(urwid) New variable. --- gnu/packages/python.scm | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index 4b30695..19016b4 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -5,7 +5,7 @@ ;;; Copyright © 2014 Mark H Weaver <mhw@netris.org> ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org> ;;; Copyright © 2014, 2015 Federico Beffa <beffa@fbengineering.ch> -;;; +;;; Copyright © 2015 Omar Radwan <toxemicsquire4@gmail.com> ;;; This file is part of GNU Guix. ;;; ;;; GNU Guix is free software; you can redistribute it and/or modify it @@ -2848,3 +2848,28 @@ and written in Python.") (define-public python2-html5lib (package-with-python2 python-html5lib)) + + +(define-public urwid + (package + (name "urwid") + (version "1.3.0") + (source + (origin + (method url-fetch) + (uri (string-append +"https://pkgs.fedoraproject.org/repo/pkgs/python-urwid/urwid-1.3.0.tar.gz/a989acd54f4ff1a554add464803a9175/urwid-1.3.0.tar.gz")) ;;upstream can't be used because Pypi don't have ETag headers in qoutes + (sha256 + (base32 + "18mb0yy94sjc434rd61m2sfnw27sa0nyrszpj5a9r9zh7fnlzw19")))) + (build-system python-build-system) + (inputs `(("python-2" ,python-2) + + ("python2-setuptools" ,python2-setuptools))) + (home-page "urwid.org/") + (synopsis "Console user interface library for Python") + (description + "Urwid is a console user interface library for python. It includes many features useful for text +console application") + (license lgpl2.1))) + -- 2.2.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] gnu: Add urwid 2015-02-02 0:14 ` Omar Radwan @ 2015-02-02 2:32 ` Mark H Weaver 2015-02-02 4:57 ` Omar Radwan 0 siblings, 1 reply; 14+ messages in thread From: Mark H Weaver @ 2015-02-02 2:32 UTC (permalink / raw) To: Omar Radwan; +Cc: guix-devel Omar Radwan <toxemicsquire4@gmail.com> writes: > From 7d65731aaec1b3dbca9364bc2b0f18c9fc9992e5 Mon Sep 17 00:00:00 2001 > From: Omar Radwan <toxemicsquire4@gmail.com> > Date: Sun, 1 Feb 2015 14:43:59 -0800 > Subject: [PATCH] gnu: Add urwid Minor nits: add a period above, and: > * gnu/packages/python.scm(urwid) New variable. This should be: * gnu/packages/python.scm (urwid): New variable. (add missing space and colon) > --- > gnu/packages/python.scm | 27 ++++++++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index 4b30695..19016b4 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -5,7 +5,7 @@ > ;;; Copyright © 2014 Mark H Weaver <mhw@netris.org> > ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org> > ;;; Copyright © 2014, 2015 Federico Beffa <beffa@fbengineering.ch> > -;;; > +;;; Copyright © 2015 Omar Radwan <toxemicsquire4@gmail.com> > ;;; This file is part of GNU Guix. Please keep the blank line below the copyright notices. More importantly, the encoding of the "©" is getting munged somewhere, so this patch won't apply cleanly. > ;;; > ;;; GNU Guix is free software; you can redistribute it and/or modify it > @@ -2848,3 +2848,28 @@ and written in Python.") > > (define-public python2-html5lib > (package-with-python2 python-html5lib)) > + > + > +(define-public urwid > + (package > + (name "urwid") > + (version "1.3.0") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > +"https://pkgs.fedoraproject.org/repo/pkgs/python-urwid/urwid-1.3.0.tar.gz/a989acd54f4ff1a554add464803a9175/urwid-1.3.0.tar.gz")) ;;upstream can't be used because Pypi don't have ETag headers in qoutes How about this instead: (uri (list (string-append "https://pypi.python.org/packages/source/u/urwid/urwid-" version ".tar.gz") ;; Downloading from the upstream URI above fails due to an ;; invalid ETag header. "https://pkgs.fedoraproject.org/repo/pkgs/python-urwid/urwid-1.3.0.tar.gz/a989acd54f4ff1a554add464803a9175/urwid-1.3.0.tar.gz")) This first tries to download from the canonical upstream URL, in case they fix their ETag headers, but falls back to the Fedora mirror. > + (sha256 > + (base32 > + "18mb0yy94sjc434rd61m2sfnw27sa0nyrszpj5a9r9zh7fnlzw19")))) > + (build-system python-build-system) > + (inputs `(("python-2" ,python-2) > + > + ("python2-setuptools" ,python2-setuptools))) When using 'python-build-system', instead of adding python-2 as an input, we should do this instead: (arguments `(#:python ,python-2)) And 'python2-setuptools' should be a native-input: (native-inputs `(("python2-setuptools" ,python2-setuptools))) > + (home-page "urwid.org/") This should be a valid URL; in this case: (home-page "http://urwid.org") > + (synopsis "Console user interface library for Python") > + (description > + "Urwid is a console user interface library for python. It includes many features useful for text > +console application") Double-space between sentences, keep lines < 80 columns, and add an "s" and period at the end, e.g.: (description "Urwid is a console user interface library for python. It includes many features useful for text console applications.") > + (license lgpl2.1))) > + Can you send an updated patch? Thanks! Mark ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] gnu: Add urwid 2015-02-02 2:32 ` Mark H Weaver @ 2015-02-02 4:57 ` Omar Radwan 2015-02-02 5:42 ` Mark H Weaver 0 siblings, 1 reply; 14+ messages in thread From: Omar Radwan @ 2015-02-02 4:57 UTC (permalink / raw) To: Mark H Weaver; +Cc: guix-devel [-- Attachment #1.1: Type: text/plain, Size: 4030 bytes --] Here's a patch that does all the changes you requested to the previous patch file On Sun, Feb 1, 2015 at 6:32 PM, Mark H Weaver <mhw@netris.org> wrote: > Omar Radwan <toxemicsquire4@gmail.com> writes: > > > From 7d65731aaec1b3dbca9364bc2b0f18c9fc9992e5 Mon Sep 17 00:00:00 2001 > > From: Omar Radwan <toxemicsquire4@gmail.com> > > Date: Sun, 1 Feb 2015 14:43:59 -0800 > > Subject: [PATCH] gnu: Add urwid > > Minor nits: add a period above, and: > > > * gnu/packages/python.scm(urwid) New variable. > > This should be: > > * gnu/packages/python.scm (urwid): New variable. > > (add missing space and colon) > > > --- > > gnu/packages/python.scm | 27 ++++++++++++++++++++++++++- > > 1 file changed, 26 insertions(+), 1 deletion(-) > > > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > > index 4b30695..19016b4 100644 > > --- a/gnu/packages/python.scm > > +++ b/gnu/packages/python.scm > > @@ -5,7 +5,7 @@ > > ;;; Copyright © 2014 Mark H Weaver <mhw@netris.org> > > ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org> > > ;;; Copyright © 2014, 2015 Federico Beffa <beffa@fbengineering.ch> > > -;;; > > +;;; Copyright © 2015 Omar Radwan <toxemicsquire4@gmail.com> > > ;;; This file is part of GNU Guix. > > Please keep the blank line below the copyright notices. > > More importantly, the encoding of the "©" is getting munged somewhere, > so this patch won't apply cleanly. > > > ;;; > > ;;; GNU Guix is free software; you can redistribute it and/or modify it > > @@ -2848,3 +2848,28 @@ and written in Python.") > > > > (define-public python2-html5lib > > (package-with-python2 python-html5lib)) > > + > > + > > +(define-public urwid > > + (package > > + (name "urwid") > > + (version "1.3.0") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append > > +" > https://pkgs.fedoraproject.org/repo/pkgs/python-urwid/urwid-1.3.0.tar.gz/a989acd54f4ff1a554add464803a9175/urwid-1.3.0.tar.gz")) > ;;upstream can't be used because Pypi don't have ETag headers in qoutes > > How about this instead: > > (uri (list (string-append > "https://pypi.python.org/packages/source/u/urwid/urwid-" > version ".tar.gz") > ;; Downloading from the upstream URI above fails due to an > ;; invalid ETag header. > " > https://pkgs.fedoraproject.org/repo/pkgs/python-urwid/urwid-1.3.0.tar.gz/a989acd54f4ff1a554add464803a9175/urwid-1.3.0.tar.gz > ")) > > This first tries to download from the canonical upstream URL, in case > they fix their ETag headers, but falls back to the Fedora mirror. > > > + (sha256 > > + (base32 > > + "18mb0yy94sjc434rd61m2sfnw27sa0nyrszpj5a9r9zh7fnlzw19")))) > > + (build-system python-build-system) > > + (inputs `(("python-2" ,python-2) > > + > > + ("python2-setuptools" ,python2-setuptools))) > > When using 'python-build-system', instead of adding python-2 as an > input, we should do this instead: > > (arguments `(#:python ,python-2)) > > And 'python2-setuptools' should be a native-input: > > (native-inputs `(("python2-setuptools" ,python2-setuptools))) > > > + (home-page "urwid.org/") > > This should be a valid URL; in this case: > > (home-page "http://urwid.org") > > > + (synopsis "Console user interface library for Python") > > + (description > > + "Urwid is a console user interface library for python. It includes > many features useful for text > > +console application") > > Double-space between sentences, keep lines < 80 columns, and add an "s" > and period at the end, e.g.: > > (description > "Urwid is a console user interface library for python. It includes > many > features useful for text console applications.") > > > + (license lgpl2.1))) > > + > > Can you send an updated patch? > > Thanks! > Mark > [-- Attachment #1.2: Type: text/html, Size: 5872 bytes --] [-- Attachment #2: 0002-gnu-Add-urwid.patch --] [-- Type: text/x-patch, Size: 2275 bytes --] From e4226f8ac4ae23835aa5f57808d3f2063a131d84 Mon Sep 17 00:00:00 2001 From: Omar Radwan <toxemicsquire4@gmail.com> Date: Sun, 1 Feb 2015 20:40:22 -0800 Subject: [PATCH 2/2] gnu: Add urwid * gnu/packages/python.scm (urwid): New Variable --- gnu/packages/python.scm | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index 19016b4..1e44dbb 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -6,6 +6,7 @@ ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org> ;;; Copyright © 2014, 2015 Federico Beffa <beffa@fbengineering.ch> ;;; Copyright © 2015 Omar Radwan <toxemicsquire4@gmail.com> + ;;; This file is part of GNU Guix. ;;; ;;; GNU Guix is free software; you can redistribute it and/or modify it @@ -2857,19 +2858,20 @@ and written in Python.") (source (origin (method url-fetch) - (uri (string-append -"https://pkgs.fedoraproject.org/repo/pkgs/python-urwid/urwid-1.3.0.tar.gz/a989acd54f4ff1a554add464803a9175/urwid-1.3.0.tar.gz")) ;;upstream can't be used because Pypi don't have ETag headers in qoutes + (uri (list (string-append "https:/pypi.python.org/packages/source/u/urwid/urwid-"version".tar.gz") + ;;Downloading from the upstream URI above fails die to an invalid ETag header. +"https://pkgs.fedoraproject.org/repo/pkgs/python-urwid/urwid-1.3.0.tar.gz/a989acd54f4ff1a554add464803a9175/urwid-1.3.0.tar.gz")) (sha256 (base32 "18mb0yy94sjc434rd61m2sfnw27sa0nyrszpj5a9r9zh7fnlzw19")))) (build-system python-build-system) - (inputs `(("python-2" ,python-2) - - ("python2-setuptools" ,python2-setuptools))) - (home-page "urwid.org/") + (arguements `(("python-2" ,python-2))) + (native-imputs `(("python2-setuptools" ,python2-setuptools))) + (home-page "http://urwid.org/") (synopsis "Console user interface library for Python") (description - "Urwid is a console user interface library for python. It includes many features useful for text -console application") + "Urwid is a console user interface library for python. It + includes many features useful for text +console applications.") (license lgpl2.1))) -- 2.2.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] gnu: Add urwid 2015-02-02 4:57 ` Omar Radwan @ 2015-02-02 5:42 ` Mark H Weaver 2015-02-02 17:46 ` Omar Radwan 0 siblings, 1 reply; 14+ messages in thread From: Mark H Weaver @ 2015-02-02 5:42 UTC (permalink / raw) To: Omar Radwan; +Cc: guix-devel Omar Radwan <toxemicsquire4@gmail.com> writes: > Here's a patch that does all the changes you requested to the previous > patch file A few problems here: (1) This new version doesn't even compile, because of several typos. Please always test before sending patches. (2) Instead of sending a patch that assumes the first version of your patch has been applied, please send a patch that can be applied by itself. (3) In the description, don't put two spaces between every two words, just between sentences. (4) In the source URI specification, please follow our Scheme indentation and spacing conventions, as I showed in my last message in this thread. Can you send an updated patch? Mark ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] gnu: Add urwid 2015-02-02 5:42 ` Mark H Weaver @ 2015-02-02 17:46 ` Omar Radwan 2015-02-02 17:59 ` Andreas Enge 0 siblings, 1 reply; 14+ messages in thread From: Omar Radwan @ 2015-02-02 17:46 UTC (permalink / raw) To: Mark H Weaver; +Cc: guix-devel [-- Attachment #1: Type: text/plain, Size: 885 bytes --] My mistake. I was in such a hurry. I'll get it in asap On Feb 1, 2015 9:42 PM, "Mark H Weaver" <mhw@netris.org> wrote: > Omar Radwan <toxemicsquire4@gmail.com> writes: > > Here's a patch that does all the changes you requested to the previous > > patch file > > A few problems here: > > (1) This new version doesn't even compile, because of several typos. > Please always test before sending patches. > > (2) Instead of sending a patch that assumes the first version of your > patch has been applied, please send a patch that can be applied by > itself. > > (3) In the description, don't put two spaces between every two words, > just between sentences. > > (4) In the source URI specification, please follow our Scheme > indentation and spacing conventions, as I showed in my last message > in this thread. > > Can you send an updated patch? > > Mark > [-- Attachment #2: Type: text/html, Size: 1287 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] gnu: Add urwid 2015-02-02 17:46 ` Omar Radwan @ 2015-02-02 17:59 ` Andreas Enge 2015-02-03 3:37 ` Omar Radwan 0 siblings, 1 reply; 14+ messages in thread From: Andreas Enge @ 2015-02-02 17:59 UTC (permalink / raw) To: Omar Radwan; +Cc: guix-devel On Mon, Feb 02, 2015 at 09:46:10AM -0800, Omar Radwan wrote: > I was in such a hurry. I'll get it in asap That sounds like a contradiction! Take your time ;-) You may also want to run "./pre-inst-env guix lint PACKAGE" before you submit your patch, it catches some common problems. Andreas ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] gnu: Add urwid 2015-02-02 17:59 ` Andreas Enge @ 2015-02-03 3:37 ` Omar Radwan 2015-02-03 4:42 ` Mark H Weaver 0 siblings, 1 reply; 14+ messages in thread From: Omar Radwan @ 2015-02-03 3:37 UTC (permalink / raw) To: Andreas Enge; +Cc: guix-devel [-- Attachment #1.1: Type: text/plain, Size: 694 bytes --] Here is it, finally I hope this is good enough. And by the way, you asked for me to do this > (arguments `(#:python ,python-2)) instead of what I did before, but that gives me an error, so I can't build it, so I hope it's ok if I leave it the way it is. But I did put python2-setuptools in native-inputs On Mon, Feb 2, 2015 at 9:59 AM, Andreas Enge <andreas@enge.fr> wrote: > On Mon, Feb 02, 2015 at 09:46:10AM -0800, Omar Radwan wrote: > > I was in such a hurry. I'll get it in asap > > That sounds like a contradiction! Take your time ;-) > > You may also want to run "./pre-inst-env guix lint PACKAGE" > before you submit your patch, it catches some common problems. > > Andreas > > [-- Attachment #1.2: Type: text/html, Size: 1260 bytes --] [-- Attachment #2: 0001-gnu-Add-urwid.patch --] [-- Type: text/x-patch, Size: 2408 bytes --] From 7d9f79c3e4b6e4121c0304d5da3995a2f3473fe0 Mon Sep 17 00:00:00 2001 From: Omar Radwan <toxemicsquire4@gmail.com> Date: Mon, 2 Feb 2015 18:28:21 -0800 Subject: [PATCH] gnu: Add urwid * gnu/packages/python.scm (urwid): New Variable. --- gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index 95b4ee4..8a7f105 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -5,7 +5,8 @@ ;;; Copyright © 2014 Mark H Weaver <mhw@netris.org> ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org> ;;; Copyright © 2014, 2015 Federico Beffa <beffa@fbengineering.ch> -;;; +;;; Copyright © 2015 Omar Radwan <toxemicsquire4@gmail.com> + ;;; This file is part of GNU Guix. ;;; ;;; GNU Guix is free software; you can redistribute it and/or modify it @@ -2192,7 +2193,7 @@ that client code uses to construct the grammar directly in Python code.") ("freetype" ,freetype) ("cairo" ,cairo) ("glib" ,glib) - ("python-pillow" ,python-pillow) + ;("python-pillow" ,python-pillow) ;; FIXME: Add backends when available. ;("python-wxpython" ,python-wxpython) ;("python-pyqt" ,python-pyqt) @@ -2848,3 +2849,28 @@ and written in Python.") (define-public python2-html5lib (package-with-python2 python-html5lib)) + + +(define-public urwid + (package + (name "urwid") + (version "1.3.0") + (source + (origin + (method url-fetch) + (uri (list (string-append + "https://pypi.python.org/packages/source/u/urwid/urwid-"version".tar.gz") + ;;Downloading from the upstream URI above fails due to an + ;; invalid ETag header. + "https://pkgs.fedoraproject.org/repo/pkgs/python-urwid/urwid-1.3.0.tar.gz/ + a989acd54f4ff1a554add464803a9175/urwid-1.3.0.tar.gz")) + (sha256 + (base32 + "18mb0yy94sjc434rd61m2sfnw27sa0nyrszpj5a9r9zh7fnlzw19")))) + (build-system python-build-system) + (inputs `(("python" ,python)("python-2" ,python-2))) + (native-inputs `(("python2-setuptools" ,python2-setuptools))) + (home-page "http://urwid.org") + (synopsis "Console user interface library for Python") + (description "Urwid is a console user interface library for python. + It includes many features useful for text console application.") + (license lgpl2.1))) + -- 2.2.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] gnu: Add urwid 2015-02-03 3:37 ` Omar Radwan @ 2015-02-03 4:42 ` Mark H Weaver 2015-02-03 4:48 ` Omar Radwan 0 siblings, 1 reply; 14+ messages in thread From: Mark H Weaver @ 2015-02-03 4:42 UTC (permalink / raw) To: Omar Radwan; +Cc: guix-devel Omar Radwan <toxemicsquire4@gmail.com> writes: > Here is it, finally I hope this is good enough. > > And by the way, you asked for me to do this > >> (arguments `(#:python ,python-2)) > > instead of what I did before, but that gives me an error, so I can't > build it, so I hope it's ok if I leave it the way it is. What was the error? I tested the package with all of the modifications I suggested, including this one, and it built successfully on my i686 machine. Mark ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] gnu: Add urwid 2015-02-03 4:42 ` Mark H Weaver @ 2015-02-03 4:48 ` Omar Radwan 2015-02-03 5:37 ` Mark H Weaver 0 siblings, 1 reply; 14+ messages in thread From: Omar Radwan @ 2015-02-03 4:48 UTC (permalink / raw) To: Mark H Weaver; +Cc: guix-devel [-- Attachment #1: Type: text/plain, Size: 890 bytes --] >What was the error? I tested the >package with all of the modifications >I suggested, including this one, and it >built successfully on my i686 >machine. It didn't build on my 64bit machine. And just to be clear. I tried to substitute it for inputs and that didn't work. Was I supposed to put it inside inputs? On Feb 2, 2015 8:45 PM, "Mark H Weaver" <mhw@netris.org> wrote: > Omar Radwan <toxemicsquire4@gmail.com> writes: > > > Here is it, finally I hope this is good enough. > > > > And by the way, you asked for me to do this > > > >> (arguments `(#:python ,python-2)) > > > > instead of what I did before, but that gives me an error, so I can't > > build it, so I hope it's ok if I leave it the way it is. > > What was the error? I tested the package with all of the modifications > I suggested, including this one, and it built successfully on my i686 > machine. > > Mark > [-- Attachment #2: Type: text/html, Size: 1308 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] gnu: Add urwid 2015-02-03 4:48 ` Omar Radwan @ 2015-02-03 5:37 ` Mark H Weaver 2015-02-03 17:20 ` Omar Radwan 0 siblings, 1 reply; 14+ messages in thread From: Mark H Weaver @ 2015-02-03 5:37 UTC (permalink / raw) To: Omar Radwan; +Cc: guix-devel Omar Radwan <toxemicsquire4@gmail.com> writes: >>What was the error? I tested the >package with all of the > modifications >>I suggested, including this one, and it >built successfully on my > i686 >>machine. > It didn't build on my 64bit machine. And just to be clear. I tried to > substitute it for inputs and that didn't work. Was I supposed to put > it inside inputs? I'm sorry, but we are failing to communicate, and I don't have any more time to spend on this. I have pushed commit e99f421185 based on your preliminary work. It adds two packages: python-urwid for Python 3, and python2-urwid for Python 2. Thanks, Mark ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] gnu: Add urwid 2015-02-03 5:37 ` Mark H Weaver @ 2015-02-03 17:20 ` Omar Radwan 2015-02-03 21:07 ` Ludovic Courtès 0 siblings, 1 reply; 14+ messages in thread From: Omar Radwan @ 2015-02-03 17:20 UTC (permalink / raw) To: Mark H Weaver; +Cc: guix-devel [-- Attachment #1: Type: text/plain, Size: 1108 bytes --] >I'm sorry, but we are failing to >communicate, and I don't have any >more >time to spend on this. I have pushed >commit e99f421185 based on your >preliminary work. It adds two >packages: python-urwid for Python 3, >and >python2-urwid for Python 2. Sorry for the miscommunication. I'll do better next time. Thanks for the commit push. I can start working on wicd On Feb 2, 2015 9:37 PM, "Mark H Weaver" <mhw@netris.org> wrote: > Omar Radwan <toxemicsquire4@gmail.com> writes: > > >>What was the error? I tested the >package with all of the > > modifications > >>I suggested, including this one, and it >built successfully on my > > i686 > >>machine. > > It didn't build on my 64bit machine. And just to be clear. I tried to > > substitute it for inputs and that didn't work. Was I supposed to put > > it inside inputs? > > I'm sorry, but we are failing to communicate, and I don't have any more > time to spend on this. I have pushed commit e99f421185 based on your > preliminary work. It adds two packages: python-urwid for Python 3, and > python2-urwid for Python 2. > > Thanks, > Mark > [-- Attachment #2: Type: text/html, Size: 1591 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] gnu: Add urwid 2015-02-03 17:20 ` Omar Radwan @ 2015-02-03 21:07 ` Ludovic Courtès 0 siblings, 0 replies; 14+ messages in thread From: Ludovic Courtès @ 2015-02-03 21:07 UTC (permalink / raw) To: Omar Radwan; +Cc: guix-devel Omar Radwan <toxemicsquire4@gmail.com> skribis: >>I'm sorry, but we are failing to >communicate, and I don't have any >more >>time to spend on this. I have pushed >commit e99f421185 based on your >>preliminary work. It adds two >packages: python-urwid for Python 3, >and >>python2-urwid for Python 2. > > Sorry for the miscommunication. I'll do better next time. Thanks for the > commit push. I can start working on wicd Cool. Thanks for urwid, and thanks to Mark for helping out! One way to avoid miscommunication in the future would be to read the “Submitting Patches” section in ‘HACKING’ and to look at existing commits for the conventions to follow. Another thing would be to avoid HTML emails and top-posting, which are inconvenient for the reader. Ludo’. ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2015-02-03 21:07 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-02-01 22:56 [PATCH] gnu: Add urwid Omar Radwan 2015-02-01 23:23 ` Omar Radwan 2015-02-02 0:14 ` Omar Radwan 2015-02-02 2:32 ` Mark H Weaver 2015-02-02 4:57 ` Omar Radwan 2015-02-02 5:42 ` Mark H Weaver 2015-02-02 17:46 ` Omar Radwan 2015-02-02 17:59 ` Andreas Enge 2015-02-03 3:37 ` Omar Radwan 2015-02-03 4:42 ` Mark H Weaver 2015-02-03 4:48 ` Omar Radwan 2015-02-03 5:37 ` Mark H Weaver 2015-02-03 17:20 ` Omar Radwan 2015-02-03 21:07 ` Ludovic Courtès
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/guix.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.