From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vicente Vera Subject: Re: [PATCH 04/19] gnu: Add r-bh. Date: Mon, 14 Sep 2015 16:43:14 -0300 Message-ID: References: <87fv2h8ecn.fsf@mdc-berlin.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=e89a8ff1ccc2bce8e9051fba460e Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbZem-0007lF-J0 for guix-devel@gnu.org; Mon, 14 Sep 2015 15:43:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbZel-0001CN-8F for guix-devel@gnu.org; Mon, 14 Sep 2015 15:43:16 -0400 Received: from mail-ob0-x231.google.com ([2607:f8b0:4003:c01::231]:36315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbZel-0001CF-3E for guix-devel@gnu.org; Mon, 14 Sep 2015 15:43:15 -0400 Received: by obqa2 with SMTP id a2so117553309obq.3 for ; Mon, 14 Sep 2015 12:43:14 -0700 (PDT) In-Reply-To: <87fv2h8ecn.fsf@mdc-berlin.de> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --e89a8ff1ccc2bce8e9051fba460e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello, I don't know if the boost package in the distribution could be used to comply with the requirements. IMO it is safer to incorporate r-bh as it is needed by dplyr. New patch with corrections attached. 2015-09-14 7:50 GMT-03:00 Ricardo Wurmus : > >> * gnu/packages/statistics.scm (r-bh): New variable. > > [...] > >> + (synopsis "Boost C++ Header Files") >> + (description >> + "Boost provides free peer-reviewed portable C++ source libraries. >> +A large part of Boost is provided as C++ template code which is >> +resolved entirely at compile-time without linking. This package aims >> +to provide the most useful subset of Boost libraries for template use >> +among CRAN package. By placing these libraries in this package, we >> +offer a more efficient distribution system for CRAN as replication of >> +this code in the sources of other packages is avoided.") >> + (license license:boost1.0))) > > It seems ugly to duplicate the Boost headers in a separate package. We > already have a =E2=80=9Cboost=E2=80=9D package, which provides the header= s for this > version of Boost. Would it be possible to use the existing =E2=80=9Cboos= t=E2=80=9D > package in place of =E2=80=9Cr-bh=E2=80=9D? > > If not: please use two spaces in the description. I think the first two > sentences can be removed as they relate to the Boost library. Also, > please use lower case for the synopsis. > > ~~ Ricardo --e89a8ff1ccc2bce8e9051fba460e Content-Type: text/x-patch; charset=US-ASCII; name="0004-gnu-Add-r-bh.patch" Content-Disposition: attachment; filename="0004-gnu-Add-r-bh.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iekc8eda0 RnJvbSBlNjljY2VjNGNjYjk3OWMzNGYxOWFjNjc4M2RhOGQxNmJkMzM4ZDkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWNlbnRlIFZlcmEgUGFycmEgPHZpY2VudGVtdnBAZ21haWwu Y29tPgpEYXRlOiBNb24sIDE0IFNlcCAyMDE1IDE0OjM5OjMwIC0wMzAwClN1YmplY3Q6IFtQQVRD SCAwNC8xMl0gZ251OiBBZGQgci1iaC4KCiogZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Muc2NtIChy LWJoKTogTmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9zdGF0aXN0aWNzLnNjbSB8IDIw ICsrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKQoK ZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9zdGF0aXN0aWNzLnNjbSBiL2dudS9wYWNrYWdlcy9z dGF0aXN0aWNzLnNjbQppbmRleCA1YjI5ZjZmLi4xZWZhY2RlIDEwMDY0NAotLS0gYS9nbnUvcGFj a2FnZXMvc3RhdGlzdGljcy5zY20KKysrIGIvZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Muc2NtCkBA IC01NTYsMyArNTU2LDIzIEBAIGNvbW11bmljYXRpb24gYmV0d2VlbiBSIGFuZCByZWxhdGlvbmFs IGRhdGFiYXNlIG1hbmFnZW1lbnQgc3lzdGVtcy4gIEFsbAogY2xhc3NlcyBpbiB0aGlzIHBhY2th Z2UgYXJlIHZpcnR1YWwgYW5kIG5lZWQgdG8gYmUgZXh0ZW5kZWQgYnkgdGhlIHZhcmlvdXMKIFIv REJNUyBpbXBsZW1lbnRhdGlvbnMuIikKICAgICAobGljZW5zZSBsaWNlbnNlOmxncGwzKykpKQor CisoZGVmaW5lLXB1YmxpYyByLWJoCisgIChwYWNrYWdlCisgICAgKG5hbWUgInItYmgiKQorICAg ICh2ZXJzaW9uICIxLjU4LjAtMSIpCisgICAgKHNvdXJjZSAob3JpZ2luCisgICAgICAgICAgICAg IChtZXRob2QgdXJsLWZldGNoKQorICAgICAgICAgICAgICAodXJpIChzdHJpbmctYXBwZW5kICJt aXJyb3I6Ly9jcmFuL3NyYy9jb250cmliL0JIXyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB2ZXJzaW9uICIudGFyLmd6IikpCisgICAgICAgICAgICAgIChzaGEyNTYKKyAgICAg ICAgICAgICAgIChiYXNlMzIgIjE3cm53eXc5aWIycHZtNjBpaXh6a2J6N2ZmNGZzbHBpZnAxbmx4 NGN6cDQyaHk2N2txcGYiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gci1idWlsZC1zeXN0ZW0pCisg ICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9naXRodWIuY29tL2VkZGVsYnVldHRlbC9iaCIpCisgICAg KHN5bm9wc2lzICJCb29zdCBDKysgaGVhZGVyIGZpbGVzIikKKyAgICAoZGVzY3JpcHRpb24KKyAg ICAgIlRoaXMgcGFja2FnZSBhaW1zIHRvIHByb3ZpZGUgdGhlIG1vc3QgdXNlZnVsIHN1YnNldCBv ZiBCb29zdCBsaWJyYXJpZXMKK2ZvciB0ZW1wbGF0ZSB1c2UgYW1vbmcgQ1JBTiBwYWNrYWdlcy4g IEJ5IHBsYWNpbmcgdGhlc2UgbGlicmFyaWVzIGluIHRoaXMKK3BhY2thZ2UsIHdlIG9mZmVyIGEg bW9yZSBlZmZpY2llbnQgZGlzdHJpYnV0aW9uIHN5c3RlbSBmb3IgQ1JBTiBhcyByZXBsaWNhdGlv bgorb2YgdGhpcyBjb2RlIGluIHRoZSBzb3VyY2VzIG9mIG90aGVyIHBhY2thZ2VzIGlzIGF2b2lk ZWQuIikKKyAgICAobGljZW5zZSBsaWNlbnNlOmJvb3N0MS4wKSkpCi0tIAoyLjUuMgoK --e89a8ff1ccc2bce8e9051fba460e--