Re: [PATCH 04/19] gnu: Add r-bh.

[Vicente Vera <vicentemvp@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]

Hello,

I don't know if the boost package in the distribution could be used to
comply with the requirements. IMO it is safer to incorporate r-bh as
it is needed by dplyr.

New patch with corrections attached.

2015-09-14 7:50 GMT-03:00 Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>:
>
>> * gnu/packages/statistics.scm (r-bh): New variable.
>
> [...]
>
>> +    (synopsis "Boost C++ Header Files")
>> +    (description
>> +     "Boost provides free peer-reviewed portable C++ source libraries.
>> +A large part of Boost is provided as C++ template code which is
>> +resolved entirely at compile-time without linking. This package aims
>> +to provide the most useful subset of Boost libraries for template use
>> +among CRAN package. By placing these libraries in this package, we
>> +offer a more efficient distribution system for CRAN as replication of
>> +this code in the sources of other packages is avoided.")
>> +    (license license:boost1.0)))
>
> It seems ugly to duplicate the Boost headers in a separate package.  We
> already have a “boost” package, which provides the headers for this
> version of Boost.  Would it be possible to use the existing “boost”
> package in place of “r-bh”?
>
> If not: please use two spaces in the description.  I think the first two
> sentences can be removed as they relate to the Boost library.  Also,
> please use lower case for the synopsis.
>
> ~~ Ricardo

[-- Attachment #2: 0004-gnu-Add-r-bh.patch --]
[-- Type: text/x-patch, Size: 1590 bytes --]

From e69ccec4ccb979c34f19ac6783da8d16bd338d90 Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Mon, 14 Sep 2015 14:39:30 -0300
Subject: [PATCH 04/12] gnu: Add r-bh.

* gnu/packages/statistics.scm (r-bh): New variable.
---
 gnu/packages/statistics.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 5b29f6f..1efacde 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -556,3 +556,23 @@ communication between R and relational database management systems.  All
 classes in this package are virtual and need to be extended by the various
 R/DBMS implementations.")
     (license license:lgpl3+)))
+
+(define-public r-bh
+  (package
+    (name "r-bh")
+    (version "1.58.0-1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://cran/src/contrib/BH_"
+                                  version ".tar.gz"))
+              (sha256
+               (base32 "17rnwyw9ib2pvm60iixzkbz7ff4fslpifp1nlx4czp42hy67kqpf"))))
+    (build-system r-build-system)
+    (home-page "https://github.com/eddelbuettel/bh")
+    (synopsis "Boost C++ header files")
+    (description
+     "This package aims to provide the most useful subset of Boost libraries
+for template use among CRAN packages.  By placing these libraries in this
+package, we offer a more efficient distribution system for CRAN as replication
+of this code in the sources of other packages is avoided.")
+    (license license:boost1.0)))
-- 
2.5.2