From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vicente Vera Subject: Re: [PATCH 02/19] gnu: Add r-lazyeval. Date: Tue, 15 Sep 2015 14:33:22 -0300 Message-ID: References: <87io7d8en7.fsf@mdc-berlin.de> <87y4g77nhh.fsf@mdc-berlin.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e0118424020d8f2051fcc94f7 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbu6e-0005QH-Tl for guix-devel@gnu.org; Tue, 15 Sep 2015 13:33:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zbu6d-0003Md-Jw for guix-devel@gnu.org; Tue, 15 Sep 2015 13:33:24 -0400 Received: from mail-ob0-x229.google.com ([2607:f8b0:4003:c01::229]:34531) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbu6d-0003MV-9x for guix-devel@gnu.org; Tue, 15 Sep 2015 13:33:23 -0400 Received: by obbda8 with SMTP id da8so141044178obb.1 for ; Tue, 15 Sep 2015 10:33:22 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --089e0118424020d8f2051fcc94f7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Updated patch attached. 2015-09-15 12:31 GMT-03:00 Vicente Vera : > Hi, > > Glad to hear the patches helped! > > I've been fixing most of the issues (sentences with double spaces, > long lines) in all the patches. If you don't mind the extra time, I'll > attach the corrected patches in the next hours. > > 2015-09-15 11:42 GMT-03:00 Ricardo Wurmus : >> Hi Vicente, >> >>> Actually, nearly every synopsis and description in these patches are >>> taken verbatim from CRAN. >> >> That=E2=80=99s what I thought. When I prepared my initial patches for R= modules >> to test the CRAN importer I found that I needed to edit both synopsis >> and description for every package. The quality of descriptions is >> certainly better than for the average CPAN package, but it still >> requires editing to fit in with the rest of the Guix packages. >> >>> I'm not familiar enough with this package to amend the description >>> provided by the author, so I replaced it with the one offered in the >>> package's GitHub repository. >> >> That=E2=80=99s okay. >> >>> Upper-case characters corrected. >>> >>> New patch attached. >> >> Thank you! >> >> I think it=E2=80=99s okay, except maybe for the slightly overlong line >> containing the hash. Unless there are objections I=E2=80=99d like to pu= sh this >> tonight (after dropping the hash to its own line). >> >> ~~ Ricardo >> >> >> PS: I=E2=80=99m wrapping up a project at a bioinfo hackathon and your pa= tches >> were very helpful as I had trouble installing dplyr via R. Your patches >> made this much simpler, so thank you very much! --089e0118424020d8f2051fcc94f7 Content-Type: text/x-patch; charset=US-ASCII; name="0002-gnu-Add-r-lazyeval.patch" Content-Disposition: attachment; filename="0002-gnu-Add-r-lazyeval.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ieln13uq0 RnJvbSA0OGVlZTYyMjU2MWVhZWY5ZTk0MTE5MWI4ZTAxZjE2ZjA1NjQzZWE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWNlbnRlIFZlcmEgUGFycmEgPHZpY2VudGVtdnBAZ21haWwu Y29tPgpEYXRlOiBUdWUsIDE1IFNlcCAyMDE1IDE0OjEyOjMyIC0wMzAwClN1YmplY3Q6IFtQQVRD SCAwMi8xOV0gZ251OiBBZGQgci1sYXp5ZXZhbC4KCiogZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Mu c2NtIChyLWxhenlldmFsKTogTmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9zdGF0aXN0 aWNzLnNjbSB8IDIxICsrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDIxIGlu c2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvc3RhdGlzdGljcy5zY20gYi9n bnUvcGFja2FnZXMvc3RhdGlzdGljcy5zY20KaW5kZXggOWE3M2E4Mi4uMjJkODI5MCAxMDA2NDQK LS0tIGEvZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Muc2NtCisrKyBiL2dudS9wYWNrYWdlcy9zdGF0 aXN0aWNzLnNjbQpAQCAtNTIyLDMgKzUyMiwyNCBAQCB0aGUgcHJlIGFuZCBwb3N0IGNvbmRpdGlv bnMgdGhhdCB5b3VyIGNvZGUgc2hvdWxkIHNhdGlzZnksIHdoaWxlIGFsc28KIHByb2R1Y2luZyBm cmllbmRseSBlcnJvciBtZXNzYWdlcyBzbyB0aGF0IHlvdXIgdXNlcnMga25vdyB3aGF0IHRoZXkn dmUgZG9uZQogd3JvbmcuIikKICAgICAobGljZW5zZSBsaWNlbnNlOmdwbDMrKSkpCisKKyhkZWZp bmUtcHVibGljIHItbGF6eWV2YWwKKyAgKHBhY2thZ2UKKyAgICAobmFtZSAici1sYXp5ZXZhbCIp CisgICAgKHZlcnNpb24gIjAuMS4xMCIpCisgICAgKHNvdXJjZSAob3JpZ2luCisgICAgICAgICAg ICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAgICAgICAgICAodXJpIChzdHJpbmctYXBwZW5k ICJtaXJyb3I6Ly9jcmFuL3NyYy9jb250cmliL2xhenlldmFsXyIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB2ZXJzaW9uICIudGFyLmd6IikpCisgICAgICAgICAgICAgIChzaGEy NTYKKyAgICAgICAgICAgICAgIChiYXNlMzIKKyAgICAgICAgICAgICAgICAiMDJxZnBuMmZteTc4 dng0anhyN2c3cmhxemNtMWtjaXZmd2FpN2xiaDB2dnBhd2lhMHF3aCIpKSkpCisgICAgKGJ1aWxk LXN5c3RlbSByLWJ1aWxkLXN5c3RlbSkKKyAgICAoaG9tZS1wYWdlCisgICAgICJodHRwczovL2dp dGh1Yi5jb20vaGFkbGV5L2xhenlldmFsIikKKyAgICAoc3lub3BzaXMKKyAgICAgIkxhenkgKG5v bi1zdGFuZGFyZCkgZXZhbHVhdGlvbiBpbiBSIikKKyAgICAoZGVzY3JpcHRpb24KKyAgICAgIlRo aXMgcGFja2FnZSBwcm92aWRlcyB0aGUgdG9vbHMgbmVjZXNzYXJ5IHRvIGRvIG5vbi1zdGFuZGFy ZAorZXZhbHVhdGlvbiAoTlNFKSBpbiBSLiIpCisgICAgKGxpY2Vuc2UgbGljZW5zZTpncGwzKykp KQotLSAKMi41LjIKCg== --089e0118424020d8f2051fcc94f7--