From: Vicente Vera <vicentemvp@gmail.com>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 02/19] gnu: Add r-lazyeval.
Date: Tue, 15 Sep 2015 14:33:22 -0300 [thread overview]
Message-ID: <CAMfbzvBJ8x88Hn+0fLMyp8K2cosqP=U9Q-SX9oTEceOuZe1=mA@mail.gmail.com> (raw)
In-Reply-To: <CAMfbzvCbYmJMFAgq6Atgyb33sGDa5a25-2t1nRJToq09J0iA+A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1641 bytes --]
Updated patch attached.
2015-09-15 12:31 GMT-03:00 Vicente Vera <vicentemvp@gmail.com>:
> Hi,
>
> Glad to hear the patches helped!
>
> I've been fixing most of the issues (sentences with double spaces,
> long lines) in all the patches. If you don't mind the extra time, I'll
> attach the corrected patches in the next hours.
>
> 2015-09-15 11:42 GMT-03:00 Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>:
>> Hi Vicente,
>>
>>> Actually, nearly every synopsis and description in these patches are
>>> taken verbatim from CRAN.
>>
>> That’s what I thought. When I prepared my initial patches for R modules
>> to test the CRAN importer I found that I needed to edit both synopsis
>> and description for every package. The quality of descriptions is
>> certainly better than for the average CPAN package, but it still
>> requires editing to fit in with the rest of the Guix packages.
>>
>>> I'm not familiar enough with this package to amend the description
>>> provided by the author, so I replaced it with the one offered in the
>>> package's GitHub repository.
>>
>> That’s okay.
>>
>>> Upper-case characters corrected.
>>>
>>> New patch attached.
>>
>> Thank you!
>>
>> I think it’s okay, except maybe for the slightly overlong line
>> containing the hash. Unless there are objections I’d like to push this
>> tonight (after dropping the hash to its own line).
>>
>> ~~ Ricardo
>>
>>
>> PS: I’m wrapping up a project at a bioinfo hackathon and your patches
>> were very helpful as I had trouble installing dplyr via R. Your patches
>> made this much simpler, so thank you very much!
[-- Attachment #2: 0002-gnu-Add-r-lazyeval.patch --]
[-- Type: text/x-patch, Size: 1438 bytes --]
From 48eee622561eaef9e941191b8e01f16f05643ea7 Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Tue, 15 Sep 2015 14:12:32 -0300
Subject: [PATCH 02/19] gnu: Add r-lazyeval.
* gnu/packages/statistics.scm (r-lazyeval): New variable.
---
gnu/packages/statistics.scm | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 9a73a82..22d8290 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -522,3 +522,24 @@ the pre and post conditions that your code should satisfy, while also
producing friendly error messages so that your users know what they've done
wrong.")
(license license:gpl3+)))
+
+(define-public r-lazyeval
+ (package
+ (name "r-lazyeval")
+ (version "0.1.10")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://cran/src/contrib/lazyeval_"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "02qfpn2fmy78vx4jxr7g7rhqzcm1kcivfwai7lbh0vvpawia0qwh"))))
+ (build-system r-build-system)
+ (home-page
+ "https://github.com/hadley/lazyeval")
+ (synopsis
+ "Lazy (non-standard) evaluation in R")
+ (description
+ "This package provides the tools necessary to do non-standard
+evaluation (NSE) in R.")
+ (license license:gpl3+)))
--
2.5.2
prev parent reply other threads:[~2015-09-15 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 16:45 [PATCH 02/19] gnu: Add r-lazyeval Vicente Vera
2015-09-14 10:43 ` Ricardo Wurmus
2015-09-14 19:34 ` Vicente Vera
2015-09-15 14:42 ` Ricardo Wurmus
2015-09-15 15:31 ` Vicente Vera
2015-09-15 17:33 ` Vicente Vera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMfbzvBJ8x88Hn+0fLMyp8K2cosqP=U9Q-SX9oTEceOuZe1=mA@mail.gmail.com' \
--to=vicentemvp@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.