From: Vicente Vera <vicentemvp@gmail.com>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 11/19] gnu: Add r-knitr.
Date: Tue, 15 Sep 2015 14:41:45 -0300 [thread overview]
Message-ID: <CAMfbzvBDw2vZm_p2KCMRUuCAYpWf4ywwpQdWUW6B3pzaEruZQQ@mail.gmail.com> (raw)
In-Reply-To: <CAMfbzvDxNeD9sF2xc3s7WJA2wmQEhupZWs=eQRfRrMZdKsD=CA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1858 bytes --]
Updated patch attached.
2015-09-14 17:06 GMT-03:00 Vicente Vera <vicentemvp@gmail.com>:
> Hello,
>
> I'm not sure if it's correct, but I changed the license from gpl3+ to
> gpl2+ to keep it consistent with the r-markdown package
> (https://www.gnu.org/licenses/gpl-faq.html#v2v3Compatibility). Thanks
> for figuring that out.
>
> New patch attached.
>
> 2015-09-14 8:17 GMT-03:00 Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>:
>> Hi Vicente,
>>
>>> From 36f94f07cba5edea4897ac36b92a73bfc6a3258b Mon Sep 17 00:00:00 2001
>>> From: Vicente Vera Parra <vicentemvp@gmail.com>
>>> Date: Sun, 13 Sep 2015 13:20:29 -0300
>>> Subject: [PATCH 11/19] gnu: Add r-knitr.
>>
>>> * gnu/packages/statistics.scm (r-knitr): New variable.
>>
>> [...]
>>
>>> + (synopsis "General-Purpose Package for Dynamic Report Generation in R")
>>> + (description
>>> + "Provides a general-purpose tool for dynamic report generation in
>>> +R using Literate Programming techniques.")
>>
>> As before, please provide a better description (at least by replacing
>> “Provides” in the first sentence with “This package provides”); and use
>> lower-case in the synopsis.
>>
>>> + (license license:gpl3+)))
>>
>> I don’t think this is correct. The package actually doesn’t declare the
>> version of the GPL. There are no license headers I could find and all
>> it says is
>>
>> “This package is free and open source software, licensed under GPL.”
>>
>> Furthermore, as noted before, there might be a license conflict when
>> combining “r-knitr” with “r-markdown”, because the latter is released
>> under “GPLv2 only”.
>>
>> I just asked the author about what version of the GPL was intended
>> here[1].
>>
>> ~~ Ricardo
>>
>> [1]: https://github.com/yihui/knitr/issues/566#issuecomment-140042571
[-- Attachment #2: 0011-gnu-Add-r-knitr.patch --]
[-- Type: text/x-patch, Size: 1760 bytes --]
From 730f8b640d70e9693bce65ded47ba91d4b6af233 Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Tue, 15 Sep 2015 14:20:13 -0300
Subject: [PATCH 11/19] gnu: Add r-knitr.
* gnu/packages/statistics.scm (r-knitr): New variable.
---
gnu/packages/statistics.scm | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 050a507..e5b71f9 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -731,3 +731,32 @@ http://en.wikipedia.org/wiki/Markdown for more information about Markdown.")
"This package implements the libyaml YAML 1.1 parser and
emitter (http://pyyaml.org/wiki/LibYAML) for R.")
(license license:bsd-3)))
+
+(define-public r-knitr
+ (package
+ (name "r-knitr")
+ (version "1.11")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://cran/src/contrib/knitr_"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "1ikjla0hnpjfkdbydqhhqypc0aiizbi4nyn8c694sdk9ca4jasdd"))))
+ (build-system r-build-system)
+ (propagated-inputs
+ `(("r-evaluate" ,r-evaluate)
+ ("r-digest" ,r-digest)
+ ("r-formatr" ,r-formatr)
+ ("r-highr" ,r-highr)
+ ("r-markdown" ,r-markdown)
+ ("r-stringr" ,r-stringr)
+ ("r-yaml" ,r-yaml)))
+ (home-page
+ "http://yihui.name/knitr/")
+ (synopsis
+ "General-purpose package for dynamic report generation in R")
+ (description
+ "This package provides a general-purpose tool for dynamic report
+generation in R using Literate Programming techniques.")
+ (license license:gpl2+)))
--
2.5.2
next prev parent reply other threads:[~2015-09-15 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 16:51 [PATCH 11/19] gnu: Add r-knitr Vicente Vera
2015-09-14 11:17 ` Ricardo Wurmus
2015-09-14 20:06 ` Vicente Vera
2015-09-15 17:41 ` Vicente Vera [this message]
2015-09-16 9:51 ` Ricardo Wurmus
2015-09-22 15:08 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMfbzvBDw2vZm_p2KCMRUuCAYpWf4ywwpQdWUW6B3pzaEruZQQ@mail.gmail.com \
--to=vicentemvp@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.