From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vicente Vera Subject: Re: [PATCH 01/19] gnu: Add r-assertthat. Date: Sun, 13 Sep 2015 19:20:47 -0300 Message-ID: References: <871te29jc0.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e01184240571a40051fa85c82 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbFdh-0003Vr-Ro for guix-devel@gnu.org; Sun, 13 Sep 2015 18:20:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbFdg-0008BZ-O6 for guix-devel@gnu.org; Sun, 13 Sep 2015 18:20:49 -0400 Received: from mail-ob0-x230.google.com ([2607:f8b0:4003:c01::230]:36383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbFdg-0008BT-I5 for guix-devel@gnu.org; Sun, 13 Sep 2015 18:20:48 -0400 Received: by obqa2 with SMTP id a2so95978252obq.3 for ; Sun, 13 Sep 2015 15:20:47 -0700 (PDT) In-Reply-To: <871te29jc0.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --089e01184240571a40051fa85c82 Content-Type: text/plain; charset=UTF-8 Hi Ricardo, CRAN importer? Hmm, just made a very useful discovery! I feel ashamed now. Attached goes the 1st patch with the modified copyright header and the fixed typo (actually, it came with the package description in CRAN). 2015-09-13 17:04 GMT-03:00 Ricardo Wurmus : > Thank you very much for these patches! Did you use the CRAN importer > for them? > > You should add your name to the copyright header at the top of the file > (maybe as part of the first patch). > >> * gnu/packages/statistics.scm (r-assertthat): New variable. > > [...] > >> + (uri (string-append "mirror://cran/src/contrib/assertthat_" >> + version ".tar.gz")) > > I wonder if new patches should already contain the archive URI in > addition to the default URI. It was pointed out in a previous thread > that the simple URI produced by the importer is only valid for the > latest version. > >> + (description >> + "Assertthat is an extension to stopifnot() that makes it easy to >> +declare the pre and post conditions that you code should satisfy, > > s/you code/your code/ > >> +while also producing friendly error messages so that your users know >> +what they've done wrong.") > > ~~ Ricardo > --089e01184240571a40051fa85c82 Content-Type: text/x-patch; charset=UTF-8; name="0001-gnu-Add-r-assertthat.patch" Content-Disposition: attachment; filename="0001-gnu-Add-r-assertthat.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iej27oyx0 RnJvbSBjZGY0ODIyZTljNzU3ODQ2NWVlOTdmMGQyZTIzZmRiODBjMTM1ZWVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWNlbnRlIFZlcmEgUGFycmEgPHZpY2VudGVtdnBAZ21haWwu Y29tPgpEYXRlOiBTdW4sIDEzIFNlcCAyMDE1IDE5OjA5OjU5IC0wMzAwClN1YmplY3Q6IFtQQVRD SF0gZ251OiBBZGQgci1hc3NlcnR0aGF0LgoKKiBnbnUvcGFja2FnZXMvc3RhdGlzdGljcy5zY20g KHItYXNzZXJ0dGhhdCk6IE5ldyB2YXJpYWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvc3RhdGlzdGlj cy5zY20gfCAyMSArKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAyMSBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Muc2NtIGIvZ251 L3BhY2thZ2VzL3N0YXRpc3RpY3Muc2NtCmluZGV4IDI5Y2QzNGEuLjBjNjAzODIgMTAwNjQ0Ci0t LSBhL2dudS9wYWNrYWdlcy9zdGF0aXN0aWNzLnNjbQorKysgYi9nbnUvcGFja2FnZXMvc3RhdGlz dGljcy5zY20KQEAgLTEsNSArMSw2IEBACiA7OzsgR05VIEd1aXggLS0tIEZ1bmN0aW9uYWwgcGFj a2FnZSBtYW5hZ2VtZW50IGZvciBHTlUKIDs7OyBDb3B5cmlnaHQgwqkgMjAxNSBSaWNhcmRvIFd1 cm11cyA8cmVrYWRvQGVsZXBobHkubmV0PgorOzs7IENvcHlyaWdodCDCqSAyMDE1IFZpY2VudGUg VmVyYSA8dmljZW50ZW12cEBnbWFpbC5jb20+CiA7OzsKIDs7OyBUaGlzIGZpbGUgaXMgcGFydCBv ZiBHTlUgR3VpeC4KIDs7OwpAQCAtNDk4LDMgKzQ5OSwyMyBAQCBieSBzdGVwIGZyb20gbXVsdGlw bGUgZGF0YSBzb3VyY2VzLiAgSXQgYWxzbyBpbXBsZW1lbnRzIGEgc29waGlzdGljYXRlZAogbXVs dGlkaW1lbnNpb25hbCBjb25kaXRpb25pbmcgc3lzdGVtIGFuZCBhIGNvbnNpc3RlbnQgaW50ZXJm YWNlIHRvIG1hcCBkYXRhIHRvCiBhZXN0aGV0aWMgYXR0cmlidXRlcy4iKQogICAgIChsaWNlbnNl IGxpY2Vuc2U6Z3BsMispKSkKKworKGRlZmluZS1wdWJsaWMgci1hc3NlcnR0aGF0CisgIChwYWNr YWdlCisgICAgKG5hbWUgInItYXNzZXJ0dGhhdCIpCisgICAgKHZlcnNpb24gIjAuMSIpCisgICAg KHNvdXJjZSAob3JpZ2luCisgICAgICAgICAgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAg ICAgICAgICAodXJpIChzdHJpbmctYXBwZW5kICJtaXJyb3I6Ly9jcmFuL3NyYy9jb250cmliL2Fz c2VydHRoYXRfIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZlcnNpb24gIi50 YXIuZ3oiKSkKKyAgICAgICAgICAgICAgKHNoYTI1NgorICAgICAgICAgICAgICAgKGJhc2UzMiAi MGR3c3FhanlnbGZzY3FpbGo4NDNxZnFuMW5kYnFwc3dhN2I0bDFkNjMzcWprOWQ2OHFxayIpKSkp CisgICAgKGJ1aWxkLXN5c3RlbSByLWJ1aWxkLXN5c3RlbSkKKyAgICAoaG9tZS1wYWdlICJodHRw czovL2dpdGh1Yi5jb20vaGFkbGV5L2Fzc2VydHRoYXQiKQorICAgIChzeW5vcHNpcyAiRWFzeSBw cmUgYW5kIHBvc3QgYXNzZXJ0aW9ucyIpCisgICAgKGRlc2NyaXB0aW9uCisgICAgICJBc3NlcnR0 aGF0IGlzIGFuIGV4dGVuc2lvbiB0byBzdG9waWZub3QoKSB0aGF0IG1ha2VzIGl0IGVhc3kgdG8g ZGVjbGFyZQordGhlIHByZSBhbmQgcG9zdCBjb25kaXRpb25zIHRoYXQgeW91ciBjb2RlIHNob3Vs ZCBzYXRpc2Z5LCB3aGlsZSBhbHNvCitwcm9kdWNpbmcgZnJpZW5kbHkgZXJyb3IgbWVzc2FnZXMg c28gdGhhdCB5b3VyIHVzZXJzIGtub3cgd2hhdCB0aGV5J3ZlIGRvbmUKK3dyb25nLiIpCisgICAg KGxpY2Vuc2UgbGljZW5zZTpncGwzKykpKQotLSAKMi41LjEKCg== --089e01184240571a40051fa85c82--