Re: [PATCH] gnu: add vte-ng

[Mckinley Olsen <mck.olsen@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]

Hey Alex, I'm hoping this patch is up to snuff.
I've changed the package definition to depend on the latest tagged
source and provided a synopsis & description specific to vte-ng.
Let me know if you have any other concerns that need to be addressed.
Thanks!

On Sun, Apr 10, 2016 at 1:42 AM, Alex Kost <alezost@gmail.com> wrote:
> Mckinley Olsen (2016-04-09 21:10 +0300) wrote:
>
>> Sorry, I'm new to mailing lists; hope this gets to the right place
>
> Oops, it wasn't Cc-ed to guix-devel list, but since I'm replying, the
> others will see it anyway.
>
>> I used the git checkout, as I started writing termite's package first
>> and realized it needed a recursive checkout; of course I copied over
>> that implementation to here. Thanks for the suggestion to use the
>> tarball, I've made that change
>>
>> I used the version I did because I was using the package definition
>> in Nix as a guideline. I've worked through packaging a slightly more
>> up-to-date version (submitted patch to update pcre2 to required
>> version), but am stuck on getting versions 0.43.91 and newer packaged
>> due to an error (vteconv.cc:774:40: error: missing sentinel in
>> function call [-Werror=format=]), which I believe was caused by this
>> change: https://bugzilla.gnome.org/show_bug.cgi?id=762863
>>
>> I'm quite new to the gnu build system, so it has taken me some time
>>
>> Sorry I haven't been able to get the newest packaged up. I've just
>> found that the gnome-updates branch contains some code working
>> through the exact error I'm seeing with vte-ng, so I might reach out
>> for them or wait for it to be merged.
>
> Ah, I think it's ok to wait for gnome-updates merge.  Thanks for working
> on the new packages!
>
> --
> Alex

[-- Attachment #2: 0001-gnu-packages-gnome.scm-vte-ng-New-variable.patch --]
[-- Type: application/octet-stream, Size: 2115 bytes --]

From 5fa75edd3e03839dc7fc81134a9bd37072409f88 Mon Sep 17 00:00:00 2001
From: McKinley Olsen <mck.olsen@gmail.com>
Date: Tue, 31 May 2016 14:28:44 -0600
Subject: [PATCH] * gnu/packages/gnome.scm (vte-ng): New variable.

---
 gnu/packages/gnome.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 0d9c946..265fd04 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1787,6 +1787,40 @@ gnome-terminal, but can also be used to embed a console/terminal in games,
 editors, IDEs, etc.")
     (license license:lgpl2.1+)))
 
+(define-public vte-ng
+  (package
+    (inherit vte)
+    (name "vte-ng")
+    (version "0.44.1.b")
+    (native-inputs
+      `(("gtk-doc" ,gtk-doc)
+        ("gperf" ,gperf)
+        ("autoconf" ,autoconf)
+        ("automake" ,automake)
+        ("libtool" ,libtool)
+        ,@(package-native-inputs vte)))
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/thestinger/"
+                                  name
+                                  "/archive/"
+                                  version
+                                  ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1mhz4i1qkdlrs49vgm7nsrb60lry9v6wsgwsmji7fln1nyrp1pag"))))
+    (arguments
+      `(#:configure-flags '("CXXFLAGS=-Wformat=0")
+        #:phases (modify-phases %standard-phases
+                  (add-after 'unpack 'bootstrap
+                    (lambda _
+                      (setenv "NOCONFIGURE" "true")
+                      (zero? (system* "sh" "autogen.sh")))))))
+  (synopsis "Enhanced VTE terminal widget")
+  (description "VTE, with additional functions exposed for keyboard text
+    selection and URL hints.")))
+
 ;; provides vte 2.90, required for some terminal emulators
 ;; tilda bug: https://github.com/lanoxx/tilda/issues/94
 ;; pantheon-terminal bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=788021
-- 
2.7.4