[PATCH] gnu: fontforge: Update to 20160404.

[PATCH] gnu: fontforge: Update to 20160404.

[alírio eyng]

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: 0001-gnu-fontforge-Update-to-20160404.patch --]
[-- Type: text/x-patch, Size: 1992 bytes --]

From 4266012ea39ebcba97e7c2d61c26fd3f42b75cb9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?al=C3=ADrio=20eyng?= <alirioeyng@gmail.com>
Date: Thu, 7 Apr 2016 19:04:07 +0000
Subject: [PATCH] gnu: fontforge: Update to 20160404.

* gnu/packages/fontutils.scm (fontforge): Update to 20160404.
[source](snippet): Remove tottf.c modification.
---
 gnu/packages/fontutils.scm | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
index ff10a4a..bb93421 100644
--- a/gnu/packages/fontutils.scm
+++ b/gnu/packages/fontutils.scm
@@ -341,14 +341,14 @@ definitions.")
 (define-public fontforge
   (package
    (name "fontforge")
-   (version "20150824")
+   (version "20160404")
    (source (origin
             (method url-fetch)
             (uri (string-append
                   "https://github.com/fontforge/fontforge/releases/download/"
-                  version "/fontforge-" version ".tar.gz"))
+                  version "/fontforge-dist-" version ".tar.gz"))
             (sha256 (base32
-                     "0gfcm8yn1d30giqhdwbchnfnspcqypqdzrxlhqhwy1i18wgl0v2v"))
+                     "1kavnhbkzc1hk6f39fynq9s0haama81ddrbld4b5x60d0dbaawvc"))
             (modules '((guix build utils)))
             (snippet
              '(begin
@@ -359,12 +359,7 @@ definitions.")
                  (("^FONTFORGE_MODTIME_STR=.*$")
                   "FONTFORGE_MODTIME_STR=\"15:50 CET 19-Mar-2016\"\n")
                  (("^FONTFORGE_VERSIONDATE=.*$")
-                  "FONTFORGE_VERSIONDATE=\"20160319\"\n"))
-
-               ;; Make TTF builds bit-reproducible by clearing the timestamp
-               ;; that goes in TTF files.
-               (substitute* "fontforge/tottf.c"
-                 (("cvt_unix_to_1904\\(now") "cvt_unix_to_1904(0"))))))
+                  "FONTFORGE_VERSIONDATE=\"20160319\"\n"))))))
    (build-system gnu-build-system)
    (native-inputs
     `(("pkg-config" ,pkg-config)))
-- 
1.9.1

Re: [PATCH] gnu: fontforge: Update to 20160404.

[Eric Bavier]

On Thu, 7 Apr 2016 19:18:35 +0000
alírio eyng <alirioeyng@gmail.com> wrote:

> * gnu/packages/fontutils.scm (fontforge): Update to 20160404.
> [source](snippet): Remove tottf.c modification.
> ---
>  gnu/packages/fontutils.scm | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
> index ff10a4a..bb93421 100644
> --- a/gnu/packages/fontutils.scm
> +++ b/gnu/packages/fontutils.scm
> @@ -341,14 +341,14 @@ definitions.")
>  (define-public fontforge
>    (package
>     (name "fontforge")
> -   (version "20150824")
> +   (version "20160404")
>     (source (origin
>              (method url-fetch)
>              (uri (string-append
>                    "https://github.com/fontforge/fontforge/releases/download/"
> -                  version "/fontforge-" version ".tar.gz"))
> +                  version "/fontforge-dist-" version ".tar.gz"))
>              (sha256 (base32
> -                     "0gfcm8yn1d30giqhdwbchnfnspcqypqdzrxlhqhwy1i18wgl0v2v"))
> +                     "1kavnhbkzc1hk6f39fynq9s0haama81ddrbld4b5x60d0dbaawvc"))
>              (modules '((guix build utils)))
>              (snippet
>               '(begin
> @@ -359,12 +359,7 @@ definitions.")
>                   (("^FONTFORGE_MODTIME_STR=.*$")
>                    "FONTFORGE_MODTIME_STR=\"15:50 CET 19-Mar-2016\"\n")
>                   (("^FONTFORGE_VERSIONDATE=.*$")
> -                  "FONTFORGE_VERSIONDATE=\"20160319\"\n"))
> -
> -               ;; Make TTF builds bit-reproducible by clearing the timestamp
> -               ;; that goes in TTF files.
> -               (substitute* "fontforge/tottf.c"
> -                 (("cvt_unix_to_1904\\(now") "cvt_unix_to_1904(0"))))))
> +                  "FONTFORGE_VERSIONDATE=\"20160319\"\n"))))))

I'm glad they fixed the TTF reproducibility upstream.  Does
FONTFORGE_VERSIONDATE not need to be updated?

LGTM,
`~Eric

Re: [PATCH] gnu: fontforge: Update to 20160404.

[alírio eyng]

On 4/8/16, Eric Bavier <ericbavier@openmailbox.org> wrote:
> Does
> FONTFORGE_VERSIONDATE not need to be updated?
this marks the time when fontforge builds became reproducible in guix.
otherwise it's pretty arbitrary.
ludo, wdyt?

Re: [PATCH] gnu: fontforge: Update to 20160404.

[Ludovic Courtès]

alírio eyng <alirioeyng@gmail.com> skribis:

> On 4/8/16, Eric Bavier <ericbavier@openmailbox.org> wrote:
>> Does
>> FONTFORGE_VERSIONDATE not need to be updated?
> this marks the time when fontforge builds became reproducible in guix.
> otherwise it's pretty arbitrary.
> ludo, wdyt?

I agree, it’s arbitrary and not very informative anyway.

Ludo’.