From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederick Muriithi Subject: Re: [PATCH 1/4] gnu: Add python-pytest-3.0.7 Date: Sun, 26 Mar 2017 18:29:04 +0300 Message-ID: References: <20170326092335.3912-1-fredmanglis@gmail.com> <20170326151019.GA13943@monza> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c05fd8218aaf6054ba3e396 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csA6N-0000W5-Kc for guix-devel@gnu.org; Sun, 26 Mar 2017 11:29:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csA6M-0006T7-5X for guix-devel@gnu.org; Sun, 26 Mar 2017 11:29:07 -0400 Received: from mail-yw0-x236.google.com ([2607:f8b0:4002:c05::236]:36071) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1csA6M-0006S3-0X for guix-devel@gnu.org; Sun, 26 Mar 2017 11:29:06 -0400 Received: by mail-yw0-x236.google.com with SMTP id i203so17520812ywc.3 for ; Sun, 26 Mar 2017 08:29:05 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Pjotr Prins Cc: guix-devel@gnu.org --94eb2c05fd8218aaf6054ba3e396 Content-Type: text/plain; charset=UTF-8 I don't really see a reason why not. I have to point out though, that when writing the definition, I found python-pytest-2.9.2 also defined, with a note that it's there until all packages can be upgraded to use a more recent pytest. Since I don't know what the progress on that is, I decided to err on the side of caution, and just add it with a note on why it's needed. On 26 Mar 2017 6:12 p.m., "Pjotr Prins" wrote: Is there a reason not to just update this package? Otherwise LGTM On Sun, Mar 26, 2017 at 12:23:32PM +0300, Muriithi Frederick Muriuki wrote: > * gnu/packages/python.scm (python-pytest-3.0.7): New variable. > --- > gnu/packages/python.scm | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index 7aae8fc..52be497 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -1845,6 +1845,24 @@ and many external plugins.") > line))) > #t))))))) > > +;; This package is used by Sphinx version 1.5.2 and up > +(define-public python-pytest-3.0.7 > + (package > + (inherit python-pytest-2.9.2) > + (name "python-pytest") > + (version "3.0.7") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "pytest" version)) > + (sha256 > + (base32 > + "1asc4b2nd2a4f0g3r12y97rslq5wliji7b73wwkvdrm5s7mrc1mp")))) > + (native-inputs > + `(("python-nose" ,python-nose) > + ("python-mock" ,python-mock) > + ("python-hypothesis" ,python-hypothesis))))) > + > (define-public python-pytest-cov > (package > (name "python-pytest-cov") > -- > 2.10.2 > --94eb2c05fd8218aaf6054ba3e396 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I don't really see a reason why not. I have to point = out though, that when writing the definition, I found python-pytest-2.9.2 a= lso defined, with a note that it's there until all packages can be upgr= aded to use a more recent pytest.

Since I don't know what the progress on that is, I decided to err o= n the side of caution, and just add it with a note on why it's needed.<= /div>

On 26 = Mar 2017 6:12 p.m., "Pjotr Prins" <pjotr.public12@thebird.nl> wrote:
Is there a reason not to just update this = package?

Otherwise LGTM

On Sun, Mar 26, 2017 at 12:23:32PM +0300, Muriithi Frederick Muriuki wrote:=
> * gnu/packages/python.scm (python-pytest-3.0.7): New variable.
> ---
>=C2=A0 gnu/packages/python.scm | 18 ++++++++++++++++++
>=C2=A0 1 file changed, 18 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 7aae8fc..52be497 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -1845,6 +1845,24 @@ and many external plugins.")
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0line)))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#t)))))))
>
> +;; This package is used by Sphinx version 1.5.2 and up
> +(define-public python-pytest-3.0.7
> +=C2=A0 (package
> +=C2=A0 =C2=A0 (inherit python-pytest-2.9.2)
> +=C2=A0 =C2=A0 (name "python-pytest")
> +=C2=A0 =C2=A0 (version "3.0.7")
> +=C2=A0 =C2=A0 (source
> +=C2=A0 =C2=A0 =C2=A0(origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(method url-fetch)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (pypi-uri "pytest" version)= )
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"1asc4b2nd2a4f0g3r12y97rs= lq5wliji7b73wwkvdrm5s7mrc1mp"))))
> +=C2=A0 =C2=A0 (native-inputs
> +=C2=A0 =C2=A0 =C2=A0`(("python-nose" ,python-nose)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0("python-mock" ,python-mock)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0("python-hypothesis" ,python-hyp= othesis)))))
> +
>=C2=A0 (define-public python-pytest-cov
>=C2=A0 =C2=A0 (package
>=C2=A0 =C2=A0 =C2=A0 (name "python-pytest-cov")
> --
> 2.10.2
>

--94eb2c05fd8218aaf6054ba3e396--