From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederick Muriithi Subject: Re: [PATCH] gnu: Add ldc-1.1.0-beta4 Date: Wed, 4 Jan 2017 18:27:48 +0300 Message-ID: References: <20170104155234.1463ac4e@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOnU3-0003lS-5D for guix-devel@gnu.org; Wed, 04 Jan 2017 10:28:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOnU2-0003Cn-4X for guix-devel@gnu.org; Wed, 04 Jan 2017 10:28:11 -0500 Received: from mail-yw0-x244.google.com ([2607:f8b0:4002:c05::244]:33180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cOnU1-0003CY-W5 for guix-devel@gnu.org; Wed, 04 Jan 2017 10:28:10 -0500 Received: by mail-yw0-x244.google.com with SMTP id s68so41965559ywg.0 for ; Wed, 04 Jan 2017 07:28:09 -0800 (PST) In-Reply-To: <20170104155234.1463ac4e@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org On Wed, Jan 4, 2017 at 5:52 PM, Danny Milosavljevic wrote: > Hi, > > On Wed, 4 Jan 2017 17:01:14 +0300 > Frederick Muriithi wrote: > >> Added ldc-1.1.0-beta4 since all other beta versions from there seem to >> reuse the same phobos, druntime and dmd-testsuite. > > Thanks for the patch! > > Hmm, you added gdb to the native-inputs but commented out the gdb invocations later? Why? > I worked through the definition at the beginning adding required packages, then when builds were successful, but tests were failing, I went through the tests trying to figure out where the issues were, and fixing them. For the gdb invocations, the error message kept pointing to the Makefile as where the issue was, so I tried to go as close to the error as I could with my current knowledge. I think that's only one of a number of invocations, but I might be wrong. > Also, could you ask upsteam whether they add a version flag (or something) for the http tests? So it can be enabled/disabled without huge patches in the future... > Cool. I will. > Also, why did you comment out unzip? You can add "unzip" to native-inputs. > Hmmm, it never occurred to me that the issue causing the zip tests to fail was that unzip was missing. The error messages in the failing tests did not point to that. I will fix this > Also, why do you add another "patch-phobos" phase? I think the one in ldc, from which you inherit, does the same, no? > Hmm, my understanding of how the package definitions work might be incomplete: It seemed to me like after you inherited, from a package, and then added a definition in any of the variables, the new variables would NOT add to the values of the older ones but rather, they would completely overwrite the older one. I will give it one more whirl. > I think I had the same problem with tzNames before. I think one of the functions there doesn't interpret its argument as a relative path if it contains a slash anywhere, ruining your /gnu/store prefix or something. Please look into it. Cool. Let me work on those items, and maybe submit a better patch later -- Frederick M. Muriithi